0.83: Format colors isn't working for custom file extensions

Reported bugs that have been closed and/or resolved

Moderators: XnTriq, helmut, xnview, Dreamer

Erixx haxx
Posts: 330
Joined: Tue Jul 28, 2015 10:37 am

Re: 0.83: Format colors isn't working

Postby Erixx haxx » Tue Feb 28, 2017 8:14 pm

Hi:

Same thing

Code: Select all

formatColor-0="[jpeg],0 170 255,0 0 0"
formatColor-1="[gif],220 235 220,0 0 0"
formatColor-2="[png],232 222 220,0 0 0"
formatColor-3="[bmp],227 227 255,0 0 0"
formatColor-4="[tiff],192 197 235,0 0 0"
formatColor-5="[tga],230 255 255,0 0 0"
formatColor-6="[iff],247 235 235,0 0 0"
formatColor-7="[sgi],247 237 242,0 0 0"
formatColor-8="[pcx],235 230 230,0 0 0"
formatColor-9="[psd],255 255 227,0 0 0"
formatColor-10="[pcd],235 215 235,0 0 0"
formatColor-11="[psp],237 208 163,0 0 0"
formatColor-12="[pict],202 202 255,0 0 0"
formatColor-13="[xpm],242 227 227,0 0 0"
formatColor-14="[xbm],216 216 216,0 0 0"
formatColor-15="[pbm],191 191 182,0 0 0"
formatColor-16="[pgm],207 207 197,0 0 0"
formatColor-17="[ppm],235 225 159,0 0 0"
formatColor-18="[ras],255 255 227,0 0 0"
formatColor-19="[wmf],187 187 187,0 0 0"
formatColor-20="[emf],212 212 212,0 0 0"
formatColor-21="[ico],217 247 227,0 0 0"
formatColor-22="[cur],217 247 227,0 0 0"
formatColor-23="[ani],217 247 227,0 0 0"
formatColor-24="[fpx],229 255 255,0 0 0"
formatColor-25="[jp2],237 237 202,0 0 0"
formatColor-26="svg,57 0 171,0 0 0"
useFormatColor=true
selectedColor=10 36 106
labelColor-0=255 85 0
labelColor-1=253 253 253
labelColor-2=230 0 0
labelBColor-0=24 24 24
labelBColor-1=85 0 0
labelBColor-2=25 25 25


Screen:
XnViewMp_v0.84_2017-02-28 15.03.17_cr.jpg


Also Note: When Adding with the options panel, it automatic puts it in with brackets.
I removed them manually. No effect unless I put it Above .jpeg

User avatar
xnview
Author of XnView
Posts: 27030
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: 0.83: Format colors isn't working

Postby xnview » Tue Feb 28, 2017 8:21 pm

i can now reproduce only in detail view, i don't understand why. could you confirm that all is ok in Thumbnails view?
Pierre.

Erixx haxx
Posts: 330
Joined: Tue Jul 28, 2015 10:37 am

Re: 0.83: Format colors isn't working

Postby Erixx haxx » Tue Feb 28, 2017 8:28 pm

xnview wrote:i can now reproduce only in detail view, i don't understand why. could you confirm that all is ok in Thumbnails view?


I'm not sure, because I have set custom colors for the labels.
Here's What I see in thumbs + labels

Screen:
XnViewMP_2017-02-28 15.24.37_cr.jpg

User avatar
xnview
Author of XnView
Posts: 27030
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: 0.83: Format colors isn't working

Postby xnview » Wed Mar 01, 2017 7:51 am

O.k., thank you, I can also reproduce the problem. Issue 1138 is fixed in next version.
Pierre.

User avatar
xnview
Author of XnView
Posts: 27030
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: 0.83: Format colors isn't working

Postby xnview » Thu Mar 16, 2017 8:49 am

This problem is supposed to be fixed in XnView MP 0.85 beta 1. Please check and confirm the bug fix here.
Pierre.

Erixx haxx
Posts: 330
Joined: Tue Jul 28, 2015 10:37 am

Re: 0.83: Format colors isn't working

Postby Erixx haxx » Fri Mar 17, 2017 5:47 am

Hello:

This Still seems to be broken by my test.
:arrow: Same as before, .jpg and .svg take on the same color.

**Edit** I had to manually remove the brackets [] for .svg inside the .ini file, Then it seems to work.
I still think this needs work because the default isn't right, regular users won't know to edit the .ini themselves.

Another question is, is this suppose to work under details view also, or not, So far it is working only under list view..
Thank You..

User avatar
helmut
Posts: 8084
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Re: 0.83: Format colors isn't working

Postby helmut » Fri Mar 17, 2017 7:50 am

Erixx haxx wrote:.. This Still seems to be broken by my test.
Thank you for checking and reporting back, Erixx haxx.

Erixx haxx wrote:... Another question is, is this suppose to work under details view also, or not, So far it is working only under list view..
Thank You..
Works fine for me for all views except "Thumbnails" (Browser: View » View As » Thumbnails). Could you please recheck and post a new bug report if needed?

User avatar
xnview
Author of XnView
Posts: 27030
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: 0.83: Format colors isn't working

Postby xnview » Fri Mar 17, 2017 8:28 am

it's normal that "[svg]" doesn't work, you need to use "svg"
Pierre.

User avatar
helmut
Posts: 8084
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Re: 0.83: Format colors isn't working

Postby helmut » Fri Mar 17, 2017 8:48 am

xnview wrote:it's normal that "[svg]" doesn't work, you need to use "svg"
As written before this is really confusing, not consistent, and not user friendly. (By now we have about 25 posts in this topic; this shows how bad it currently is.)

:!: PLEASE :!:
1.) Please change your code so that in the config file the user defined format colours also have a square bracket (just like all other file extensions).
These are supposed to be valid entries in the ini file:

Code: Select all

...
formatColor-25="[jp2],237 237 202,0 0 0"
formatColor-26="[svg],57 0 171,0 0 0"
...

2.) Please add some code that adds the square brackets in case the user has forgotten to enter the brackets in the dialog when adding a new format.

User avatar
xnview
Author of XnView
Posts: 27030
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: 0.83: Format colors isn't working

Postby xnview » Fri Mar 17, 2017 9:13 am

you win :) but in beta 2, you'll need to rebuild the svg thumbnail
Pierre.

User avatar
helmut
Posts: 8084
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Re: 0.83: Format colors isn't working

Postby helmut » Fri Mar 17, 2017 9:38 am

xnview wrote:you win :) but in beta 2, you'll need to rebuild the svg thumbnail
It's a win-win: No more confused users asking over and over again. ;) Thank you!

Erixx haxx
Posts: 330
Joined: Tue Jul 28, 2015 10:37 am

Re: 0.83: Format colors isn't working

Postby Erixx haxx » Fri Mar 17, 2017 10:14 am

Hi:

I agree, My main issue is that this is how Xnviewmp builds the default .ini file. .svg already their With Brackets, so it didn't work until I fixed the .ini

@helmut: I meant details view, Is it suppose to work in details also.


Either way, thanks for giving in Pierre. lol

User avatar
helmut
Posts: 8084
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Re: 0.83: Format colors isn't working

Postby helmut » Fri Mar 17, 2017 10:28 am

Erixx haxx wrote:@helmut: I meant details view, Is it suppose to work in details also.
What do you mean: The detail view in browser (Browser: View » View As » Thumbnails + Details)? Or the info shown in the top left of the Viewer (view mode) when opening an image?

Erixx haxx
Posts: 330
Joined: Tue Jul 28, 2015 10:37 am

Re: 0.83: Format colors isn't working

Postby Erixx haxx » Sat Mar 18, 2017 12:39 am

Hi:

Browser:
View= Details
or
View= Thumbs + details

Another question is, is this suppose to work under details view also, or not, So far it is working only under list view..
Thank You..

User avatar
helmut
Posts: 8084
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Re: 0.83: Format colors isn't working

Postby helmut » Sat Mar 18, 2017 7:39 am

Another question is, is this suppose to work under details view also, or not, So far it is working only under list view..
Thank You..
We're talking at cross-purposes: As written above this works fine for me for all views except "Thumbnails" (Browser: View » View As » Thumbnails). Best is to post a new bug report to investigate and discuss this further.


Return to “Closed/Resolved”

Who is online

Users browsing this forum: No registered users and 1 guest