Deleting files in fullscreen mode deleted all folders!

Reported bugs that have been closed and/or resolved

Moderators: XnTriq, helmut, xnview, Dreamer

vertigo
Posts: 106
Joined: Wed Feb 15, 2017 3:49 pm

Re: Deleting files in fullscreen mode deleted all folders!

Postby vertigo » Thu Feb 16, 2017 7:52 pm

Since I keep full backups, I decided to be a guinea pig :P , but alas, no joy. I was not able to duplicate the original issue (accessing fullscreen via the browser and viewer, using the toolbar shortcut and F11) or helmut's possible scenario. Every time I pressed delete, I was given a prompt asking if I was sure I wanted to delete, then when I said yes the images went to the recycle bin. Also, I was not able to access ".." when cycling through the images in fullscreen. This is certainly a very serious issue, but as I see it, there are multiple things wrong with hic's situation:

- The arrow keys should have worked to cycle through the images. Since they weren't working, it makes me wonder if somehow he managed to move the focus into the left pane of the browser, and up to the parent directory, which was then deleted; however, I've been unable to figure out how to do that, and even if that were the case, the focus should have been brought right back to the fullscreen viewer, thereby making it impossible for the delete request to register for an item selected in the left pane.
- There should have been a dialog box asking for confirmation.
- The folders/files should have gone to the recycle bin (though if they were too big for it they wouldn't, and while Windows asks if you want to permanently delete in this case, XnView DOES NOT and just AUTOMATICALLY PERMANENTLY DELETES the files)
- Pressing the delete key on a folder in the left browser pane doesn't do anything (seems to be related to the Ctrl+C, etc bug)
- Pressing the delete key on the ".." shortcut in the right browser pane doesn't do anything
- All folders BELOW 'Pictures' were deleted, but not the 'Pictures' folder itself (unless hic misstated what happened). This would indicate that each and every folder was individually deleted, which seems very unlikely to have happened, especially considering I can't even get such a thing to happen by really trying.

This is all with the same version and same OS as hic. Please don't take this the wrong way, hic, but are you sure there's not something else you did that may have caused this? Or maybe even a failing hard drive is to blame? I'm happy to help and serve as a test platform for figuring this out, because if indeed XnView did somehow do this I consider that to be a fatal flaw, but as of now I'm stumped.

User avatar
helmut
Moderator
Posts: 8080
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Re: Deleting files in fullscreen mode deleted all folders!

Postby helmut » Thu Feb 16, 2017 9:32 pm

Thanks for trying hard to reproduce the problem. It's actually good to know that in the current 0.84 there is no such bug.

:arrow: Closed (Bug cannot be reproduced.) Please post here in case you should still experience this problem.

User avatar
helmut
Moderator
Posts: 8080
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Re: Deleting files in fullscreen mode deleted all folders!

Postby helmut » Sat Feb 18, 2017 11:33 pm

I think that I could reproduce the problem:

Preparations (using Windows Explorer or XnView)
1. Create a folder "A"
2. Copy an image file into folder "A"
3. Create a subfolder of A and name it "Sub A"

4. Start XnView and browse folder "A"
5. Select the image file and open fullscreen (directly) using context menu "Fullscreen".
6. Press "Del" and confirm the message box to delete the image.
Actual behaviour: XnView displays an empty image. This empty image is folder "Sub A". :bug:
Expected behaviour: ?
7. Press "Del" and you will see a message box "Are you sure to delete "Sub A"?
8. Confirm the message box and your folder "Sub A" will be gone. :bug:

I don't know what should happen when deleting the last image file in Fullscreen mode. But in no case XnView must display non-image files or even folders that are not displayable and allow for deleting them.

:arrow: Reproduced

vertigo
Posts: 106
Joined: Wed Feb 15, 2017 3:49 pm

Re: Deleting files in fullscreen mode deleted all folders!

Postby vertigo » Sat Feb 18, 2017 11:56 pm

Ah, so it's deleting all the files in the folder, after which you can delete the folder. Still doesn't explain how hic would have deleted the parent folder, though, and all the sibling(?) folders. But I would think that if you delete all files in a folder while in fullscreen, it should exit fullscreen.

User avatar
helmut
Moderator
Posts: 8080
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Re: Deleting files in fullscreen mode deleted all folders!

Postby helmut » Sun Feb 19, 2017 12:03 am

vertigo wrote:... Still doesn't explain how hic would have deleted the parent folder, though, and all the sibling(?) folders.
Right. Perhaps hic browsed a top level folder like "My computer"? Just guessing here; I won't try this out.

vertigo wrote:But I would think that if you delete all files in a folder while in fullscreen, it should exit fullscreen.
Yes, returning to browser or viewer (depending where fullscreen was started) would be probably best.

User avatar
xnview
Author of XnView
Posts: 26999
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: Deleting files in fullscreen mode deleted all folders!

Postby xnview » Tue Feb 28, 2017 9:24 am

O.k., thank you, I can also reproduce the problem. Issue 1128 is fixed in next version.
Pierre.

User avatar
xnview
Author of XnView
Posts: 26999
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: Deleting files in fullscreen mode deleted all folders!

Postby xnview » Thu Mar 16, 2017 8:53 am

This problem is supposed to be fixed in XnView MP 0.85 beta 1. Please check and confirm the bug fix here.
Pierre.

User avatar
helmut
Moderator
Posts: 8080
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Re: Deleting files in fullscreen mode deleted all folders!

Postby helmut » Mon Mar 20, 2017 5:04 pm

Problem is not fixed in 0.85 beta 1.

User avatar
xnview
Author of XnView
Posts: 26999
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: Deleting files in fullscreen mode deleted all folders!

Postby xnview » Tue Mar 21, 2017 1:33 pm

helmut wrote:Problem is not fixed in 0.85 beta 1.

you have always
7. Press "Del" and you will see a message box "Are you sure to delete "Sub A"?
8. Confirm the message box and your folder "Sub A" will be gone. :bug:
?
Pierre.

User avatar
helmut
Moderator
Posts: 8080
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Re: Deleting files in fullscreen mode deleted all folders!

Postby helmut » Tue Mar 21, 2017 1:50 pm

xnview wrote:
helmut wrote:Problem is not fixed in 0.85 beta 1.

you have always
7. Press "Del" and you will see a message box "Are you sure to delete "Sub A"?
8. Confirm the message box and your folder "Sub A" will be gone. :bug:
?
Yes. I'll capture a screen video tonight.

User avatar
xnview
Author of XnView
Posts: 26999
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: Deleting files in fullscreen mode deleted all folders!

Postby xnview » Wed Mar 22, 2017 7:39 pm

ok, the view/fullscreen need to be closed is last file
Pierre.

User avatar
xnview
Author of XnView
Posts: 26999
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: Deleting files in fullscreen mode deleted all folders!

Postby xnview » Thu Mar 23, 2017 10:01 am

This problem is supposed to be fixed in XnView MP 0.85 beta 2. Please check and confirm the bug fix here.
Pierre.

User avatar
helmut
Moderator
Posts: 8080
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Re: Deleting files in fullscreen mode deleted all folders!

Postby helmut » Thu Mar 23, 2017 9:44 pm

Confirmed fixed in 0.85 beta 2 (Fullscreen is exited on last image. Thank you, Pierre!)


Return to “Closed/Resolved”

Who is online

Users browsing this forum: No registered users and 1 guest