0.84: Edit IPTC: "Don't Show this message..." doesn't work

Bugs which are supposed to be fixed in the next test version (not available yet)

Moderator: Dreamer

0.84: Edit IPTC: "Don't Show this message..." doesn't work

Postby aFunkyBass » Thu Jan 09, 2014 12:11 am

Ciao everybody, it's my first post here, I love XnVew MP, it's actually the best picture viewer/manager on Linux... Thanks! :)

I had a problem editing IPTC/XMP metadata. The "Don't Show This Message Again" dialog doesn't work as expected...
Here is the sequence that gave me problems:

Select multiple images
Open the metadata dialog (Ctrl+I)
Add some keywords to the first image
Scroll to the next image -> the confirmation to save IPTC data dialog appears
Click on "Don't show this message again" (I have many picture to work with so I need a fast process)
Click on "Yes"
Add more keywords to the next image
Scroll to the next image -> no confirnation dialog appears (assuming the "yes" option was clicked)
Repeat the previus 2 steps for the remaining images
Clicked "cancel" to close the dialog

Now, only the keywords I've added to the first image were saved, all the other keywords were lost... I guess the "Don't Show this message again" assumed "No" to the save confirmation dialog... This is a little tricky... I had to go back, reset the confirmation dialog and start over...

Thanks!

Ubuntu 12.04 - XnView MP v0.64
aFunkyBass
 
Posts: 4
Joined: Wed Jan 08, 2014 11:46 pm

Re: Metadata edit - "Don't Show this message..." doesn't wo

Postby xnview » Mon Mar 24, 2014 4:35 pm

See Issue 207 for current status and details.
Pierre.
User avatar
xnview
Author of XnView
 
Posts: 26738
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Re: Metadata edit - "Don't Show this message..." doesn't wo

Postby helmut » Fri Feb 24, 2017 7:30 pm

I've just tried with v0.84 (Windows) and from what I can see the problem is by design:

Typically, such option on question message boxes are named "[x] Remember my decision and do not ask, again". From what I can see what it does here is "Don't show this message again", only; decision is not remembered.

Apart from the wrong or irritating message box I have the feeling that the dialog is wrong in various ways:
There is a [Save] button when pressing the dialog isn't closed. And the "Cancel" button does closes the dialog but doesn't cancel the saves that you previously made. Quite irritating. :|

I suggest:
1. Rename "Save" button to "Apply" and "Save all" button to "Apply to all files"..
2. Rename "Cancel" button to "Close" button.

Not sure what to do about the message box. Has anyone a good idea?

Related topic:
- 0.84: IPTC window: Wrong workflow with multi-selection
User avatar
helmut
Moderator
 
Posts: 7779
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Re: Metadata edit - "Don't Show this message..." doesn't wo

Postby m.Th. » Sat Feb 25, 2017 8:02 am

Not sure what to do about the message box. Has anyone a good idea?


Like the OP correctly noticed, a DSA dialog should persist not only the DSA state (DSA = yes/no) but also the last modal result (mrYes, mrOk, mrAll, mrSkip, mrCancel etc.) that is the last button pressed, AND, in more complex cases, some user values entered in the edit fields of the said dialog (if any).
m. Th.

The Ascetic Experience - The best photos and texts from Holy Mountain (Athos)

- Dark Themed XnViewMP 0.84 64bit & XnView 2.00 x64 on Win7 x64 -
User avatar
m.Th.
XnThusiast
 
Posts: 1256
Joined: Wed Aug 16, 2006 6:31 am

Re: Metadata edit - "Don't Show this message..." doesn't wo

Postby helmut » Sat Feb 25, 2017 10:41 pm

m.Th. wrote:... Like the OP correctly noticed, a DSA dialog should persist not only the DSA state (DSA = yes/no) but also the last modal result (mrYes, mrOk, mrAll, mrSkip, mrCancel etc.) that is the last button pressed, AND, in more complex cases, some user values entered in the edit fields of the said dialog (if any).
"DSA" = "Don't show again"?

The checkbox should be renamed to "[ ] Remember my decision and do not ask, again" and XnView should remember this decision and not ask, again. Correct?
User avatar
helmut
Moderator
 
Posts: 7779
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Re: Metadata edit - "Don't Show this message..." doesn't wo

Postby XnTriq » Sat Feb 25, 2017 11:45 pm

Remember my answer and don't ask again.” (as previously suggested) or just “Remember, don't ask again”.
User avatar
XnTriq
Moderator & Librarian
 
Posts: 4728
Joined: Sun Sep 25, 2005 3:00 am
Location: Ref Desk

Re: 0.84: Edit IPTC: "Don't Show this message..." doesn't w

Postby m.Th. » Sun Feb 26, 2017 10:28 am

Correct?


Yes.

XnTriq's wording seems more appropriate to me.

(yes, DSA is a common acronym for "Do not Show Again")
m. Th.

The Ascetic Experience - The best photos and texts from Holy Mountain (Athos)

- Dark Themed XnViewMP 0.84 64bit & XnView 2.00 x64 on Win7 x64 -
User avatar
m.Th.
XnThusiast
 
Posts: 1256
Joined: Wed Aug 16, 2006 6:31 am

Re: 0.84: Edit IPTC: "Don't Show this message..." doesn't w

Postby helmut » Sun Feb 26, 2017 9:36 pm

Thank you for your answer, m.Th. Right, text should be as XnTriq has suggested.

Summary for message box when navigating to the previous or next image:
“[x] Remember my answer and don't ask again.”
When checking, XnView must both remember the answer (yes / no) and that the message must no longer be shown.

Message box should only appear if the user has changes that he/she hasn't applied to the current image, yet.

:arrow: Reproduced
___

Note:
Currently, the behaviour of the "Change timestamp" dialog and the "Edit ITPC/IIM" are discussed in several topics. These topics all depend on each other. But I think it's pretty clear that this message box has to be changed as suggested above.
User avatar
helmut
Moderator
 
Posts: 7779
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Re: 0.84: Edit IPTC: "Don't Show this message..." doesn't w

Postby xnview » Mon Feb 27, 2017 9:38 am

O.k., thank you, I'll change the message in next version Issue 1117
Pierre.
User avatar
xnview
Author of XnView
 
Posts: 26738
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Re: 0.84: Edit IPTC: "Don't Show this message..." doesn't w

Postby CameronD » Mon Feb 27, 2017 12:17 pm

helmut wrote:...
Message box should only appear if the user has changes that he/she hasn't applied to the current image, yet.


This is the critical point and it is a bug, while changing the message is just an improvement.

If I select multiple files, write a caption, press "save" and then the "next file" arrow it asks me do I want to save?
But there is no need to save because I have just done it.
It is this annoying habit that caused me to hide the dialogue, although I later forgot whether my default was yes or no.
CameronD
 
Posts: 251
Joined: Wed Aug 01, 2007 1:28 pm
Location: Australia

Re: 0.84: Edit IPTC: "Don't Show this message..." doesn't w

Postby xnview » Thu Mar 16, 2017 8:55 am

This problem is supposed to be fixed in XnView MP 0.85 beta 1. Please check and confirm the bug fix here.
Pierre.
User avatar
xnview
Author of XnView
 
Posts: 26738
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Re: 0.84: Edit IPTC: "Don't Show this message..." doesn't w

Postby CameronD » Thu Mar 16, 2017 2:16 pm

The problem of saying it has changed when it has not for
  • edit the caption and writing a single file - is fixed
  • edit a caption and save to all files and then try to shift to a different file then it erroneously says "IPTC data has changed". NOT fixed
  • switch to any image and "save to all files" in order to write the original caption from that image to all selected images - works properly (I don't think this was broken before)
CameronD
 
Posts: 251
Joined: Wed Aug 01, 2007 1:28 pm
Location: Australia

Re: 0.84: Edit IPTC: "Don't Show this message..." doesn't w

Postby helmut » Sat Mar 18, 2017 8:30 am

CameronD wrote:The problem of saying it has changed when it has not for...
@Pierre: Could you please look into the remaining problem? If needed a new bug report could be posted.
User avatar
helmut
Moderator
 
Posts: 7779
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany


Return to Fixed in next test version

Who is online

Users browsing this forum: No registered users and 1 guest