Page 1 of 1

0.84b4: Updater logic - version compare logic typo

Posted: Sun Jan 15, 2017 1:27 pm
by VictorVG
Step fo respond: just unzip and start v0.84 b4
Visual effect: update logic used information on VERSION_INFO, but this structure included old version 0.82.0.0 user can see screenshot:
1.png
1.png (36.04 KiB) Viewed 738 times
I open section Resource on XnViewMP.exe use Far Manager v3.0 + plug-in ImpEx as "Resources\VERSION\00001.0x040C.rc" and see this structure as .RC file:

Code: Select all

#include <windows.h>

VS_VERSION_INFO VERSIONINFO
 FILEVERSION    0,82,0,0
 PRODUCTVERSION 0,82,0,0
 FILEFLAGSMASK  0x17L    // VS_FF_DEBUG|VS_FF_INFOINFERRED|VS_FF_PATCHED|VS_FF_PRERELEASE
 FILEFLAGS      0x0L
 FILEOS         0x4L     // VOS__WINDOWS32
 FILETYPE       0x1L     // VFT_APP
 FILESUBTYPE    0x0L
BEGIN
    BLOCK "StringFileInfo"
    BEGIN
        BLOCK "040c04b0"
        BEGIN
            VALUE "CompanyName",       "XnView, http://www.xnview.com\0"
            VALUE "FileDescription",   "XnViewMP\0"
            // Zero-length item found
            VALUE "FileVersion",       "0.82.0.0\0"
            // Zero-length item found
            VALUE "InternalName",      "XnViewMP\0"
            // Zero-length item found
            VALUE "LegalCopyright",    "Copyright © 2008-2016 XnView\0"
            // Zero-length item found
            VALUE "OriginalFilename",  "xnviewmp.exe\0"
            // Zero-length item found
            VALUE "ProductName",       "XnViewMP Application\0"
            // Zero-length item found
            VALUE "ProductVersion",    "0.82.0.0\0"
        END
    END
    BLOCK "VarFileInfo"
    BEGIN
        VALUE "Translation", 0x40C, 1200
    END
END
I think there is build scripts so that they improve AUTOMATIC change the value of the build number for the exclusion of such amusing incidents.
1.png
1.png (36.04 KiB) Viewed 738 times

Re: Updater logic - version compare logic typo

Posted: Sun Jan 15, 2017 7:26 pm
by helmut
Thanks for reporting, VictorVG. This bug has been observed and reported by various testers, already.

@Pierre:
Would be good if this wrong version comparison was fixed, now. As you can see, this causes confusion over and over, again.

Re: 0.84b4: Updater logic - version compare logic typo

Posted: Mon Jan 16, 2017 11:07 pm
by VictorVG
Earlier, I am having a similar problem, and it's where I rehil introduction of checks on SVN revision number through quite a simple condition:

If SavedSvnRev <= CurrenSvnRev Then Update; Else Skip;

but for the operation of the mechanism I had to keep the car on the SVN revision number of the user in a separate registry subkey. For check SVN revision I use simple NSIS code...

Re: 0.84b4: Updater logic - version compare logic typo

Posted: Tue Feb 28, 2017 2:23 pm
by xnview
O.k., thank you, I can also reproduce the problem. Issue 1134 is fixed in next version.

Re: 0.84b4: Updater logic - version compare logic typo

Posted: Thu Mar 16, 2017 8:51 am
by xnview
This problem is supposed to be fixed in XnView MP 0.85 beta 1. Please check and confirm the bug fix here.

Re: 0.84b4: Updater logic - version compare logic typo

Posted: Mon Mar 20, 2017 4:59 pm
by helmut
When starting the new 0.85 beta 1 it doesn't display the message box telling that a new version is available.

A minor issue:
Though, when manually checking for an update using Help » Check For update nothing happens. Expected: A message box "You're running the latest version of XnView MP" should be displayed.
@Pierre: Let me know in case you want a new bug report for this remaining problem.

Re: 0.84b4: Updater logic - version compare logic typo

Posted: Thu Mar 23, 2017 10:02 am
by xnview
This problem is supposed to be fixed in XnView MP 0.85 beta 2. Please check and confirm the bug fix here.

Re: 0.84b4: Updater logic - version compare logic typo

Posted: Thu Mar 23, 2017 9:51 pm
by helmut
Confirmed fixed in 0.85 beta 2 (Message box says "You're running the latest version of XnView MP.")