Page 1 of 1

Revamped replace/overwrite dialog

Posted: Mon Aug 31, 2015 11:45 pm
by XnTriq
p127385.png
Mock-up
Green background indicates an exact match, red means… Well, you get the idea :mrgreen:

PS: I also like custom fields!

Re: Revamped replace/overwrite dialog

Posted: Tue Sep 01, 2015 4:39 am
by xnview
perhaps the font color in red/green only??

Re: Revamped replace/overwrite dialog

Posted: Tue Sep 01, 2015 7:00 pm
by XnTriq
xnview wrote:perhaps the font color in red/green only??
That would be great, yes :D
p127406.png
  • File size in bytes (if Tools » Options... » File List » Misc. » Use always bytes for filesize is activated)
  • Timestamp including seconds
  • Optional checksum calculation
Do you think this could be incorporated into the dialog for cmd_Compare, too?

Re: Revamped replace/overwrite dialog

Posted: Wed Sep 02, 2015 10:53 am
by xnview
or perhaps simply red when values are different?

Re: Revamped replace/overwrite dialog

Posted: Thu Sep 03, 2015 11:00 pm
by XnTriq
xnview wrote:or perhaps simply red when values are different?
At least for the checksum, I would prefer both (red & green).

Screenshots:

Re: Revamped replace/overwrite dialog

Posted: Sat Sep 05, 2015 1:40 pm
by thibaud
xnview wrote:or perhaps simply red when values are different?
good point.
a single color to indicate the error is what I would do too.
don't ask the user to process more information than needed and keep the ui consistent.
I'm not sure how relevant these md5 check app are in that regard.

Re: Revamped replace/overwrite dialog

Posted: Thu Sep 10, 2015 9:45 pm
by XnTriq
Whoot! Implemented in version 2.34 8)
p127534.png

Re: Revamped replace/overwrite dialog

Posted: Thu Sep 10, 2015 11:04 pm
by obelisk
great work!

Re: Revamped replace/overwrite dialog

Posted: Thu Sep 10, 2015 11:45 pm
by XnTriq
  1. As mentioned in a previous post, Use always bytes for filesize (Tools » Options... » File List » Misc.) should also take effect in the replace dialog, IMO.
  2. To prevent the 32-digit MD5 hash from being truncated, the right column of Replace and With could be moved a little farther to the left.
  3. Making use of PathCompactPathEx (or PathCompactPath?) would improve the display of truncated pathnames: X:\Eeny…Moe\Destination\ vs. X:\EenyMeenyMinyMoe\Des
  4. Although the files are not identical, XnView displays the same checksum for Replace (X:\Test\Destination\placeholder.jpg) as for With (X:\Test\Source\placeholder.jpg). :bug:

Code: Select all

Replace: X:\Test\DST\placeholder.jpg (Exif orientation 1) = 3126b90e4c94b4a19380baa7e567c273
   With: X:\Test\SRC\placeholder.jpg (Exif orientation 2) = aa00fea6eb31e37090fd21f21fa123b6
p127537.zip
placeholder_dst.jpg + placeholder_src.jpg
(334.99 KiB) Downloaded 158 times

Re: Revamped replace/overwrite dialog

Posted: Mon Sep 14, 2015 6:26 am
by Karl02
For symmetry, there should also be functions for "Replace all" and "Skip all". But to avoid too many buttons, there should be a checkbox "[ ] Apply to all".

Re: Revamped replace/overwrite dialog

Posted: Wed Sep 16, 2015 10:37 am
by xnview
XnTriq wrote: [*]Making use of PathCompactPathEx (or PathCompactPath?) would improve the display of truncated pathnames:
it's edit textfield, so no need to shorten filename :)

Re: Revamped replace/overwrite dialog

Posted: Wed Sep 16, 2015 3:00 pm
by XnTriq
xnview wrote:
XnTriq wrote:Making use of PathCompactPathEx (or PathCompactPath?) would improve the display of truncated pathnames
it's edit textfield, so no need to shorten filename :)
Don't tell me you're rejecting my valuable programming tips :P :wink:

But seriously, I see what you mean: Users can select the text (Directory & Name) with the cursor.

Re: Revamped replace/overwrite dialog

Posted: Thu Sep 17, 2015 7:20 am
by xnview
XnTriq wrote:
xnview wrote:it's edit textfield, so no need to shorten filename :)
Don't tell me you're rejecting my valuable programming tips :P :wink:
:P

Re: Revamped replace/overwrite dialog

Posted: Tue Jan 05, 2016 2:45 pm
by XnTriq
XnTriq wrote:Although the files are not identical, XnView displays the same checksum for Replace (X:\Test\Destination\placeholder.jpg) as for With (X:\Test\Source\placeholder.jpg). :bug:

Code: Select all

Replace: X:\Test\DST\placeholder.jpg (Exif orientation 1) = 3126b90e4c94b4a19380baa7e567c273
   With: X:\Test\SRC\placeholder.jpg (Exif orientation 2) = aa00fea6eb31e37090fd21f21fa123b6
p127537.zip
placeholder_dst.jpg + placeholder_src.jpg
This bug hasn't been fixed in the latest release (v2.35).

Re: Revamped replace/overwrite dialog

Posted: Tue Dec 06, 2016 9:30 pm
by XnTriq
The fix isn't listed in the changelog but since v2.36 this feature works as expected. Thank you, Pierre!