Page 1 of 1

MP 0.30 req: Please draw a small line beneath newer tab bar

Posted: Fri Oct 15, 2010 3:12 pm
by budz45
Hi,

I quite like how in 0.30 the tab bar has been placed above the menu. In fact I believe some apps are following this new trend such as Firefox 4.

Anyway this is the smallest GUI request EVER! Wouldn't be neater and distinguishable to draw a small line beneath the tab bar like in this picture I made to show the difference:
Image

Re: MP 0.30 req: Please draw a small line beneath newer tab

Posted: Sun Oct 17, 2010 5:04 pm
by JohnFredC
I am totally opposed to this.

The active tab should be visually integrated with its menu (as it is now)... that's one way how we know which tab is the active one!!!

Re: MP 0.30 req: Please draw a small line beneath newer tab

Posted: Mon Oct 18, 2010 11:57 am
by xnview
I think that you can change that by editing GUI style

Re: MP 0.30 req: Please draw a small line beneath newer tab

Posted: Wed Oct 20, 2010 4:12 pm
by budz45
JohnFredC wrote:I am totally opposed to this.

The active tab should be visually integrated with its menu (as it is now)... that's one way how we know which tab is the active one!!!
But the inactive tab is grey and the active tab is white and that's more than fine, isn't it? Unless on other Windows OS's and cross-platforms the tab widget GUI is completely difference; if so forgive me.
xnview wrote:I think that you can change that by editing GUI style
Hmm how do I do that?

Really the oroginal request here is not that importance like my other requests... I just thought that a small GUI line below tab bar would look a bit better than that faded white look but it's your final decision.

Re: MP 0.30 req: Please draw a small line beneath newer tab

Posted: Wed Oct 20, 2010 5:14 pm
by JohnFredC
2 budz45

Tabs look differently on different systems and with different "styles".

You might want to try View->Style->Motif or View->Style->CDE to get that line under the tabs.

All of the styles have problems, though. I would prefer a mix and match combination of CleanLooks and Plastique, but it is currently 'way to time-consuming for a Windows user to create a new style using an XML editor. Not worth the effort, unfortunately.

Re: MP 0.30 req: Please draw a small line beneath newer tab

Posted: Thu Oct 21, 2010 4:00 am
by XnTriq
budz45 wrote:
xnview wrote:I think that you can change that by editing GUI style
Hmm how do I do that?

Code: Select all

QMenuBar {
border-top: 1px solid red;
}

Re: MP 0.30 req: Please draw a small line beneath newer tab

Posted: Thu Oct 21, 2010 9:06 am
by xnview
I use default GUI widget...

Re: MP 0.30 req: Please draw a small line beneath newer tab

Posted: Thu Oct 21, 2010 8:00 pm
by XnTriq

Re: MP 0.30 req: Please draw a small line beneath newer tab

Posted: Thu Oct 21, 2010 9:51 pm
by budz45
Hi XnTriq, thanks for that tip on the code.

Ok I inputted that code at the very bottom of all that text in the 'theme' window. So now, why has the rest of my GUI turned to dark grey after inputted that tab bar line code. Please advise
Image

Also can I specify a type of dynamic line color which would blend/colour adapt itself to whichever OS I'm running MP on?

Re: MP 0.30 req: Please draw a small line beneath newer tab

Posted: Thu Oct 21, 2010 10:30 pm
by XnTriq
budz45 wrote:Ok I inputted that code at the very bottom of all that text in the 'theme' window. So now, why has the rest of my GUI turned to dark grey after inputted that tab bar line code. Please advise
  1. Quit XnView MP.
  2. Open %AppData%\XnViewMP\default.style in a text editor.
  3. Replace all CSS with QMenuBar { border-top: 1px solid red; }.
  4. Restart XnView MP.
budz45 wrote:Also can I specify a type of dynamic line color which would blend/colour adapt itself to whichever OS I'm running MP on?

Re: MP 0.30 req: Please draw a small line beneath newer tab

Posted: Thu Oct 21, 2010 10:51 pm
by budz45
Thanks buddy :D I did mine in grey colour.

Re: MP 0.30 req: Please draw a small line beneath newer tab

Posted: Fri Oct 22, 2010 3:30 am
by XnTriq
budz45 wrote:Thanks buddy :D I did mine in grey colour.
I used red for this demo only, so it would stick out (like the proverbial sore thumb) in the screenshot.

Since we can't use system color values like ButtonShadow and ThreeDShadow with QT stylesheets, I'll have to settle with this for now:

Code: Select all

QMenuBar {
padding-top: 1px;
border-top: 2px groove darkgray;
}

Re: MP 0.30 req: Please draw a small line beneath newer tab

Posted: Fri Oct 22, 2010 3:24 pm
by budz45
XnTriq wrote:

Code: Select all

QMenuBar {
padding-top: 1px;
border-top: 2px groove darkgray;
}
Yes, thanks I am using this recent one on XP but on Vista there is a slight GUI mishap; on Vista look at the lost piece of vista menu bar after the 'help' menu item;
Image

Re: MP 0.30 req: Please draw a small line beneath newer tab

Posted: Fri Oct 22, 2010 5:00 pm
by XnTriq
budz45 wrote:
XnTriq wrote:

Code: Select all

QMenuBar {
padding-top: 1px;
border-top: 2px groove darkgray;
}
Yes, thanks I am using this recent one on XP but on Vista there is a slight GUI mishap; on Vista look at the lost piece of vista menu bar after the 'help' menu item;
Image
Oh :-|

What happens when you remove the padding, budz?
Or maybe you could try adding a Vista-like gradient to the background:

Code: Select all

QMenuBar {
border-top: 2px groove darkgray;
background-color: qlineargradient(x1:0, y1:0, x2:0, y2:1, stop:0 #fcfdfe, stop:0.5 #cfd7eb stop:1 #e9ecfa);
}

Re: MP 0.30 req: Please draw a small line beneath newer tab

Posted: Fri Oct 22, 2010 5:30 pm
by budz45
Thanks XnTriq, that seemed to fix it, and still retain the custom line on vista :)