Misleading caption of one checkbox should be changed

Ideas for improvements and requests for new features in XnView MP

Moderators: XnTriq, helmut, xnview

herb
Posts: 273
Joined: Sat Jul 18, 2009 3:19 pm

Misleading caption of one checkbox should be changed

Post by herb »

Hello,

Checkbox #6 in "Settings - General - Fileoperation" has caption: "Confirm to save changes to file"
(in German: "Speichern der Änderungen bestätigen")

For me this text is very misleading, because it will be usually interpreted as:
- Save changes always, but ask before in case the checkbox is checked.

BUT the implementation is as follows (which is ok for me):
- save changes to file only in case of it is checked; but ask before
- in case of it is unchecked all changes to an image (done in view-mode via toolbox) are discarded.

Therefore I propose to change the caption to following text:
"Save changes to file in general, and ask before"
(in German: "Änderungen generell speichern, aber zuvor fragen")

Thanks in advance and
Best regards
Herb
cday
XnThusiast
Posts: 4187
Joined: Sun Apr 29, 2012 9:45 am
Location: Cheltenham, U.K.

Re: Misleading caption of one checkbox should be changed

Post by cday »

herb wrote: Checkbox #6 in "Settings - General - Fileoperation" has caption: "Confirm to save changes to file"

For me this text is very misleading, because it will be usually interpreted as:
- Save changes always, but ask before in case the checkbox is checked. ...
BUT the implementation is as follows (which is ok for me):
- save changes to file only in case of it is checked; but ask before
- in case of it is unchecked all changes to an image (done in view-mode via toolbox) are discarded.
When an image is altered, it will normally be saved by the user if the changes are wanted: the setting is an option to remind the user that the changes haven't been saved before the image is closed, before the changes are lost.

Might Prompt to save changes be better? That is possibly clearer and is also short...
herb
Posts: 273
Joined: Sat Jul 18, 2009 3:19 pm

Re: Misleading caption of one checkbox should be changed

Post by herb »

Hello,

thanks for your proposal, but this also does not meet the goal I want to reach.
The more I think about this "text-problem" the more I would like to propose the following:
Replace the existing checkbox with a new one called: "Do not save all changes done in viewer mode"
For me this is a clear statement about the implementation.

As a consequence a small change has to be done also in code.
- checking the old checkbox is: unchecking the new one
- unchecking the old checkbox is: checking the new one

Best regards
Herb
cday
XnThusiast
Posts: 4187
Joined: Sun Apr 29, 2012 9:45 am
Location: Cheltenham, U.K.

Re: Misleading caption of one checkbox should be changed

Post by cday »

herb wrote: ... the [existing] implementation is as follows (which is ok for me):
- save changes to file only in case of it is checked; but ask before
- in case of it is unchecked all changes to an image (done in view-mode via toolbox) are discarded.
I think you may be misunderstanding the existing operation or only looking at part of the overall situation: files that have been edited are never saved automatically: they are saved if the user saves them before closing the image, or they are saved if the user attempts to close the file, the above option is selected, and the user then chooses to save the file...

The option is to be prompted (reminded...), or not, to save the file before it is closed...

Or am I misunderstanding?

On the optimum wording for the option: another option on the same tab is 'Confirm file delete' which is the wording used in XnView Classic... But 'Prompt to save changes' or possibly 'Remind to save changes' seems more intuitive for this option than 'Confirm... ' although ideally the wording should possibly be similar for both options.

Edit: Possibly...

Prompt to confirm delete or 'Prompt to confirm file delete'

Prompt to save changes
herb
Posts: 273
Joined: Sat Jul 18, 2009 3:19 pm

Re: Misleading caption of one checkbox should be changed

Post by herb »

Hello,

thanks for your comments.
Please let me explain what goal I want to reach:
When I display my images I open them in viewer. Then with click on "Next file" I open the next one.

Now you must know that I have images taken in portrait-format, but the EXIF-metadata say it is landscape orientation.
Such an image I have to rotate in viewer.
Now when I try to open the next file the popup "Do you want to save the changes?" is displayed. and I have to answer No (each time).

With an option "Do not save any changes" I can avoid that the popup is displayed.

The existing implementation in XnViewMP 0.64 is Ok.
But changing the caption of the checkbox, it should become more clearer that no attempt is performed to save any change.

Best regards
Herb
User avatar
xnview
Author of XnView
Posts: 44943
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Re: Misleading caption of one checkbox should be changed

Post by xnview »

yes "Prompt to save changes" is perhaps better
Pierre.