0.61: How to crash XnViewMP in few seconds

*** Please report new bugs here! ***

Moderators: XnTriq, helmut, xnview, Dreamer

User avatar
m.Th.
XnThusiast
Posts: 1610
Joined: Wed Aug 16, 2006 6:31 am

0.61: How to crash XnViewMP in few seconds

Post by m.Th. »

How to crash XnViewMP in few seconds. The critical part here is "in few seconds".

How to reproduce:

Have a (sub)root folder (c:\myRoot) with many subfolders (c:\myRoot\sFolder1, c:\myRoot\sFolder2 etc.) and images in it from which at least some of them are not yet 'seen' by XnViewMP.
Perhaps is better for the program to have the default setting to display 4 thumbs for each folder.

Browse the said root folder (c:\myRoot\). The background thread which builds/generates the thumbnails will detect the new folders/items and will start to generate thumbnails.

If the thread isn't finished yet and we'll try to enter in a subfolder (eg. c:\myRoot\foo ) by double-clicking on the folder in the thumbnails pane the program will crash. But for this the user must be quick: double-click on the desired subfolder in the very first few seconds in order to catch the building process. Unfortunately, there are enough users which are very quick... :)
m. Th.

- Dark Themed XnViewMP 1.0 64bit on Win10 x64 -
User avatar
helmut
Moderator
Posts: 8688
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Re: MP 0.61 - How to crash XnViewMP in few seconds

Post by helmut »

After deleting all cached thumbnails I've tried to crash XnView MP 0.61 by clicking around in the folders very quickly but failed: No crash. The only crash occured with a folder with a video. The video played and when clicking further on, XnView crashed. Do your folders contain videos?
User avatar
m.Th.
XnThusiast
Posts: 1610
Joined: Wed Aug 16, 2006 6:31 am

Re: MP 0.61 - How to crash XnViewMP in few seconds

Post by m.Th. »

helmut wrote:After deleting all cached thumbnails I've tried to crash XnView MP 0.61 by clicking around in the folders very quickly but failed: No crash. The only crash occured with a folder with a video. The video played and when clicking further on, XnView crashed. Do your folders contain videos?
Nope.
...or very rarely.

I have 300-600-900 .CR2 (Canon RAW) files ~ 25-35 MB each.

I suspect that the problem is centered around a certain state(s) WRT background thumbnails building thread. I suspect that the same applies to some bugs related to ODM (On-Disk Management) engine: Move files bugs, Rename quirks etc.

IMHO when the ODM kicks in, the Thumbnails Builder should be either:

...suspended in a stable state but this can lead to complications because the ODM can change its working environment by removing (ok, moving) directories around, renaming etc.. Also here, Pierre needs to be sure that the Thumbnails Builder IS Atomic (IOW, nobody from outside can catch it in an internal transformation).

or

...(perhaps, better) canceled. Also, here atomicity must be preserved but the things are simpler.
m. Th.

- Dark Themed XnViewMP 1.0 64bit on Win10 x64 -
User avatar
xnview
Author of XnView
Posts: 38830
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Re: MP 0.61 - How to crash XnViewMP in few seconds

Post by xnview »

I'm not able to reproduce it :(
PS: The thumbnail thread is stopped when you change the folder
Pierre.
BloodyRain2k
Posts: 14
Joined: Wed Oct 31, 2012 3:37 pm

Re: MP 0.61 - How to crash XnViewMP in few seconds

Post by BloodyRain2k »

I had a related problem with this: while the thread is still generating the thumbnails I crashed it multiple times by categorizing an image.
So to be clear about it, it was still generating thumbs and I went to an image that was already thumbed and tried to categorize it and bam, it crashed. And that every time. Took me a while to notice what when wrong there because obviously after the thumbing is finished categorizing works fine.
Win7 HP x64 - XnViewMP x64
User avatar
xnview
Author of XnView
Posts: 38830
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Re: MP 0.61 - How to crash XnViewMP in few seconds

Post by xnview »

BloodyRain2k wrote:So to be clear about it, it was still generating thumbs and I went to an image that was already thumbed and tried to categorize it and bam, it crashed. And that every time. Took me a while to notice what when wrong there because obviously after the thumbing is finished categorizing works fine.
And you are able to reproduce it?
Pierre.
BloodyRain2k
Posts: 14
Joined: Wed Oct 31, 2012 3:37 pm

Re: MP 0.61 - How to crash XnViewMP in few seconds

Post by BloodyRain2k »

xnview wrote:
BloodyRain2k wrote:So to be clear about it, it was still generating thumbs and I went to an image that was already thumbed and tried to categorize it and bam, it crashed. And that every time. Took me a while to notice what when wrong there because obviously after the thumbing is finished categorizing works fine.
And you are able to reproduce it?
Now after I reported it does it not happen anymore -.-'' so, no : (

It's probably more related to the bug where going into fullscreen view assigns set categories to the wrong image.
http://newsgroup.xnview.com/viewtopic.php?f=62&t=28877

I just had it crash now when trying to set some categories to an image and it was the last image in the folder and when switched to the previous one to apply the set categories is crashed instead, so nothing related to still generating thumbs in that case.
Win7 HP x64 - XnViewMP x64
User avatar
m.Th.
XnThusiast
Posts: 1610
Joined: Wed Aug 16, 2006 6:31 am

Re: MP 0.61 - How to crash XnViewMP in few seconds

Post by m.Th. »

xnview wrote:I'm not able to reproduce it :(
PS: The thumbnail thread is stopped when you change the folder
Yes, but in what state?

Perhaps a dangling pointer is somewhere left out?

I have XnView MP set to read the Embedded Thumbnail from the RAW files.
m. Th.

- Dark Themed XnViewMP 1.0 64bit on Win10 x64 -
User avatar
m.Th.
XnThusiast
Posts: 1610
Joined: Wed Aug 16, 2006 6:31 am

Re: MP 0.61 - How to crash XnViewMP in few seconds

Post by m.Th. »

xnview wrote:I'm not able to reproduce it :(
Image

I do.

In 100% of cases. :) ...do you want to send you a package consisting of:

1. Two RAW (Cr2) photos.
2. The best(*) tool to generate the many files / folder structure needed
3. Instructions on how to reproduce it

?

(*) Yes, I'm biased. I wrote the tool. :D
...but don't try to crash it! You'll succeed! :)
m. Th.

- Dark Themed XnViewMP 1.0 64bit on Win10 x64 -
User avatar
xnview
Author of XnView
Posts: 38830
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Re: MP 0.61 - How to crash XnViewMP in few seconds

Post by xnview »

Bug confirmed and will be fixed. See issue Issue 150 for current status and details.
Pierre.