0.86: Can't undo changes made in Crop board

Reported bugs that have been closed and/or resolved

Moderators: XnTriq, xnview, Dreamer

Post Reply
richlux
Posts: 6
Joined: Fri Jun 30, 2017 12:14 am

0.86: Can't undo changes made in Crop board

Post by richlux » Fri Jun 30, 2017 10:13 pm

XnView: MP 0.86 - 64 bit
OS: Windows 7 64bit

After using the Crop button to enter the Crop board and crop an image. The change cannot be undone. It can only be undone if the crop was made outside of the Crop board.

Effect: Image change cannot be undone

To reproduce:
1. Click Crop menu icon
2. Crop part of an image
3. Click Crop button to crop the image
4. Undo is not available

Actual behaviour (bug): Undo is not available after cropping from the Crop board

Expected behaviour: Undo should be available after cropping from the Crop board

Thanks,
Rich

User avatar
xnview
Author of XnView
Posts: 29886
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: 0.86: Can't undo changes made in Crop board

Post by xnview » Sat Jul 08, 2017 1:23 pm

right, i can reproduce the problem
Pierre.

User avatar
miki
Posts: 17
Joined: Wed Oct 04, 2017 2:40 pm
Contact:

Re: 0.86: Can't undo changes made in Crop board

Post by miki » Fri Nov 10, 2017 4:45 pm

The Undo for crop would be indeed very welcome. If I may have one suggestion, please let it remember the last used crop size-position... so after hitting undo, the user can easily re-edit the crop selection and apply it again without the need to specify the crop selection completely again.

It is implemented this way in Zoner Photo Studio and I find it very handy and use it all the time when rearranging the crop.

Also I would very welcome if the crop selection included golden ratio grid and golden spiral besides the thirds grid. The grids could be toggled by Shift+Tab shortcut. I think the golden ratio grids makes the most sense in editing photos.
Miki Proxima (meshlogic)

HanVroon
Posts: 206
Joined: Thu Jan 28, 2010 7:30 am

Re: 0.86: Can't undo changes made in Crop board

Post by HanVroon » Sun Dec 17, 2017 8:21 am

I lately also discovered the lack of Undo after having used the Crop toolbar (still there in version .88)
Luckily I found this topic, avoiding reporting this bug twice.

And also, it would be nice if after pressing Undo, the previous crop selection would still be visible so that you can adjust it a little and crop again.
I had a note for that wish a long time already. This functionality was available in the Classic version too.
More a suggestion than a bug, but as you will be looking in the same part of the code, maybe handy to look at it at the same time... :D

User avatar
xnview
Author of XnView
Posts: 29886
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: 0.86: Can't undo changes made in Crop board

Post by xnview » Wed Jan 24, 2018 2:04 pm

See issue for current status and some details. I'll post here once the problem has been fixed.
Pierre.

User avatar
xnview
Author of XnView
Posts: 29886
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: 0.86: Can't undo changes made in Crop board

Post by xnview » Mon Feb 12, 2018 10:13 am

This problem is supposed to be fixed in XnView MP 0.90. Please check and confirm the bug fix here.
Pierre.

User avatar
miki
Posts: 17
Joined: Wed Oct 04, 2017 2:40 pm
Contact:

Re: 0.86: Can't undo changes made in Crop board

Post by miki » Tue Feb 20, 2018 11:54 am

I have tried 0.90 beta 1 and the Undo for Crop works, but you need to specify the crop area again and cannot just fine tune it.

I really think it would be more convenient, if the crop selection remain visible after Undo as @HanVroon and me mentioned earlier.
Miki Proxima (meshlogic)

User avatar
xnview
Author of XnView
Posts: 29886
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: 0.86: Can't undo changes made in Crop board

Post by xnview » Wed Feb 21, 2018 6:21 am

miki wrote:I have tried 0.90 beta 1 and the Undo for Crop works, but you need to specify the crop area again and cannot just fine tune it.

I really think it would be more convenient, if the crop selection remain visible after Undo as @HanVroon and me mentioned earlier.
ok, original bug is fixed, and i've created a new topic to restore selection
Pierre.

Post Reply