0.87: File modification date not set after edit

Bugs which have been reproduced by a second user or the developer

Moderator: Dreamer

dietmar
Posts: 62
Joined: Fri Oct 25, 2013 4:55 pm

0.87: File modification date not set after edit

Postby dietmar » Sun Oct 22, 2017 12:09 pm

tested with 0.87 x64 (Ubuntu):

Open any image, use Image->Filter for any arbitrary change, go to next file.
The "Save changed file" dialog appears, click Save.
The "Do you want to overwrite" dialog appears, confirm with OK.
Modified image is saved as it should.

Now check the file dates:

- in XnView: Creation Date and Accessed Date as updated; Modified Date is not (Bug 1). Modified Date should be updated, creation date maybe?

- in Ubuntu File Properties: Image->Modified Date is updated; File->Changed Date is not (Bug 2). File has been changed definitely.

How comes?

Regards
Dietmar

User avatar
xnview
Author of XnView
Posts: 28391
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: 0.87: File modification date not set after edit

Postby xnview » Sun Oct 29, 2017 2:29 pm

what do you have in Settings>General>File operations - Keep original date/time?
Pierre.

dietmar
Posts: 62
Joined: Fri Oct 25, 2013 4:55 pm

Re: 0.87: File modification date not set after edit

Postby dietmar » Thu Nov 02, 2017 5:48 pm

xnview wrote:what do you have in Settings>General>File operations - Keep original date/time?


Hi Pierre,
sorry for the delay in responding, I was out of town.

All three options in "Keep original date/time" are set (which must be the default).

However, applying a filter is neither a metadata change, nor a lossless transformation or an (unmodified) file save.

I understand that there are operations such as setting the copyright which one might not want the EXIF file dates (image metadata) to change. (whereas I would prefer the default to be "do not keep original date/file")

Applying a filter, however, just like cropping or rotating is ALWAYS a change you want to see in both image and file system metadata. Keeping the date under these circumstances is a bug.

In addition, in my opinion ANY change (even those from Settings) should set the file system change date as many backup procedures rely on the file system date. There shouldn't be any option to keep a modified file from being backed up.

Regards
Dietmar

User avatar
xnview
Author of XnView
Posts: 28391
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: 0.87: File modification date not set after edit

Postby xnview » Mon Nov 06, 2017 9:48 am

dietmar wrote:In addition, in my opinion ANY change (even those from Settings) should set the file system change date as many backup procedures rely on the file system date. There shouldn't be any option to keep a modified file from being backed up.

It was like that in XnView Classic, a default for many users
Pierre.

dietmar
Posts: 62
Joined: Fri Oct 25, 2013 4:55 pm

Re: 0.87: File modification date not set after edit

Postby dietmar » Sun Nov 12, 2017 9:39 am

xnview wrote:It was like that in XnView Classic, a default for many users

Maybe. Doesn't look right to me.

Anyway, what about the other issue in my post:
dietmar wrote:Applying a filter, however, just like cropping or rotating is ALWAYS a change you want to see in both image and file system metadata. Keeping the date under these circumstances is a bug.


Regards
Dietmar

User avatar
xnview
Author of XnView
Posts: 28391
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: 0.87: File modification date not set after edit

Postby xnview » Sun Nov 12, 2017 11:57 am

dietmar wrote:Anyway, what about the other issue in my post:
dietmar wrote:Applying a filter, however, just like cropping or rotating is ALWAYS a change you want to see in both image and file system metadata. Keeping the date under these circumstances is a bug.


Crop or Rotate with save?
Pierre.

dietmar
Posts: 62
Joined: Fri Oct 25, 2013 4:55 pm

Re: 0.88: File modification date not set after edit

Postby dietmar » Mon Nov 13, 2017 11:54 am

xnview wrote:Crop or Rotate with save?


Pierre,

I updated to 0.88 and did some tests with an arbitrary JPG photo on Ubuntu 64bit:
from the browser tab:
  • change IPTC data,
  • lossless rotate
from an image tab:
  • rotate 90° and save,
  • rotate 45° and save,
  • crop and save,
  • filter emboss and save

These are my findings (three bugs ;-)):
  • When in options all three settings for "keep original date" are set, the file modification date (in Properties) is NEVER updated. When all three settings are off, the file modification date is ALWAYS updated.
    Expected behaviour (at least by me): at least filter, crop and rotate 45° should update the file modification date independently of the "keep original date" setting.
  • With both settings, the EXIF "Date modified" is NEVER updated.
    Expected behaviour: The EXIF modification date should change when an image is modified and saved. At least with filter, crop and non-orthogonal rotates, but in my opinion also with lossless rotates and IPTC changes.
  • With both settings, the file CREATION date (in Properties) ALWAYS updates to the current date and time.
    Expected behaviour: The file creation date should never update unless a NEW file is created. Any edit should be reflected in the file modification date, not the creation date.

Regards
Dietmar

User avatar
xnview
Author of XnView
Posts: 28391
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: 0.88: File modification date not set after edit

Postby xnview » Wed Nov 15, 2017 2:46 pm

dietmar wrote:[*]With both settings, the EXIF "Date modified" is NEVER updated.
Expected behaviour: The EXIF modification date should change when an image is modified and saved. At least with filter, crop and non-orthogonal rotates, but in my opinion also with lossless rotates and IPTC changes.
[*]With both settings, the file CREATION date (in Properties) ALWAYS updates to the current date and time.
Expected behaviour: The file creation date should never update unless a NEW file is created. Any edit should be reflected in the file modification date, not the creation date.[/list]

So i need to add 2 new settings:
- update EXIF modified date
- don't touch creation date
Pierre.

dietmar
Posts: 62
Joined: Fri Oct 25, 2013 4:55 pm

Re: 0.88: File modification date not set after edit

Postby dietmar » Wed Nov 15, 2017 3:13 pm

xnview wrote:So i need to add 2 new settings:
...
- don't touch creation date

Pierre, I don't see any need for such a setting. You should NEVER touch the creation date unless you create a new file.
xnview wrote:So i need to add 2 new settings:
- update EXIF modified date
...

In my opinion the EXIF modification date should go along the file modification date:
  • setting for metadata change (use the one you have)
  • setting for lossless transformations (use the one you have)
  • setting for non-modifying file saves, i.e. format conversion (use the one you have)
  • new setting for modifying file saves, i.e. size change, crop, rotate, filter, paint (default must be 'change date' - and I see no reason to alter this)

User avatar
xnview
Author of XnView
Posts: 28391
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: 0.88: File modification date not set after edit

Postby xnview » Thu Nov 16, 2017 7:13 am

dietmar wrote:
xnview wrote:So i need to add 2 new settings:
...
- don't touch creation date

Pierre, I don't see any need for such a setting. You should NEVER touch the creation date unless you create a new file.

It's not the case for all users....
Pierre.

dietmar
Posts: 62
Joined: Fri Oct 25, 2013 4:55 pm

Re: 0.88: File modification date not set after edit

Postby dietmar » Thu Nov 16, 2017 8:58 am

xnview wrote:It's not the case for all users....

Maybe.
To me the file creation date is a fixed date which no-one (OS or application) should ever change.
If you offer a setting to change the file creation date, keep in mind that this might/should also affect the EXIF creation date.

Thanks for your excellent work!

Dietmar


Return to “Reproduced”

Who is online

Users browsing this forum: No registered users and 1 guest