MP 1.7.2: Search dialog is keyboard unfriendly

Reported bugs that have been closed and/or resolved

Moderators: helmut, XnTriq, xnview, Dreamer

Post Reply
User avatar
tikmok
Posts: 8
Joined: Fri Dec 10, 2021 10:03 pm

MP 1.7.2: Search dialog is keyboard unfriendly

Post by tikmok »

OS: Windows 11 Pro, 64 bit

Short Description:
The search dialog is keyboard unfriendly.
1) Tabbing doesn't change focus to the next control in visual order
2) Some controls don't get focussed at all
3) No keyboard shortcuts

Effect:
Can't use the keyboard to navigate and control the dialog box.

To reproduce:
1. From the browser, CTRL-F
2. Tab, Tab, Tab...

Actual behaviour (bug):
1) When tabbing, the focus change to the next control doesn't happen in order.
2) "Folder" dropdown doesn't get focussed at all
3) Typically, the keyboard-friendly dialog would also allow selecting / clicking by using shortcut keys

Expected behaviour:
1) When tabbing, the focus change to the next control happens in order
2) "Folder" dropdown gets focussed, can be typed in, can select the dropdown. The last directory that was search should be the default.
3) The fields/controls/buttons have keyboard shortcuts wherever applicable.
4) The search result "listbox" shouldn't receive focus.[/list]
User avatar
xnview
Author of XnView
Posts: 46235
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: MP 1.7.2: Search dialog is keyboard unfriendly

Post by xnview »

tikmok wrote: Tue Jul 02, 2024 6:34 am 3) No keyboard shortcuts
which ones will be good?
Pierre.
User avatar
user0
XnThusiast
Posts: 2414
Joined: Sat May 09, 2015 9:37 am

Re: MP 1.7.2: Search dialog is keyboard unfriendly

Post by user0 »

+1 to all points

speaking about search results
tikmok wrote: Tue Jul 02, 2024 6:34 am 4) The search result "listbox" shouldn't receive focus.
user0 wrote: Wed Aug 23, 2023 11:44 am no button has focus, that is not convinient.
its better set focus to 'Browse...' button
so its possible to:
1. press Enter/Return 1st time to run search
2. press Enter/Return 2nd time to open results in Browser
Since there is almost no point in listing them on a second tab.
However, I would go a step further and merge the tabs to make them look like a search dialog in Excel.
User avatar
xnview
Author of XnView
Posts: 46235
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: MP 1.7.2: Search dialog is keyboard unfriendly

Post by xnview »

:bugconfirmed: Thanks to your detailed description I can reproduce the problem.
Pierre.
User avatar
tikmok
Posts: 8
Joined: Fri Dec 10, 2021 10:03 pm

Re: MP 1.7.2: Search dialog is keyboard unfriendly

Post by tikmok »

xnview wrote: Tue Jul 02, 2024 3:01 pm which ones will be good?
I am uncertain about the question and I am outdated, so please don't be offended about this answer.

In the olden days, they'd put shortcuts in most of them, i.e.
* Filename, alt-f, would focus on the edit field next to file name
* Folder, alt-o, would focus on the edit field next to folder
* Case sensitive, alt-c, would click the checkbox
* i, u, s, e, d, l, a, n, r, p, c, etc.

The dialog box designer (or the dialog building code) would allow putting "&" in front of the letter, and the appropriate actions (focus, click) taken place automatically, but I don't know anything about the framework XNView MP uses.
User avatar
xnview
Author of XnView
Posts: 46235
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: MP 1.7.2: Search dialog is keyboard unfriendly

Post by xnview »

This problem is supposed to be fixed in XnView MP 1.8.0. Please check and confirm the bug fix here.
Pierre.
User avatar
tikmok
Posts: 8
Joined: Fri Dec 10, 2021 10:03 pm

Re: MP 1.7.2: Search dialog is keyboard unfriendly

Post by tikmok »

OK. Fixed the keyboard tab, without adding the shortcut keys. It's definitely an improvement, though.

Thamks, Pierre.
Post Reply