XnView Software

I want to highlight 5 functions with inconsistent definitions:

• gflGetExtraInfos(): parameter "int idx"
• gflJPEGGetComment(): parameter "int maxsize"
• gflJPEGGetCommentW(): parameter "int maxsize"
• gflPNGGetComment(): parameter "int maxsize"
• gflPNGGetCommentW(): parameter "int maxsize"

Those parameters are all defined as int - wouldn't it be better and more bulletproof to define those as GFL_INT32?


Furthermore these 2 defintions also have a rather unknown parameter:

• typedef void* (GFLAPI *GFL_ALLOC_CALLBACK)( size_t size, void* user_parms );
• typedef void* (GFLAPI *GFL_REALLOC_CALLBACK)( void* ptr, size_t new_size, void* user_parms );

Both have a parameter from type size_t - here I also suggest to change it into a well-known definition, like GFL_UINT32.

Yes GFL_INT32 is better!