XnView Software

XnViewMP 1.4.5-1.5.0 64bit
Windows11 (22H2), display resolution 3840x2160, win scaling 150%

General
pressing Esc / clicking X neither closes <empty> tab, nor quits the app

To reproduce:
1. goto Settings
- uncheck "Closing last tab exits XnView" checkbox
- set "Pressing Esc once quits XnViewMP" to Always
- press OK
2. open any image

Issue A
3. press Enter to open Browser mode
4. press Esc or press CTRL+W multiple times
<empty> tab remains open, app does not quit

Issue B
3. click tab's X button or press CTRL+W
image closes, tab becomes <empty>
4. click tab's X button or press CTRL+W
<empty> tab remains open, app does not quit

Issue C
1. goto Settings
- set "Pressing Esc once quits XnViewMP" to Only in fullscreen
- press OK, close app
2. open any image (eg via double click)
3. press F11 to switch to Fullscreen mode
4. press Esc
app switches from Viewer Fullscreen to Viewer Normal mode instead of quit


Suggestion A
"Pressing Esc once quits XnViewMP" is not correct naming for current functionality.

• it shall be either changed to checkbox "Close Browser tab via Esc button"
  because existing combobox only affects this aspect
  
  OR

• if you really want worded behavior, combobox shall work as following:
  - Never - never close app via Esc, only close tabs (Browser/Viewer)
  - Always - close app whenever Esc is pressed (in absence of any extra dialogs/panels), no matter how many tabs are open (same as ALT+F4, CTRL+Q)
  - Only in fullscreen - same as "Always" but in Fullscreen only

Suggestion B
However, I think its better to rework it into 2 checkboxes:
- "Pressing Esc closes Browser tab"
- "Pressing Esc closes Viewer tab"
Pressing Esc in Fullscreen mode shall always switch to previous mode (Browser/Viewer).
App quit will be controlled by "Closing last tab exits XnView" checkbox.

How to fast quit app with multiple tabs (of the same mode or mixed)?
via shortcut:

• default
  ALT+F4, CTRL+Q

• custom
  it will require to update Shortcuts in Settings:
  - add new actions "Quit" and maybe "Quit without saving" (maybe via adding new "General" group), so user can assign any button to quit action (eg Esc)
  however, it will not be possible to exit Fullscreen move via ESC than..

ps. also pressing Esc once shall close Viewer tab with .gif image, not just stop it

user0 wrote: Fri Jul 07, 2023 3:34 pm Suggestion A
"Pressing Esc once quits XnViewMP" is not correct naming for current functionality.
If you really want this behavior, it shall work as following:
- Never - never close app via Esc, only close tabs (Browser/Viewer)
- Always - close app whenever Esc is pressed (in absence of any extra dialogs/panels), no matter how many tabs are open (same as ALT+F4, CTRL+Q)
- Only in fullscreen - same as "Always" but in Fullscreen only

yes, but some thoughts about other users... It will break the current behavior of ESC key...

I have updated Suggestions with few details.

what exact cases are you worry about?

ps. inconsistent behavior shall be fixed, one way or another as it affiects general perception of the application

user0 wrote: Fri Jul 07, 2023 3:34 pm However, I think its better to rework it into 2 checkboxes:
- "Pressing Esc closes Browser tab"
- "Pressing Esc closes Viewer tab"
Pressing Esc in Fullscreen mode shall always switch to previous mode (Browser/Viewer).
App quit will be controlled by "Closing last tab exits XnView" checkbox.

Yes better, i've seen that i have a hidden setting escKeyClosesTab, so will be removed.

what exact cases are you worry about?

When starting XnView with a file in fullscreen, some users want to quit directly. Not sure that they want to change "Closing last tab exits XnView" or if they have 1 image tab & browser would like to quit...

See issue for current status and some details.

This problem is supposed to be fixed in XnView MP 1.5.4. Please check and confirm the bug fix here.

fixed in 1.5.4