Favourites: Context menu

Bugs found in XnView Classic. Please report only one bug per topic!

Moderators: helmut, XnTriq, xnview

User avatar
helmut
Posts: 8704
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Favourites: Context menu

Post by helmut »

The entries in the list of changes of 1.90 alpha are sorted, I start with the top entry which says "* New panel in browser (tab for favorites, and tabs for info/Metadata)".

The new Favourites panel (View > Explorer pane > Favourites) is good. Though it makes me a bit wonder why we have the small symbol "Favourites" and its functionality in the small toolbar plus the Explorer pane. One or the other seems redundant to me. In alpha1 the "Edit Favourites.." dialog does not allow for creating subfolders or adding entries, so the new explorer pane offers more functionality. The favourite handling should be unified or the old dialog should be removed, I think. Having two spots for the same thing does not make sense to me.

When right clicking on an entry, the context menu appears. Currently, the entries are:

Code: Select all

Delete
Rename
----------------------
New subfolder
----------------------
Edit entry...
Add entry...
Sort entries
I think that the context menu of the Favourites pane should be similar or close to the handling in the folder pane. The difference to the folder pane is that we can create two types of items: Folders and Favorites.

The first thing that I would like to swap is the symbol of the favourites and the symbol of the folder. In alpha1 the folder is a star, whereas the favourites have the folder symbol, it should be the other way round.

What about the following order and naming of the menu items:

Code: Select all

New favourite...
Edit favourite...
----------------------
New folder...
----------------------
Rename
Delete
----------------------
Sort
V 1.90 A1
Dreamer
XnThusiast
Posts: 4608
Joined: Sun Jul 25, 2004 9:08 pm

Re: Favourites: Context menu

Post by Dreamer »

helmut wrote:The new Favourites panel (View > Explorer pane > Favourites) is good. Though it makes me a bit wonder why we have the small symbol "Favourites" and its functionality in the small toolbar plus the Explorer pane. One or the other seems redundant to me.
I disagree, folder tree can be disabled, also "use tab" can be disabled, then it's not redundant. ;)
helmut wrote:The first thing that I would like to swap is the symbol of the favourites and the symbol of the folder. In alpha1 the folder is a star, whereas the favourites have the folder symbol, it should be the other way round.
I agree.
Dreamer
User avatar
xnview
Author of XnView
Posts: 46236
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: Favourites: Context menu

Post by xnview »

helmut wrote: The first thing that I would like to swap is the symbol of the favourites and the symbol of the folder. In alpha1 the folder is a star, whereas the favourites have the folder symbol, it should be the other way round.
Which symbol??
Pierre.
User avatar
helmut
Posts: 8704
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Re: Favourites: Context menu

Post by helmut »

xnview wrote:
helmut wrote: The first thing that I would like to swap is the symbol of the favourites and the symbol of the folder. In alpha1 the folder is a star, whereas the favourites have the folder symbol, it should be the other way round.
Which symbol??
The symbol for favourites and the symbol for folder. Folders look like favourites and favourites look like folders:
Image
Last edited by helmut on Tue Dec 05, 2006 7:47 am, edited 1 time in total.
User avatar
xnview
Author of XnView
Posts: 46236
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: Favourites: Context menu

Post by xnview »

helmut wrote:
xnview wrote:
helmut wrote: The first thing that I would like to swap is the symbol of the favourites and the symbol of the folder. In alpha1 the folder is a star, whereas the favourites have the folder symbol, it should be the other way round.
Which symbol??
The symbol for favourites and the symbol for folder. Folders look like favourites and favourites look like folders:
Image
The symbol used for folder comes from explorer, i use only the star for sub folder. Which symbol will be better than star for sub folder???
Pierre.
User avatar
Olivier_G
XnThusiast
Posts: 1423
Joined: Thu Dec 23, 2004 7:17 pm
Location: Paris, France
Contact:

Re: Favourites: Context menu

Post by Olivier_G »

xnview wrote:The symbol used for folder comes from explorer, i use only the star for sub folder. Which symbol will be better than star for sub folder???
You can't invert them? (use 'star' for favorites / 'folders' for the structure)
Olivier
User avatar
xnview
Author of XnView
Posts: 46236
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: Favourites: Context menu

Post by xnview »

Olivier_G wrote:
xnview wrote:The symbol used for folder comes from explorer, i use only the star for sub folder. Which symbol will be better than star for sub folder???
You can't invert them? (use 'star' for favorites / 'folders' for the structure)
No, for folder i extract from explorer the icon. So the only icon that i can change is the star for subfolder...
Pierre.
User avatar
Clo
XnThusiast
Posts: 4441
Joined: Sun Oct 17, 2004 4:57 am
Location: Bordeaux, France
Contact:

The Star sucks !

Post by Clo »

:) Hello Pierre !

• Please, could we have the "Favourite" icon from the current skin instead the "Star" ?
- Maybe as an INI option ? TIA !

:mrgreen: KR
Claude
Clo
Old user ON SELECTIVE STRIKE till further notice
User avatar
xnview
Author of XnView
Posts: 46236
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: The Star sucks !

Post by xnview »

Clo wrote: • Please, could we have the "Favourite" icon from the current skin instead the "Star" ?
- Maybe as an INI option ? TIA !
I've checked my code, and i can't change that. I use standard explorer icon list...
Pierre.
User avatar
helmut
Posts: 8704
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Post by helmut »

Pierre, as you can see above, the symbols are simply the other way round, favourites should be a star and folder should be "folders". The way it is now is very misleading and confusing.

Is there really no way to change the icons used in the favourites tree?

Note:
I just had a look at MS Internet Explorer. There, folder are folders and bookmarks are shown as HTML documents with the blue "e" of the internet explorer.
User avatar
Clo
XnThusiast
Posts: 4441
Joined: Sun Oct 17, 2004 4:57 am
Location: Bordeaux, France
Contact:

From a DLL¦ICL

Post by Clo »

—> Helmut

• Thank you to have checked this.

- IMHO, a trick¦workaround could be found…
- For instance, we had Win folders icons in the list of Total Commander (V 6.5x…),
and some system folders were always shown as 16*16, others rescaled and damaged, this was ugly [Left] :

——— Image —— Now from TC resources : —— Image

- It could be got from some icon¦bitmap DLL as well…
This exists too in TC, where we can choose an alternative external resource for this kind of images…

:mrgreen: G
Claude
Clo
Old user ON SELECTIVE STRIKE till further notice
marsh
XnThusiast
Posts: 2443
Joined: Sun May 15, 2005 6:31 am

Which explorer?

Post by marsh »

xnview wrote:
Clo wrote: • Please, could we have the "Favourite" icon from the current skin instead the "Star" ?
- Maybe as an INI option ? TIA !
I've checked my code, and i can't change that. I use standard explorer icon list...
"Star icon" does not appear on win2k (ie5). If some are old favourites and others are new folders, how does one tell them apart?

Code: Select all

"C:\in\test"*"C:\in\test"
<New Folder8>
</New Folder8>
I always use the path as favourite name. So you can see how this can be confusing.
User avatar
xnview
Author of XnView
Posts: 46236
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: Which explorer?

Post by xnview »

marsh wrote:
xnview wrote:
Clo wrote: • Please, could we have the "Favourite" icon from the current skin instead the "Star" ?
- Maybe as an INI option ? TIA !
I've checked my code, and i can't change that. I use standard explorer icon list...
"Star icon" does not appear on win2k (ie5). If some are old favourites and others are new folders, how does one tell them apart?
Strange, on my W2K, i have star. I must choose the icon for a existing file for folder in favorites, so which?
Currently i use the favorites folder from Document and settings!
Pierre.
marsh
XnThusiast
Posts: 2443
Joined: Sun May 15, 2005 6:31 am

Re: Which explorer?

Post by marsh »

xnview wrote:
marsh wrote:
xnview wrote: I've checked my code, and i can't change that. I use standard explorer icon list...
"Star icon" does not appear on win2k (ie5). If some are old favourites and others are new folders, how does one tell them apart?
Strange, on my W2K, i have star. I must choose the icon for a existing file for folder in favorites, so which?
Currently i use the favorites folder from Document and settings!
I think I have found a windows buggy patch which causes star to wrongly appear on folder instead of favourtites, stay tuned! I have been reinstalling OS suspecting something wrong. Fully patched doesn't look like base installation.
marsh
XnThusiast
Posts: 2443
Joined: Sun May 15, 2005 6:31 am

Post by marsh »

The "Star" behaviour in alpha3 changed when I uninstalled and reinstalled ms06-051_windows2000-kb917422-x86-enu.exe! (this seemed to fix star placement problem).
Base install (unpatched)= stars used on some favourties (but not all).
Fully patched= Stars are on folders (as Helmut reported, but I could never see it before- I don't know why).
Post Reply