RC3: Unnecessary icon in menubar

Ideas for improvements and requests for new features in XnView Classic

Moderators: XnTriq, helmut, xnview

User avatar
Lesmo16
Posts: 419
Joined: Thu May 12, 2005 8:59 pm
Location: Germany

Post by Lesmo16 »

Dreamer wrote:Image

Anoyne use (need) that icon (in menu bar) at all?
Hm, until now I didn't use it - but I'm using xnView since RC1.

But I think you all know for what to use these icons - right?

It's for something like that:

Image
Everyone who believes in telekinesis, raise my hand!
User avatar
helmut
Posts: 8705
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Post by helmut »

Lesmo16 wrote:But I think you all know for what to use these icons - right?

It's for something like that:

Image
Right, thanks for bringing that one in. XnView always was and still is an MDI application (Multiple Document Interface). The icon in the top left corner is simply the system menu for the child window. Since most people use XnView with maximized child windows, there's little use for these icons. But for those people that do use MDI (with non-maximized windows), it can be helpful.

On the left you have the two system menus (Parent window & child window) which we are currently discussing about, one the right side you have the same "problem" with Minimized, Maximized and Close.

This could be changed only if XnView left the MDI concept completely behind, but this is a really big and long discussion. Not in 1.80, please.

So currently I'd say: It's a feature, not a bug. ;-)
User avatar
EgoSun
Posts: 59
Joined: Sat May 21, 2005 4:26 pm
Location: Ukraine

Post by EgoSun »

I don't think that somebody use MDI with unmaximized windows in xnview, I would say that this is very uncomfortable for viewing images, since we are not edit them like in Photoshop where you can't imagine work without unmaximized windows.
User avatar
xnview
Author of XnView
Posts: 43613
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Post by xnview »

Dreamer wrote:Image

Anoyne use (need) that icon (in menu bar) at all?
I can't remove these icons, windows add them because it's MDI childs.
Pierre.
User avatar
EgoSun
Posts: 59
Joined: Sat May 21, 2005 4:26 pm
Location: Ukraine

Post by EgoSun »

That's because of MDI implementation you use in xnview code, maybe there are some other librarys for making MDI tabs in C++.

BTW, I've already found some new solutions. Check this:
http://www.codeproject.com/tabctrl/mditabs.asp
http://www.codeproject.com/docview/tabbedmdi.asp
http://www.wndtabs.com/
User avatar
xnview
Author of XnView
Posts: 43613
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Post by xnview »

EgoSun wrote:That's because of MDI implementation you use in xnview code, maybe there are some other librarys for making MDI tabs in C++.

BTW, I've already found some new solutions. Check this:
http://www.codeproject.com/tabctrl/mditabs.asp
http://www.codeproject.com/docview/tabbedmdi.asp
http://www.wndtabs.com/
Sorry i don't understand, when you have MDI child (browser, view, ...), you have these icons. Even on examples found...
Pierre.
User avatar
EgoSun
Posts: 59
Joined: Sat May 21, 2005 4:26 pm
Location: Ukraine

Post by EgoSun »

Wow, I didn't notice that, he he.

Can you say me, which way do you implement MDI in xnview (MFC, FCL).
scratch
Posts: 82
Joined: Sun May 22, 2005 11:23 pm
Location: USA

Post by scratch »

i'd like to see XnView at least optionally not MDI. but you're right, this is for the next version, not for 1.80.
User avatar
xnview
Author of XnView
Posts: 43613
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Post by xnview »

EgoSun wrote:Wow, I didn't notice that, he he.

Can you say me, which way do you implement MDI in xnview (MFC, FCL).
win32
Pierre.
ckit
XnThusiast
Posts: 2564
Joined: Tue Feb 17, 2004 1:11 am
Location: Cabarlah, Australia

Post by ckit »

You could re-write XnView in WTL....

WTL or Windows Template Library is a "new" set of lightweight templates/classes which wrap most of the user interface aspects of modern windows programming. It was developed within mikros~1 as an extension of ATL, and although not "officially" supported it kicks plain ass. If only there was some docking toolbar functionality it would become the defacto tool for all UI programming aspects. But we're working on that...

This was taken from the "editor2.txt" in xplorer2 lite.
Despite what it says above xplorer2 lite does have dockable toolbars.
AMD Ryzen 3 3300X 3.8Ghz, 16Gb DDR4, RX6600XT with Dell U2520D at 2560x1440@60Hz
Windows 11 Pro x64 23H2, PowerToys and Wintoys
User avatar
EgoSun
Posts: 59
Joined: Sat May 21, 2005 4:26 pm
Location: Ukraine

Post by EgoSun »

:arrow: xnview

can you post here a header file (*.h) which you use to create MDI
User avatar
xnview
Author of XnView
Posts: 43613
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Post by xnview »

EgoSun wrote::arrow: xnview
can you post here a header file (*.h) which you use to create MDI
A .h????
Here is the code:

Code: Select all

MDICREATESTRUCT mcs;
...
hWnd = (HWND )SendMessage( hWndClient, WM_MDICREATE, 0, (LPARAM )&mcs );  
Why?
Pierre.
User avatar
EgoSun
Posts: 59
Joined: Sat May 21, 2005 4:26 pm
Location: Ukraine

Post by EgoSun »

xnview
can you post here all #include <blablabla> lines
User avatar
xnview
Author of XnView
Posts: 43613
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Post by xnview »

EgoSun wrote:xnview
can you post here all #include <blablabla> lines
I don't understand why do you want headers??? I use #include <windows.h> only
Pierre.
User avatar
EgoSun
Posts: 59
Joined: Sat May 21, 2005 4:26 pm
Location: Ukraine

Post by EgoSun »

:arrow: xnview

I want to modify this header file, so that there is no icon in menu bar :wink:

Edit: Now I understand, it does not depend on a header file, it depends on comdlg32.dll :)