0.84: „Show files in subfolder” resets when it shouldn't

Bugs which have been reproduced by a second user or the developer

Moderator: Dreamer

Post Reply
User avatar
m.Th.
XnThusiast
Posts: 1491
Joined: Wed Aug 16, 2006 6:31 am
Contact:

0.84: „Show files in subfolder” resets when it shouldn't

Post by m.Th. » Thu Mar 09, 2017 6:08 am

The „Show files in subfolder” button...
Show Files in Subfolder.jpg
Show Files in Subfolder.jpg (6.45 KiB) Viewed 433 times
...exhibits a weird behavior, like a reset, after a move operation.

Please note that this scenario can be/is very often for some: what happens when someone shots on a single memory card several events.

0. Put the memory card in card reader. For me, it will show up as F:\
1. (Using Favorites) Navigate with XnView MP at F:\ . It will show up several folders: DCIM, MISC etc.
2. Press the Show Files in Subfolder button. Now XnView MP correctly shows all the files from the card.
3. Select only the ones which are from the event you want to import/move to disk.
4. Press Alt-M. (Using Favorites) Select your base folder for photos and append at the end the name of the event: C:\Media\Event 1.
5. Press Enter. XnView MP correctly will move the files at the destination

Expected: We should see the files from point 2. minus files from point 3.

Actual: We see the „landscape” from point 1. - like we didn't press the Show Files in Subfolder button.

Note: In this situation if we press again the button „nothing” happens. If we press it once more then we will see, indeed the expected result.

It seems that the button is still „pressed” (even there is no clue in GUI that this is the case - a visual problem already reported) but the program resets by itself to the „normal” view.

This is an annoying and confusing problem for someone who wants to use in real world this button.
m. Th.

The Ascetic Experience - The best photos and texts from Holy Mountain (Athos)

- Dark Themed XnViewMP 0.90 64bit & XnView 2.00 x64 on Win7 x64 -

User avatar
helmut
Posts: 8145
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Re: 0.84: „Show files in subfolder” resets when it shouldn't

Post by helmut » Thu Mar 09, 2017 10:24 pm

Confirmed.

:arrow: Reproduced

___

@m.Th.: I wonder what the rule for resetting "Show files in subfolder" is supposed to be:
- Reset whenever a different folder is clicked on?
- Reset whenever a different paren folder is clicked on?
- Reset whenever a different drive is clicked on?
- Or ..?

User avatar
m.Th.
XnThusiast
Posts: 1491
Joined: Wed Aug 16, 2006 6:31 am
Contact:

Re: 0.84: „Show files in subfolder” resets when it shouldn't

Post by m.Th. » Fri Mar 10, 2017 5:35 am

@m.Th.: I wonder what the rule for resetting "Show files in subfolder" is supposed to be:
Any folder change from Folders Tree, Favorites Tree, Address Bar (a pasted path from somewhere else) etc. Also, when someone presses the "Back" or "Up" buttons.

Most probably Pierre has a function/method to set the path for the Thumbs pane - something like SetPath(aPath: string) - this function should reset the ShowRecursive flag. This flag should be NOT reset by a transfer operation.

Probably tough, that Pierre calls the method mentioned above after a transfer operation as a blind refresh after a transfer (Move/Copy etc.). Then the flag must be cleared only if the "new" directory is different from the "old" directory.

As an aside, Show Files in Subfolder is a very powerful feature - that's why is by default "on" in Lightroom (in fact the entire GUI is built around this) - but it can be very dangerous (slow, out of memory errors etc.) if the user missteps IOW clicks on a high-level folder with a lot of (unrelated) photos in it.

That's why (IMHO) it needs a decisive action to enable this for each folder separately.
m. Th.

The Ascetic Experience - The best photos and texts from Holy Mountain (Athos)

- Dark Themed XnViewMP 0.90 64bit & XnView 2.00 x64 on Win7 x64 -

User avatar
xnview
Author of XnView
Posts: 30262
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: 0.84: „Show files in subfolder” resets when it shouldn't

Post by xnview » Mon Jun 12, 2017 4:00 pm

you means that if 'show files in subfolder' was activated, the file list must be refreshed with new files in this folder AND subfolders?
Pierre.

User avatar
m.Th.
XnThusiast
Posts: 1491
Joined: Wed Aug 16, 2006 6:31 am
Contact:

Re: 0.84: „Show files in subfolder” resets when it shouldn't

Post by m.Th. » Tue Jun 13, 2017 9:26 am

xnview wrote:you means that if 'show files in subfolder' was activated, the file list must be refreshed with new files in this folder AND subfolders?
Yes. The user „knows” that the setting is „ON”
m. Th.

The Ascetic Experience - The best photos and texts from Holy Mountain (Athos)

- Dark Themed XnViewMP 0.90 64bit & XnView 2.00 x64 on Win7 x64 -

User avatar
xnview
Author of XnView
Posts: 30262
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: 0.84: „Show files in subfolder” resets when it shouldn't

Post by xnview » Tue Jun 13, 2017 1:26 pm

m.Th. wrote:
xnview wrote:you means that if 'show files in subfolder' was activated, the file list must be refreshed with new files in this folder AND subfolders?
Yes. The user „knows” that the setting is „ON”
Ok, but only after a copy/move operation in XnViewMP? I can't monitor all subfolders to see changes
Pierre.

User avatar
m.Th.
XnThusiast
Posts: 1491
Joined: Wed Aug 16, 2006 6:31 am
Contact:

Re: 0.84: „Show files in subfolder” resets when it shouldn't

Post by m.Th. » Mon Jun 26, 2017 4:33 pm

xnview wrote:
m.Th. wrote:
xnview wrote:you means that if 'show files in subfolder' was activated, the file list must be refreshed with new files in this folder AND subfolders?
Yes. The user „knows” that the setting is „ON”
Ok, but only after a copy/move operation in XnViewMP? I can't monitor all subfolders to see changes
Copy/Move/Delete/Rename (sorry for the delay)
m. Th.

The Ascetic Experience - The best photos and texts from Holy Mountain (Athos)

- Dark Themed XnViewMP 0.90 64bit & XnView 2.00 x64 on Win7 x64 -

Post Reply