Various thoughts regarding the short cut for cropping (couldn't finish this post due to lack of time).
___
I'm not 100% up-to-date with the GUI styleguides, but there used to be some rules / guidelines:
- <Alt>+key combinations (Mnemonics) should be used as shortcuts for specific
menu items (and the function behind it).
- <Ctrl>+<key> are for (real) shortcuts which directly trigger a function.
- <Ctrl>+<Shift>+<key> can be used for a modified (stronger) version of the function triggered with <Ctrl>+<key>.
- <Ctrl>+<Alt>+<key> can be used for a modified (different) version of the function triggered with <Ctrl>+<key>.
___
Currently we have:
Ctrl+X for cutting the selected area.
Ctrl+Shift+X for JPGLossless cropping.
I think cutting the selected area and cropping the selected area are pretty different (inverse) functions. So either <Alt> should be used or a different key combination.
When choosing a shortcut we must take some possible risc into account:
The current JPGlossless cropping is very dangerous and when mixing up key combinations users might loose parts of their image data forever, see topic
Auto-Backup for JPGlossless cropping. So key combination for JPGlossless cropping should be disabled or made VERY different to other key combinations. (e.g. users should not loose their image data forever when pressing Ctrl+Alt+x instead of Ctrl+Shift+x.)