Multi-level UnDo: Change number of UnDos

Ask for help and post your question on how to use XnView Classic.

Moderators: helmut, XnTriq, xnview

User avatar
oops66
XnThusiast
Posts: 2005
Joined: Tue Jul 17, 2007 1:17 am
Location: France

Re: Also processing…

Post by oops66 »

xnview wrote:
oops66 wrote:
xnview wrote:Non destructive UNDO is very interesting but need a lot of work.
In next release, i've added more than 1 undo, so i need a hotkey for REDO
(
in most of edit program, we have Ctrl+Y for REDO, but Ctrl+Y is already for CROP.
So must i change hotkey for crop or use another hotkey for REDO
Dreamer?
)
Hello,
Yes, please, keep the standard hotkey for Redo : Crtl + Y
And change Crop hotkey to an other one.
So which for Crop :-)
For me it does'nt matter, why not the: Ctrl+SHift+Z of Troken....if Dreamer hotkeys expert is OK .
http://newsgroup.xnview.com/viewtopic.php?p=55612#55612
Last edited by oops66 on Wed Dec 05, 2007 1:44 pm, edited 1 time in total.
XnViewMP Linux X64 - Debian - X64
Dreamer
XnThusiast
Posts: 4608
Joined: Sun Jul 25, 2004 9:08 pm

Post by Dreamer »

Hi Pierre,

sorry for the late reply. More undo/redo is really needed - it's obvious - see the XnTriq's post. :wink:

I think we should definitely use the standard redo shortcut - Ctrl+Y, so we must find the shortcut for Crop now - and I have one! :D

Shift+X - Why? Ctrl+X is to cut the file, Shift+X will "cut" the image - easy to remember, intuitive and handy.

We should also change the shortcut for "Lossless JPEG crop" and "Automatic crop" IMO...

Ctrl+Shift+X - "Lossless JPEG crop" (Ctrl+Shift+ is used also for other lossless options)
Alt+X ? - "Automatic crop" (I know Alt+ shouldn't be used, but X is not in the main menu, shouldn't be also in other languages)

I know it's not good to change the existing shortcuts, but it's the best solution IMO.
Dreamer
User avatar
Clo
XnThusiast
Posts: 4441
Joined: Sun Oct 17, 2004 4:57 am
Location: Bordeaux, France
Contact:

No X

Post by Clo »

:arrow: Dreamer

:) Hi !
…but X is not in the main menu, shouldn't be also in other languages)
• It's not in French, at least…

:mrgreen: KR
Claude
Clo
Old user ON SELECTIVE STRIKE till further notice
Dreamer
XnThusiast
Posts: 4608
Joined: Sun Jul 25, 2004 9:08 pm

Post by Dreamer »

I think we could use Alt+X for Auto-crop. What do you think about my suggestions - for all crop options? Pierre?
Dreamer
User avatar
xnview
Author of XnView
Posts: 46236
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Post by xnview »

Dreamer wrote:I think we could use Alt+X for Auto-crop. What do you think about my suggestions - for all crop options? Pierre?
I agree
Pierre.
User avatar
helmut
Posts: 8704
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Post by helmut »

Various thoughts regarding the short cut for cropping (couldn't finish this post due to lack of time).
___

I'm not 100% up-to-date with the GUI styleguides, but there used to be some rules / guidelines:

- <Alt>+key combinations (Mnemonics) should be used as shortcuts for specific menu items (and the function behind it).
- <Ctrl>+<key> are for (real) shortcuts which directly trigger a function.
- <Ctrl>+<Shift>+<key> can be used for a modified (stronger) version of the function triggered with <Ctrl>+<key>.
- <Ctrl>+<Alt>+<key> can be used for a modified (different) version of the function triggered with <Ctrl>+<key>.
___

Currently we have:
Ctrl+X for cutting the selected area.
Ctrl+Shift+X for JPGLossless cropping.

I think cutting the selected area and cropping the selected area are pretty different (inverse) functions. So either <Alt> should be used or a different key combination.

When choosing a shortcut we must take some possible risc into account:
The current JPGlossless cropping is very dangerous and when mixing up key combinations users might loose parts of their image data forever, see topic Auto-Backup for JPGlossless cropping. So key combination for JPGlossless cropping should be disabled or made VERY different to other key combinations. (e.g. users should not loose their image data forever when pressing Ctrl+Alt+x instead of Ctrl+Shift+x.)
Dreamer
XnThusiast
Posts: 4608
Joined: Sun Jul 25, 2004 9:08 pm

Post by Dreamer »

Not easy to decide now. I think the standard shortcut for Redo should be used - Ctrl+Y, but I know it would be a problem for some users. I can change any shortcut with the HotkeyP, so it's not a problem for me.

There are few possibilities now:

#1

Redo: Ctrl+Y
Crop: Shif+X
Lossless crop: Ctrl+Shift+X
Auto Crop: Alt+X ?

#2

Redo: Ctrl+Y
Crop: Shif+X
Lossless crop: Ctrl+Shift+X
Auto Crop: Alt+Y, or Ctrl+Alt+Y ?

#3

Redo: Ctrl+Shift+Z
Crop: Ctrl+Y
Lossless crop: Ctrl+Shift+Y
Auto Crop: Alt+Y, or Ctrl+Alt+Y ?
Dreamer
marsh
XnThusiast
Posts: 2443
Joined: Sun May 15, 2005 6:31 am

Post by marsh »

===>Feed-back
Let us all try it out.
User avatar
JohnFredC
XnThusiast
Posts: 2010
Joined: Wed Mar 17, 2004 8:33 pm
Location: Sarasota Florida

Post by JohnFredC »

Does any one really use the auto crop and lossless crop hotkeys?

I don't.
John
marsh
XnThusiast
Posts: 2443
Joined: Sun May 15, 2005 6:31 am

Post by marsh »

JohnFredC wrote:Does any one really use the auto crop and lossless crop hotkeys?

I don't.
I like to use lossless jpeg crop in fullscreen. I can train my hands to whatever is agreeable though. I don't use auto crop either. All of it seems to be working...
User avatar
XnTriq
Moderator & Librarian
Posts: 6512
Joined: Sun Sep 25, 2005 3:00 am
Location: Ref Desk

Post by XnTriq »

When an image is edited, an asterisk (“unsaved/dirty indicator”) appears in the titlebar next to the filename.
  • XnView - [*filename.ext]
Undoing all changes should make this indicator go away, and the “dirty bit” should be reset so XnView won't ask if the user wants “to save changes” upon closing the file.
Last edited by XnTriq on Thu Dec 20, 2007 4:55 am, edited 1 time in total.
User avatar
helmut
Posts: 8704
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Post by helmut »

XnTriq wrote:... When all changes are undone this indicator should disappear, and upon closing the file XnView shouldn't ask if the user wants “to save changes”.
I fully agree. Would be good if XnView would update the "changed" indicator properly.
User avatar
oops66
XnThusiast
Posts: 2005
Joined: Tue Jul 17, 2007 1:17 am
Location: France

Post by oops66 »

helmut wrote:
XnTriq wrote:... When all changes are undone this indicator should disappear, and upon closing the file XnView shouldn't ask if the user wants “to save changes”.
I fully agree. Would be good if XnView would update the "changed" indicator properly.
Hello,
I fully agree too,

But before Pierre has to change this "multi-undo" behavior:
The first image (the original one) must always stay in Tmp memory (as soon as we apply a first or more changes¦effects) even if the number of modifications is over the level in the xnview.ini file: Undocount= setting.
By this way, undo all changes always means : return to the first step (the original image).
http://newsgroup.xnview.com/viewtopic.php?t=13970
XnViewMP Linux X64 - Debian - X64
User avatar
Clo
XnThusiast
Posts: 4441
Joined: Sun Oct 17, 2004 4:57 am
Location: Bordeaux, France
Contact:

Reload---

Post by Clo »

:arrow: oops66

:) Hello !
…By this way, undo all changes always means : return to the first step (the original image). …
• I agree and support. Hence, we'ld need a command like “Undo All”.
- It exists in many programmes where it's named often “Reload (the original file)”.

:mrgreen: KR
Claude
Clo
Old user ON SELECTIVE STRIKE till further notice
User avatar
oops66
XnThusiast
Posts: 2005
Joined: Tue Jul 17, 2007 1:17 am
Location: France

Re: Reload---

Post by oops66 »

Clo wrote::arrow: oops66
:) Hello !
…By this way, undo all changes always means : return to the first step (the original image). …
• I agree and support. Hence, we'ld need a command like “Undo All”.
- It exists in many programmes where it's named often “Reload (the original file)”.
:mrgreen: KR
Claude
Clo
Exact Clo it will be better.
XnViewMP Linux X64 - Debian - X64
Post Reply