Page 2 of 4

Posted: Wed Mar 26, 2008 4:59 pm
by JohnFredC
Troken wrote:Therefore a "Reset" would do the trick.
I agree with Troken. A reversion/reset button is needed.

Plus: I agree it is very important to show the current image size in the dialog.

Plus: a Save and Restore resize settings functionality (not to beat a dead horse) first requested here a long time ago.

Posted: Wed Mar 26, 2008 8:01 pm
by Troken
Something like this, just an idea.

Image

Posted: Thu Mar 27, 2008 1:53 pm
by rfrancis
XP Professional SP2
version 1.93.4

Pierre,
I created a thread saying this was a bug, but you though it was working OK.
I still think it isn't workng, so I am writing it here because it was first suggested here, and if I am wrong, I can be shot down in flames.

After resizing an image, the next time you want to resize something, the dialog is initialized with the same W/H values as was last used.
This happens if the 'Keep Document Size' checkbox is selected OR not selected.
I thought that if it was not selected, the dialogbox should be initialized with the bitmap's true size rather than the last used.
Have I got something wrong here?
If this is not the purpose of the new checkbox, can someone tell me what it does?

I know that you have had your hands full.
Well done fixing the directory changing crash bug so quickly.

Posted: Thu Mar 27, 2008 2:04 pm
by Troken
rfrancis wrote:This happens if the 'Keep Document Size' checkbox is selected OR not selected.
Where is this checkbox? In Options? I'd like to try it out.

Posted: Thu Mar 27, 2008 3:01 pm
by JohnFredC
Hi Troken...

Latest version (1.93.4)!

Posted: Thu Mar 27, 2008 3:03 pm
by Troken
JohnFredC wrote:Hi Troken...

Latest version (1.93.4)!
What, gee, already :) Will check it out ASAP!

Posted: Mon Mar 31, 2008 1:36 pm
by rfrancis
OK Troken and JohnFredC,
Do you think it's working as you expected?
By the way, clicking the 100% in the comboBox is like a reset button.

Posted: Mon Mar 31, 2008 3:30 pm
by Troken
rfrancis wrote:OK Troken and JohnFredC,
Do you think it's working as you expected?
By the way, clicking the 100% in the comboBox is like a reset button.
Hi rfrancis.

The short answer: No. :)
The resetting is alright, though not a reset button.

The "Keep document size" is more of a mystery. Which size is it referring to (The screen size or the print size)? Anyway, the behaviour is strange. I.e. when I reduce the pixelsize, the other values are also reduced. Isn't the idea to keep the size? I would suspect the DPI do be increased and the print size to be static. Then the size (print size) would be kept.

Somewhat it feels buggy.

Posted: Tue Apr 01, 2008 4:58 am
by rfrancis
Hmm, I thought the Keep Document size was to keep the current pixel size even when processing new documents.
At any rate, I find it extremely odd that the default is to 'remember' the previous settings when processing new documents, and the only way to get the size of a new document is to click the 100% in the checkbox.
But at least it's useable now.

Posted: Tue Apr 01, 2008 9:38 am
by Troken
rfrancis wrote:Hmm, I thought the Keep Document size was to keep the current pixel size even when processing new documents.
I agree that it does not work satisfying and I think that it has gotten more confusing now than before. "Keep document size" is not a good phrase, as you said, is it the pixel size? I thought it referred to the print size. The purpose of the box is unclear. I have invesitgated it more now and it appears that the only thing it affects is the DPI:
- Box checked: DPI gets modified as the other values change.
- Box unchecked: DPI is not be modified.
rfrancis wrote:At any rate, I find it extremely odd that the default is to 'remember' the previous settings when processing new documents, and the only way to get the size of a new document is to click the 100% in the checkbox. ...
I understand a need for the feature to remember the last setting, but not as default. I'd rather have a check box saying: "Remember last settings" or something similar.

:arrow: Pierre
I hope you are reading our discussion, the current (1.93.4) resize dialog is imo not intuitive and has gotten hard to interpret.
1. The feature that remembers last input values should not be default. Please revert it to previous versions. My suggestion is (as mentioned above) to add a new check box "Remember last used settings/values".
2. The "Keep document size" is a vague phrase, what does it mean? It also seems buggy, does it work as intended?

Posted: Tue Apr 01, 2008 9:53 am
by xnview
Troken wrote: I hope you are reading our discussion, the current (1.93.4) resize dialog is imo not intuitive and has gotten hard to interpret.
Yes :-)
1. The feature that remembers last input values should not be default. Please revert it to previous versions. My suggestion is (as mentioned above) to add a new check box "Remember last used settings/values".
ok
2. The "Keep document size" is a vague phrase, what does it mean? It also seems buggy, does it work as intended?
So perhaps 'Keep print size' will be better?

Posted: Tue Apr 01, 2008 10:11 am
by Troken
So perhaps 'Keep print size' will be better?
Yes, it is straight and clear. But when the "Keep print size" is checked, I can still change the "Print size" width and height. Can you lock them?

A suggestion is to make the width and height in "Print size" greyed, the are not supposed to be altered anyway. This would be a good, easy to understand indication of what the feature is about, if possible.

More about this:
Bug :bug:
1. Check the "Keep print size".
2. Increase the DPI value.
3. It will not go above 100 DPI.

Strange behaviour:
1. Check the "Keep print size".
2. Increase one of the values in Screen size (either px or %)
3. The h/w in Print size acts strange. They should be static, but they change values up and down (but always close to the original values).

Posted: Tue Apr 01, 2008 12:53 pm
by rfrancis
Pierre,
Now I understand what you were trying to do with 'Keep Document Size'.
I agree with Troken that disabling the height, width and unit editboxes in the 'Print Size' Group Box is a good idea and would let the user know what is happening.

Yes please, change the default action to initialize the dialogbox with the dimensions of the current image being processed.

:bug: Bug 1:
Just to clarify what troken said about his bug.
You can set the DPI to anything you like manually by typing, but the up-down control will not increment past 100.
You need to code something like this...
SendMessage(hWndControl,UDM_SETRANGE,0,MAKELONG(UD_MAXVAL,UD_MINVAL));

:bug: Bug 2:
There is a different problem with all your other edit boxes that are attached to up-down controls (not the Units one).
Just say that an editbox is initialized with the number 300.
You can manually change it to another number by typing, say 100.
But if you try to increment that number with the up-down control, it will increment to 301 rather than 101.
Also decreasing is the same.

:bug: Half a bug 3:
(I feel bad about giving you these bugs when you are already doing so much).
Troken is right.
If 'Keep Document size' is checked, the print size should not change when you change the screen size.
All the scaling should be done with the DPI.
You can see the the problem easily by doing this:...
Check 'Keep Ratio' and 'Keep Document Size'.
Set screen size to "pixels" and print size to "dots".
If you change either the width or height in the 'Screen Size', the 'Print Size' will change by the same amount.
But I think this is impossible to fix if you are changing the aspect ratio (if 'Keep Ratio is unchecked), because by its nature, changing the ratio would have to change the print size.
I can only suggest that you can only check 'Keep Document Size' if 'Keep Ratio' is checked.

One question:
I also use C++.
When describing problems, I use English descriptions from MSDN (like Group Box for example).
Is this a help to you or does it make it more difficult because you work with a French version?

Posted: Tue Apr 01, 2008 1:52 pm
by JohnFredC
There are basically three factors being controlled by the dialog: image size, print size, and the relationship between the two, which is the Units/DPI value. Since Units/DPI is the fulcrum around which the other two values "pivot", the dialog needs a method to keep or "lock" the Units/DPI!

I suggest: a separate "Units" panel in the dialog to contain both the Units spin-control and a "Keep Units/DPI" check box.

Also, I'd put the "Units" panel between the Pixel Size and Print Size panels in order to emphasize how the two sizes are related.

Posted: Tue Apr 01, 2008 2:05 pm
by Troken
EDIT: Post removed.