Page 1 of 1

Changing write protection does not work

Posted: Fri Jan 05, 2007 3:24 pm
by helmut
When setting or unsetting the write protection in the properties dialog, the write protection will not be changed. :bug:

To reproduce:
1. In XnView Browser select a file
2. Open the properties (Edit > Properties)
3. Change the write protections state (check or uncheck).
4. Close the dialog
5. Reopen the properties dialog
-> State of write protection has not been changed :bug:

The problem is in 1.82.4 and 1.90 Beta6.

And the opposite

Posted: Fri Jan 05, 2007 5:44 pm
by Clo
• Hi !

- Confirmed, and also the opposite when one adds any other attribute…

- In fact, the function Change attributes is totally broken in XnView.

:mrgreen: G.
Claude
Clo

Re: And the opposite

Posted: Fri Jan 05, 2007 5:52 pm
by helmut
Clo wrote:- In fact, the function Change attributes is totally broken in XnView.
Yes. Thank you for checking and confirming.

Posted: Sat Jan 06, 2007 12:24 am
by marsh
It works great in Win2k though.

Posted: Sat Jan 06, 2007 7:53 am
by helmut
marsh wrote:It works great in Win2k though.
Strange. Looks like a Windows XP specific bug. I have just checked the priviledges but that's not the problem.

Hmm, there's a button Apply and OK. When pressing "Apply" the dialog closes and does apply the changes. But when pressing "OK", the dialog closes and changes are not applied. :o

So the problem are the buttons OK and Apply. Correct is:
- OK: Apply changes and close dialog. (Currently wrong)
- Apply: Apply changes, do no close dialog. (Currently wrong)
- Cancel: Close dialog, do not apply changes.

marsh, can you confirm my observation on Windows 2000?

Posted: Sat Jan 06, 2007 9:36 am
by xnview
helmut wrote:
marsh wrote:It works great in Win2k though.
Strange. Looks like a Windows XP specific bug. I have just checked the priviledges but that's not the problem.

Hmm, there's a button Apply and OK. When pressing "Apply" the dialog closes and does apply the changes. But when pressing "OK", the dialog closes and changes are not applied. :o

So the problem are the buttons OK and Apply. Correct is:
- OK: Apply changes and close dialog. (Currently wrong)
- Apply: Apply changes, do no close dialog. (Currently wrong)
- Cancel: Close dialog, do not apply changes.

marsh, can you confirm my observation on Windows 2000?
No, only Apply make the changes...

Posted: Sat Jan 06, 2007 12:13 pm
by helmut
xnview wrote:No, only Apply make the changes...
From my point of view this is an unexpected behaviour which should be changed & fixed.

Posted: Sat Jan 06, 2007 12:32 pm
by xnview
helmut wrote:
xnview wrote:No, only Apply make the changes...
From my point of view this is an unexpected behaviour which should be changed & fixed.
For me it's strange, that Ok apply changes!

Posted: Sat Jan 06, 2007 12:41 pm
by helmut
xnview wrote:For me it's strange, that Ok apply changes!
Have you used Windows and XnView? In those pretty common applications "OK" applies changes and closes the dialog. In XnView the following dialogs behave like this for example: Options dialog, Rename, all the effects and Adjust dialogs.

If OK closes without saving, what does Cancel do?

(Sorry for being a bit sarcastic, but I'm a bit baffled by your answer). :o

Posted: Sat Jan 06, 2007 1:10 pm
by xnview
helmut wrote:
xnview wrote:For me it's strange, that Ok apply changes!
Have you used Windows and XnView? In those pretty common applications "OK" applies changes and closes the dialog. In XnView the following dialogs behave like this for example: Options dialog, Rename, all the effects and Adjust dialogs.

If OK closes without saving, what does Cancel do?

(Sorry for being a bit sarcastic, but I'm a bit baffled by your answer). :o
:-) Houps, yes right