XnView Software

In Command Prompt, the total length of the following command line can't contain more than 8191 characters

dexter86 wrote: Tue Aug 15, 2023 12:26 am 1. Turning on "Delete original" makes XnConvert window force focus on itself.
This makes using Windows near impossible. No matter what window you click on, it will immediately loose focus. If you then press Esc on keyboard, it will show you some notification about "aborting transfers" Clipboard04.pngfor maybe one second and then XnConvert will close. My guess is that you are using some Explorer API to remove files, but you are using it in wrong way. And it doesn't matter if I have Recycle Bin enabled or disabled in Windows, or if I set "useRecycleBin=false" in ini, it still behaves the same.

2. Turning on "Delete original" removes original file before converted one is written to disk.
This was a shock to me. I was using Process Monitor to analyze that 1st point and then I saw this

3. Portable version stores ini in AppData\Roaming\XnConvert\xnconvert.ini.
Not very portable, is it?

4. Pressing Esc key closes XnConvert regardless of what it is doing.
It will cancel conversion without any confirmation!

5. There is no information that it doesn't support converting gif to animated webp.
It just converts first frame.

6. Output log should display errors at the end.
I converted 40000 files and had 1 error. Good luck finding it.

7. Add "View as: simple list".
I use "Details" view. When I added 40000 files it took about 1 minute to load them to the table with 1 thread, but after they were loaded it started using 2 threads for about 4 minutes with ram usage slowly rising to 1.5 GB to load thumbs and details. Can you add "simple" list view so it will not load details and thumbnails when adding files?

8. When saving files to disk they are written in "4 KB" chunks.
You can see this in that screenshot above, Write operations write to that file in 4096 bytes chunks. This isn't really a very big issue since most of the time we are limited by cpu speed, but writing files in small chunks is just not a good practice. You should use at least 128 KB.

9. "Export for NConvert" is "badly done".
I tried it just to test if this will get rid of that "delete original" focus problem, but the created bat file was, welll, not properly done.
a) you should be using cmd extension instead of bat (not that it probably really matters, but bat was used in DOS times https://stackoverflow.com/q/148968).

b) When I used "export filenames" it added every filename as parameters to exe. With very large number of files this will result in broken bat file. Nconvert supports filelist from txt file, why don't you use that?

In Command Prompt, the total length of the following command line can't contain more than 8191 characters

c) I changed "Use multiple cores", "Delete original", "Preserve metadata", "Rotate images according to EXIF", and they weren't exported to bat file at all. Probably lots of options don't get exported but I'm not willing to check them.

It's a known issue when using recycle bin, problem with Windows Explorer API, i can't reproduce when useRecycleBin=false (in this case an unlink is made directly)

xnconvert.ini need to be in same folder as XnConvert

you means during processing, need to show a confirmation dialog?

Animated format is not supported, so only first frame is loaded

Perhaps copying all errors at the end of logs?

Saving in which format?

Not all options are supported by NConvert

dexter86 wrote: Wed Aug 23, 2023 8:55 pm JPG and PNG save file in 4KB chunks, but WEBP doesn't, it saves file in few smaller chunks and then one big chunk. I only tested these 3 formats, here are some screenshots from Process Monitor:

This makes using Windows near impossible. No matter what window you click on, it will immediately loose focus

It depends on formats.... Why it's a problem?

I have not this issue on Win10, focus will never change

dexter86 wrote: Sat Oct 14, 2023 10:40 am Ad 1. Not fixed, I told you to make me some debug build. Just add lots of debug logging to that part of your code and let me test it

Ad 3. XnViewMP portable asks where to store ini and other files on first run. XnConvert should do the same.

Ad 4. Not fixed, XnView just crashes, i sent you a crash report

Ad 8. Still not fixed, jpg and png files are read & written in 4KB chunks

Ad 5. Still no information ANYWHERE that it doesn't support converting animated gif to animated webp
Ad 9. You didn't do anything about it, still uses bat extension, still adds every file as parameter to exe instead of txt filelist. Adding veyr large number of images to list the resulting bat file doesn't run, it closes right after you open it. If you try to run it directly form cmd you will get "The system cannot execute the specified program.". Also still doesn't export most selected option, for example "Delete original" is supported by nconvert but you don't export it to bat.

I can't add more debug, i call a win32 api, that's all. But it's strange, because in 1.6.1, i've changed the method to unlink (without changing focus)

I can't reproduce. Do you have actions? do you use multi threading? Which output format?

I can't change the way that format write datas, because some use third party library. And i think that we must keep OS to manage that...

dexter86 wrote: Tue Oct 17, 2023 4:24 pm

I can't add more debug, i call a win32 api, that's all. But it's strange, because in 1.6.1, i've changed the method to unlink (without changing focus)

I tested it with 1.6.0 because it was the latest version at the time I wrote that post. I just tested this with 1.6.1 and it's still the same, see for yourself https://imgur.com/a/9DvK8gr. Can you at least post here that fragment of source code you use for removal? Preferable the whole fragment with if/case.

		SHFILEOPSTRUCT file_op;
		memset(&file_op, 0, sizeof(file_op));
		file_op.hwnd = (HWND)parent->effectiveWinId();
		file_op.pFrom = lpFrom;
		file_op.fFlags = FOF_ALLOWUNDO | FOF_NOCONFIRMATION; // | FOF_SILENT;
		file_op.wFunc = FO_DELETE;
		bool is_ok = SHFileOperation(&file_op) == 0 && file_op.fAnyOperationsAborted == 0;

I can't reproduce. Do you have actions? do you use multi threading? Which output format?

I used the same settings like in that video above. You can use the same settings like in that video and during conversion just switch to any other opened app and hold Esc key. XNConvert doesn't even need to be active, it will still crash.

I can't change the way that format write datas, because some use third party library. And i think that we must keep OS to manage that...

Which library you use for jpg and png?

In 1.6.1, i use QFile::moveToTrash (that uses IFileOperation), and if there is a problem i use this code

Code: Select all

		SHFILEOPSTRUCT file_op;
		memset(&file_op, 0, sizeof(file_op));
		file_op.hwnd = (HWND)parent->effectiveWinId();
		file_op.pFrom = lpFrom;
		file_op.fFlags = FOF_ALLOWUNDO | FOF_NOCONFIRMATION; // | FOF_SILENT;
		file_op.wFunc = FO_DELETE;
		bool is_ok = SHFileOperation(&file_op) == 0 && file_op.fAnyOperationsAborted == 0;

If i remember correctly, i've tried FOF_SILENT flag without change for users with the problem... But i can send you a version to test...

Ok, but in XnView 1.6.1, when you press ESC, you should have a warning dialog?