Page 1 of 1

RC1: Possible small handle leaks

Posted: Thu Jan 12, 2006 12:54 pm
by ckv
I have been systematically tracking handle leaks. And since RC1 is out I think it's right time to give the results. All of these don't necessarily are real leaks.

Heres what I have found:
==> http://newsgroup.xnview.com/viewtopic.php?t=4640
- Options / Toolbar / Skin page leaks GDI handles (when you close options window some GDI handles aren't released)
- JPEG Lossless Transformations window leaks two GDI handles for every run
- About window leaks two GDI handles for every run
- Every browser tab leaks GDI handles for every run (close and restart browser)

Edit: This probably isn't a real leak.
- Every image view tab leaks one handle for every run

Image view tabs don't leak if the browser is not open, but when it is open, one handle leaks every time when you close the tab. So the real leak probably is in browser (Thumbnail is updated after you close the view? And one handle leaks?).

Posted: Sat Jan 14, 2006 8:31 am
by ckit
When you close the About window are the GDI handles released?
If they are, there isn't a bug.

My Test 1:
Load XnView and Process Explorer
-> GDI Handles for XnView are 148

Open About Dialog
-> GDI Handles for XnView are 152

Close About Dialog
-> GDI Handles for XnView are 150

Conclusion = possible small leak.

Posted: Sat Jan 14, 2006 8:40 am
by marsh
ckv wrote: Edit: This probably isn't a real leak.
- About window leaks two GDI handles for every run
I pity the user that clicks this 5000 times in one session. :) :) We'll get them all soon.

Posted: Sat Jan 14, 2006 10:30 am
by ckv
ckit wrote:Conclusion = possible small leak.
Yeah you are right. Oh my fault. Look the first post I fixed it. Sorry. :wink:

Image view tabs don't leak if the browser is not open, but when it is open, one handle leaks every time when you close the tab. So the real leak probably is in browser (Thumbnail is updated after you close the view? And one handle leaks?).

By the way how you overline text in this forum? , [strike] or [overline] don't work.

Posted: Sat Jan 14, 2006 10:42 am
by ckit
It's disabled by default as a security measure:

BBCode Strike
http://www.phpbbhacks.com/viewhack.php?id=444

Re: RC1: Possible small handle leaks

Posted: Mon Jan 16, 2006 10:53 am
by xnview
ckv wrote: - JPEG Lossless Transformations window leaks two GDI handles for every run
- About window leaks two GDI handles for every run
Right
- Every browser tab leaks GDI handles for every run (close and restart browser)

Edit: This probably isn't a real leak.
- Every image view tab leaks one handle for every run

Image view tabs don't leak if the browser is not open, but when it is open, one handle leaks every time when you close the tab. So the real leak probably is in browser (Thumbnail is updated after you close the view? And one handle leaks?).[/size]
Not sure that it's a leak...

Posted: Thu Jan 19, 2006 10:55 pm
by ckit
For now, Closed.