Batch convert - input - normalize use of modifier keys

Bugs that are confirmed but cannot be fixed for some reasons.

Moderators: XnTriq, helmut, xnview, Dreamer

User avatar
user0
XnThusiast
Posts: 1599
Joined: Sat May 09, 2015 9:37 am

Batch convert - input - normalize use of modifier keys

Post by user0 »

XnViewMP 1.4.5 64bit
Windows11 (22H2), display resolution 3840x2160, win scaling 150%


Batch convert
Input allows duplicates, it is either a feature or a bug, I'm not sure
Bug
If bug, then just silently filter out duplicates each time user adds them

Feature
It can be a feature because output filename support # and each file will have it's own index, cannot figure out sane usecase though.
Without # they will be overwritten, with coresponing popup dialog that may confuse user.
batch_convert_input_duplicates.png


Suggestion A
Add checkbox 'allow duplicates' (ticked off by default) somewhere below Add buttons.


Suggestion B
normalize use of modifier keys, COPY should not be default action:
  • current behaviour
    - no mod - copy
    - CTRL - copy
    - SHIFT - copy
    - ALT - copy
  • suggested behaviour
    - no mod - disabled, no action
    - CTRL - copy
    - SHIFT - disabled, no action
    - ALT - disabled, no action


Related
You do not have the required permissions to view the files attached to this post.
Last edited by user0 on Thu Aug 31, 2023 5:22 am, edited 8 times in total.
User avatar
xnview
Author of XnView
Posts: 43723
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Re: 1.4.0 - batch convert - input files allow duplicates

Post by xnview »

It's not a bug but a feature
Pierre.
User avatar
user0
XnThusiast
Posts: 1599
Joined: Sat May 09, 2015 9:37 am

Re: [feat] - batch convert - input files allow duplicates

Post by user0 »

Not sure I can figure out the use case for this feature tbh.
Since you convert all files in batch, you cannot, for example, assign different effects to different images, its always same effects to the same amount of images.

What is the profit of having in the end the same image, but with different names: img_result_1, img_result_2, etc (if you choose not to replace duplicates during convertion)?

But anyway, there are thing related to this functionality that can be improved - normalize use of modifier keys, added into top post as Suggestion B.
User avatar
xnview
Author of XnView
Posts: 43723
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Re: [feat] - batch convert - input files allow duplicates

Post by xnview »

ok, i disable it. See issue for current status and some details.
Pierre.
User avatar
xnview
Author of XnView
Posts: 43723
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Re: Batch convert - input - normalize use of modifier keys

Post by xnview »

This problem is supposed to be fixed in XnView MP 1.5.0 beta. Please check and confirm the bug fix here.
Pierre.
User avatar
user0
XnThusiast
Posts: 1599
Joined: Sat May 09, 2015 9:37 am

Re: Batch convert - input - normalize use of modifier keys

Post by user0 »

1.5.0b1
1. modifier keys disabled in file list area, but you still can drag&drop file(s) from file list (with or without modifiers) to dialog space (controls/tabs/etc) and they will be duplicated
2. its still posible to drag&drop (from win file explorer) or add (via add files/folder) same file(s) multiple times
User avatar
xnview
Author of XnView
Posts: 43723
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Re: Batch convert - input - normalize use of modifier keys

Post by xnview »

user0 wrote: Sat Jun 17, 2023 1:07 pm 1. modifier keys disabled in file list area, but you still can drag&drop file(s) from file list (with or without modifiers) to dialog space (controls/tabs/etc) and they will be duplicated
I can't reproduce
2. its still posible to drag&drop (from win file explorer) or add (via add files/folder) same file(s) multiple times
Yes, it's a behavior...
Pierre.
User avatar
user0
XnThusiast
Posts: 1599
Joined: Sat May 09, 2015 9:37 am

Re: Batch convert - input - normalize use of modifier keys

Post by user0 »

xnview wrote: Mon Jun 19, 2023 6:51 am
user0 wrote: Sat Jun 17, 2023 1:07 pm 1. modifier keys disabled in file list area, but you still can drag&drop file(s) from file list (with or without modifiers) to dialog space (controls/tabs/etc) and they will be duplicated
I can't reproduce
drag&drop image(s) to the yellow area - it will be duplicated in file list area (imho thats a bug)
Image
User avatar
xnview
Author of XnView
Posts: 43723
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Re: Batch convert - input - normalize use of modifier keys

Post by xnview »

Ok, i understand now. I can't detect if the source files come from file list or from windows explorer when dragging on the dialog. The only way is to disable drag&drop in the dialog.
Pierre.
User avatar
user0
XnThusiast
Posts: 1599
Joined: Sat May 09, 2015 9:37 am

Re: Batch convert - input - normalize use of modifier keys

Post by user0 »

xnview wrote: Mon Jun 19, 2023 7:48 am Ok, i understand now. I can't detect if the source files come from file list or from windows explorer when dragging on the dialog. The only way is to disable drag&drop in the dialog.
ok, disabling drag&drop is not an option.

xnview wrote: Mon Jun 19, 2023 6:51 am
2. its still posible to drag&drop (from win file explorer) or add (via add files/folder) same file(s) multiple times
Yes, it's a behavior...
imho this is useless for Batch convert because duplicates will be overwritten by default,
but even if you add # - content of result files will be the same, only with new name (no idea why anyone would need that).

However, it may be useful (for someone) in Slideshow, Join Images, Multipage file tools
so what about Suggestion A?