b1: Thumbnails for folders - long creating

Bugs found in XnView Classic. Please report only one bug per topic!

Moderators: XnTriq, xnview

Dreamer
XnThusiast
Posts: 4605
Joined: Sun Jul 25, 2004 9:08 pm
Location: Slovakia

b1: Thumbnails for folders - long creating

Post by Dreamer »

Thumbnails for folders are created as last, when there are any pictures in dir., thumbnails for folders are created after 30 sec. sometimes. I think they should be created first, then th. for images should be created.

XnView 1.82 <x>
Last edited by Dreamer on Sat Feb 18, 2006 4:17 pm, edited 1 time in total.
ckit
XnThusiast
Posts: 2449
Joined: Tue Feb 17, 2004 1:11 am
Contact:

Post by ckit »

This may not be possible due to the new 4-in-1 feature which would check for pictures in each folder first.
XnView MP 64bits and Windows 10 Pro x64 20H2
PhotoFiltre Studio X
User avatar
xnview
Author of XnView
Posts: 34681
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: B1: Thumbnails for folders - long creating

Post by xnview »

Dreamer wrote:Thumbnails for folders are created as last, when there are any pictures in dir., thumbnails for folders are created after 30 sec. sometimes. I think they should be created first, then th. for images should be created.
I disagree, and thumbnails are not created after 30 seconds, but when all images thumbnail are created...
Pierre.
Dreamer
XnThusiast
Posts: 4605
Joined: Sun Jul 25, 2004 9:08 pm
Location: Slovakia

Re: B1: Thumbnails for folders - long creating

Post by Dreamer »

xnview wrote:
Dreamer wrote:Thumbnails for folders are created as last, when there are any pictures in dir., thumbnails for folders are created after 30 sec. sometimes. I think they should be created first, then th. for images should be created.
I disagree, and thumbnails are not created after 30 seconds, but when all images thumbnail are created...
It was just example (30 sec.), sometimes also 5 seconds are too long. Folders are on top, so I think thumbnails for folders should be created first. When I browse through many directories, I need to know if I'll go to sub-dir. first, then I need to see thumbnails for images. What other people think?
User avatar
helmut
Posts: 8220
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Re: B1: Thumbnails for folders - long creating

Post by helmut »

Dreamer wrote:
xnview wrote:
Dreamer wrote:Thumbnails for folders are created as last, when there are any pictures in dir., thumbnails for folders are created after 30 sec. sometimes. I think they should be created first, then th. for images should be created.
I disagree, and thumbnails are not created after 30 seconds, but when all images thumbnail are created...
It was just example (30 sec.), sometimes also 5 seconds are too long. Folders are on top, so I think thumbnails for folders should be created first. When I browse through many directories, I need to know if I'll go to sub-dir. first, then I need to see thumbnails for images. What other people think?
Hard to decide. I think the stuff that is visible should be created first. Probably this will be a mixture of folders and thumbnails.
User avatar
xnview
Author of XnView
Posts: 34681
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: B1: Thumbnails for folders - long creating

Post by xnview »

helmut wrote:
Dreamer wrote:
xnview wrote: I disagree, and thumbnails are not created after 30 seconds, but when all images thumbnail are created...
It was just example (30 sec.), sometimes also 5 seconds are too long. Folders are on top, so I think thumbnails for folders should be created first. When I browse through many directories, I need to know if I'll go to sub-dir. first, then I need to see thumbnails for images. What other people think?
Hard to decide. I think the stuff that is visible should be created first. Probably this will be a mixture of folders and thumbnails.
If i start folder thumbnail creation in the same time that thumbnail, so thumbnail creation will be slower!
Pierre.
Dreamer
XnThusiast
Posts: 4605
Joined: Sun Jul 25, 2004 9:08 pm
Location: Slovakia

Re: B1: Thumbnails for folders - long creating

Post by Dreamer »

Thumbnails for folders should be created first, than thumbnails for images. I'll try to explain why...

- enter the folder with few subfolders and 500 images
- you need to enter subfolder, but you want to check thumbnails first
- thumbnails for (non-visible) images are creating
- you must wait about 16 seconds
- then thumbnails for few subfolders are created

I'm 100% sure it's not good, maybe it's even a bug.
User avatar
xnview
Author of XnView
Posts: 34681
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: B1: Thumbnails for folders - long creating

Post by xnview »

Dreamer wrote:Thumbnails for folders should be created first, than thumbnails for images. I'll try to explain why...

- enter the folder with few subfolders and 500 images
- you need to enter subfolder, but you want to check thumbnails first
- thumbnails for (non-visible) images are creating
- you must wait about 16 seconds
- then thumbnails for few subfolders are created

I'm 100% sure it's not good, maybe it's even a bug.
everyone agree with that?
Pierre.
User avatar
helmut
Posts: 8220
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Re: B1: Thumbnails for folders - long creating

Post by helmut »

xnview wrote:
Dreamer wrote:...
- you must wait about 16 seconds
- then thumbnails for few subfolders are created

I'm 100% sure it's not good, maybe it's even a bug.
everyone agree with that?
No, I don't agree. I think XnView should first determine the items currently shown in the visible part of the file list and then read these items (first folders, then images). When all visible items are read, XnView can continue reading the non-visible items.
This would give the best result, I think.
Dreamer
XnThusiast
Posts: 4605
Joined: Sun Jul 25, 2004 9:08 pm
Location: Slovakia

Re: B1: Thumbnails for folders - long creating

Post by Dreamer »

helmut wrote:
xnview wrote:
Dreamer wrote:...
- you must wait about 16 seconds
- then thumbnails for few subfolders are created

I'm 100% sure it's not good, maybe it's even a bug.
everyone agree with that?
No, I don't agree. I think XnView should first determine the items currently shown in the visible part of the file list and then read these items (first folders, then images). When all visible items are read, XnView can continue reading the non-visible items.
This would give the best result, I think.
Helmut, but I want exactly the same!!! :?

Try to enable folders in the browser and my steps above.
User avatar
helmut
Posts: 8220
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Re: B1: Thumbnails for folders - long creating

Post by helmut »

Dreamer wrote:...
Helmut, but I want exactly the same!!! :?

Try to enable folders in the browser and my steps above.
Right, we mean pretty much the same. But not 100%: I mean that XnView should track which items are visible to the user and ensure that these are built up - when opening a folder but also when scrolling while the thumbnails are about being created. That's a slight but important difference.

I guess my suggested approach is hard to implement, so we should implement the solution that you have suggested (creation of thumbnails for folders first, then thumbnail for images).
User avatar
helmut
Posts: 8220
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Post by helmut »

Another aspect came to my mind: For creating a thumbnail for an image, you have to read one file. For creating a thumbnail for a folder, you have to read four files.
This aspect would argue for creating thumbnails for images, first.

Think this needs more thinking and more discussing...
Dreamer
XnThusiast
Posts: 4605
Joined: Sun Jul 25, 2004 9:08 pm
Location: Slovakia

Post by Dreamer »

helmut wrote:Another aspect came to my mind: For creating a thumbnail for an image, you have to read one file. For creating a thumbnail for a folder, you have to read four files.
This aspect would argue for creating thumbnails for images, first.

Think this needs more thinking and more discussing...
OK, I must wait about 16 seconds for creating thumbnails for (non-visible) images (500), till I get thumbnails for few (visible) folders.

And - I must wait 1 second for creating thumbnails for about 20 folders (just tested)!

So, what do you think now? :wink:
Xyzzy
Posts: 652
Joined: Tue Nov 23, 2004 10:17 pm
Location: Poland

Post by Xyzzy »

In my opinion 'Render first what you see is best', regardless of what is shown (folders or files).

Because if I display some items in file list, I expect them to be presented (thumbnailed) first- they are the most important for me now. For files it now works OK: if I browse very big directory and use slider to move to the end, thumbnails for displayed files are created immediately, not at the end. Now it should work the same way for folders.

X.
Dreamer
XnThusiast
Posts: 4605
Joined: Sun Jul 25, 2004 9:08 pm
Location: Slovakia

Post by Dreamer »

I think it's absolutely clear. The problem might be to implement the same behavior to folders, but at least thumbnails for folders should be created first and then thumbnails for images the same way as now.
Post Reply