RC1: Possible small handle leaks

Bugs and Issues in 1.82 Test versions which have been fixed and verified as resolved.

Moderators: XnTriq, xnview

Locked
User avatar
ckv
Posts: 786
Joined: Wed Feb 02, 2005 2:30 pm
Location: Glow
Contact:

RC1: Possible small handle leaks

Post by ckv » Thu Jan 12, 2006 12:54 pm

I have been systematically tracking handle leaks. And since RC1 is out I think it's right time to give the results. All of these don't necessarily are real leaks.

Heres what I have found:
==> http://newsgroup.xnview.com/viewtopic.php?t=4640
- Options / Toolbar / Skin page leaks GDI handles (when you close options window some GDI handles aren't released)
- JPEG Lossless Transformations window leaks two GDI handles for every run
- About window leaks two GDI handles for every run
- Every browser tab leaks GDI handles for every run (close and restart browser)

Edit: This probably isn't a real leak.
- Every image view tab leaks one handle for every run

Image view tabs don't leak if the browser is not open, but when it is open, one handle leaks every time when you close the tab. So the real leak probably is in browser (Thumbnail is updated after you close the view? And one handle leaks?).
Last edited by ckv on Sat Jan 14, 2006 10:38 am, edited 4 times in total.
XnView Tweak UI - Tool to customize your XnView beyond the regular XnView options.
UI-less Settings - Documentation of all the hidden settings in XnView.
XFAM - Tool to create and customize XnView file associations.

ckit
XnThusiast
Posts: 2445
Joined: Tue Feb 17, 2004 1:11 am
Contact:

Post by ckit » Sat Jan 14, 2006 8:31 am

When you close the About window are the GDI handles released?
If they are, there isn't a bug.

My Test 1:
Load XnView and Process Explorer
-> GDI Handles for XnView are 148

Open About Dialog
-> GDI Handles for XnView are 152

Close About Dialog
-> GDI Handles for XnView are 150

Conclusion = possible small leak.
XnViewMP 64bits and Windows 10 Pro x64 2004
PhotoFiltre Studio X

marsh
XnThusiast
Posts: 2443
Joined: Sun May 15, 2005 6:31 am

Post by marsh » Sat Jan 14, 2006 8:40 am

ckv wrote: Edit: This probably isn't a real leak.
- About window leaks two GDI handles for every run
I pity the user that clicks this 5000 times in one session. :) :) We'll get them all soon.

User avatar
ckv
Posts: 786
Joined: Wed Feb 02, 2005 2:30 pm
Location: Glow
Contact:

Post by ckv » Sat Jan 14, 2006 10:30 am

ckit wrote:Conclusion = possible small leak.
Yeah you are right. Oh my fault. Look the first post I fixed it. Sorry. :wink:

Image view tabs don't leak if the browser is not open, but when it is open, one handle leaks every time when you close the tab. So the real leak probably is in browser (Thumbnail is updated after you close the view? And one handle leaks?).

By the way how you overline text in this forum? , [strike] or [overline] don't work.
XnView Tweak UI - Tool to customize your XnView beyond the regular XnView options.
UI-less Settings - Documentation of all the hidden settings in XnView.
XFAM - Tool to create and customize XnView file associations.

ckit
XnThusiast
Posts: 2445
Joined: Tue Feb 17, 2004 1:11 am
Contact:

Post by ckit » Sat Jan 14, 2006 10:42 am

It's disabled by default as a security measure:

BBCode Strike
http://www.phpbbhacks.com/viewhack.php?id=444
XnViewMP 64bits and Windows 10 Pro x64 2004
PhotoFiltre Studio X

User avatar
xnview
Author of XnView
Posts: 33651
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: RC1: Possible small handle leaks

Post by xnview » Mon Jan 16, 2006 10:53 am

ckv wrote: - JPEG Lossless Transformations window leaks two GDI handles for every run
- About window leaks two GDI handles for every run
Right
- Every browser tab leaks GDI handles for every run (close and restart browser)

Edit: This probably isn't a real leak.
- Every image view tab leaks one handle for every run

Image view tabs don't leak if the browser is not open, but when it is open, one handle leaks every time when you close the tab. So the real leak probably is in browser (Thumbnail is updated after you close the view? And one handle leaks?).[/size]
Not sure that it's a leak...
Pierre.

ckit
XnThusiast
Posts: 2445
Joined: Tue Feb 17, 2004 1:11 am
Contact:

Post by ckit » Thu Jan 19, 2006 10:55 pm

For now, Closed.
XnViewMP 64bits and Windows 10 Pro x64 2004
PhotoFiltre Studio X

Locked