Proposal to clean up shortcuts for more consistent behavior of rotate commands

lucatrv · Post by **lucatrv** » Mon Dec 20, 2021 10:47 pm

At present this is the default configuration:

The two "rotate" buttons on the toolbar run the "cmd_rotate90" and "cmd_rotate270" commands.

In browser mode, the "Ctrl+Shift+R" and "Ctrl+Shift+L" shortcuts run the "cmd_lrotate90" and "cmd_lrotate270" commands.

In viewer mode, the "Ctrl+R" and "Ctrl+L" shortcuts run the "cmd_lrotate90" and "cmd_lrotate270" commands, while it is not possible to define shortcuts to run the "cmd_rotate90" and "cmd_rotate270" commands.

The option "Use lossless rotation (if possible)" is enabled by default. To my understanding, this means that when lossless rotation is possible the "cmd_rotateXX" and "cmd_lrotateXX" commands behave the same. However if one change that setting, or otherwise enable the "Change EXIF orientation ONLY (if possible)" option, then clicking either on the toolbar buttons or entering the shortcuts would give different results.

Here is my proposal:

The "cmd_rotateXX" commands are more flexible, as they can be configured to use loss, lossless, or EXIF rotations. So in my opinion, the shortcuts should be linked by default to the "cmd_rotateXX" commands (same as the toolbar buttons).

In browser mode, the "Ctrl+Shift+R" and "Ctrl+Shift+L" shortcuts should be associated to the "cmd_rotate90" and "cmd_rotate270" commands. This would provide consistent behavior with the two toolbar buttons.

In viewer mode, the "Ctrl+R" and "Ctrl+L" shortcuts should be deleted, and new "Ctrl+Shift+R" and "Ctrl+Shift+L" shortcuts should be defined linked to the same "cmd_rotate90" and "cmd_rotate270" commands. This would provide consistent behavior as well.

Note: the "cmd_lrotateXX" commands, although not used by any shortcuts by default, should remain available in case some users disable the "Use lossless rotation (if possible)" option, and would like to define different shortcuts to specifically apply lossless rotation.

Finally, I add the suggestion to enable also the "Change EXIF orientation ONLY (if possible)" option by default. This way, to my understanding, the "cmd_rotateXX" commands would first try to change the EXIF orientation if possible, then otherwise attempt a lossless rotation if possible, or otherwise perform a loss rotation. This one in my opinion would be the preferred default behavior for all buttons and shortcuts.

Thanks