1.5.0 - viewer - High zoom quality - None still affects image

[user0]

XnViewMP 1.5.0b2 64bit
Windows11 (22H2), display resolution 3840x2160, win scaling 150%

Viewer - zoom - High zoom quality
"None" still affects image

To reproduce:
1. run clean portable XnViewMP
2. open any image
- zoom-in OR zoom-out
3. goto Settings>View>View tab
- make sure 'High zoom quality' is None for -in and -out
- press OK
4. check 'High zoom quality' item in Viewer (View menu)

issue A
image will be smoothed
Expected behaviour:
no anti-aliasing filter shall be applied as they both are set ot None in Settings

issue B
5. press F12 to open Settings
6. press ESC to close Settings
smoothing will be disabled
'High zoom quality' item in Viewer (View menu) will be unchecked
Expected behaviour:
closing Settings should not change 'High zoom quality' state




Related

• issues
  1.5.0 - viewer - High zoom quality - None still affects image (current post)
  - fixed -
  1.4.0 - viewer - High zoom quality + Change color depth issue (1.5.0)
  1.4.4 - viewer - High zoom quality - state out of sync (1.4.5)

[xnview]

Is it a new issue of 1.5.0 beta?

[user0]

same issue in 1.4.5

[xnview]

'High zoom quality' enable smooth scaling for current tab

[user0]

yeah, I got that )

but why if there is None for Zoom-in/out in Settings?
it either:
- should not smooth at all OR
- some default method shall be selected in Settings (which one is used in this case?)

[xnview]

it must not change Settings because it's temporary. Once the tab closed, settings will be used

[user0]

so, there are 2 sets of settings for smoothing/antialiasing:

• permanent
  - settings listed in Settings > View > View
  - applied by default
  - can be overcome by temp smoothing if:
  -- set to None
  -- 'High zoom quality' in Viewer > View menu switched ON (or OFF and ON if only one mode is set to None in Settings)

• temporary
  - settings not listed anywhere, guess its Bilinear for both modes (in/out)
  - by default it is overcome by permanent settings
  - activates only when you click on 'High zoom quality' menu item (checkbox) once or twise (see above) in Viewer > View menu

I think this is overengineering (prone to bugs, see issue B in updated OP) with extremely unintuitive behavior.

Suggestion
my advice was to:
- make temp settings explicit and
- explicitly name these 2 sets, something like Temp/Quick/Default and Main/Permanent
eg like this:

settings_high_zoom_quality_modes.png (5.93 KiB) Viewed 2282 times

However, the proper approach would be to simplify this feature:

• get rid of hidden temp settings at all and

• use 'High zoom quality' in Viewer only as a switch for permanent settings:
  • if ON - check settings of in/out modes:
    - if None - apply nothing
    - if not None - apply choosen filter
  • if OFF - no filter applied

• 'High zoom quality' ON/OFF state shall be applied to all tabs and be persistent (eg like Lock zoom)

if user wants to change some filter he goes to settings and change filter manually, simple as that

[xmozg]

Different implementations of functions are convenient for different people, and for some it will definitely be more convenient for the temporary version of “high quality zoom” in viewer, rather than for it to work as a permanent one.
You mentioned "persistent zoom lock"

'High zoom quality' ON/OFF state shall be applied to all tabs and be persistent (eg like Lock zoom)

The fact is that it is "persistent" only by default.
viewtopic.php?f=62&t=46002&p=191209#p191209

You can enable it in temporary mode via xnview.ini. And it’s the temporary Lock zoom mode that I use, because it’s more convenient for me. In the same way, it may be more convenient for someone to use the temporary High zoom quality mode. And I don't think that a significant number of users will need quick access from the Viewer menu to change this permanent setting. Permanent settings are not something that changes frequently.

What I noticed: For permanent zoom-out setting, if set to "none" or "billinear", the temporary high quality zoom setting switches between "none" and "billinear". It is ok. But for permanent zoom-out bicubic-lanczos4 settings, the temporary high quality zoom "none" setting no longer works (at all). It is bug. Whereas for any zoom-in permanent settings, temporary high quality zoom works fine.

So, my final recommendation: fix the above bug and.... that's it)
Created a separate topic for the bug just in case. viewtopic.php?f=62&t=46370

[user0]

Different implementations of functions are convenient for different people, and for some it will definitely be more convenient for the temporary version of “high quality zoom” in viewer, rather than for it to work as a permanent one.

It is convenient when done right, this is not a case here since 2 sets of filters linked to the same checkbox (issue A).
I also can't think of a way to justify the existence of a temp set of filters.

You mentioned "persistent zoom lock"

'High zoom quality' ON/OFF state shall be applied to all tabs and be persistent (eg like Lock zoom)

The fact is that it is "persistent" only by default.
viewtopic.php?f=62&t=46002&p=191209#p191209

You can enable it in temporary mode via xnview.ini. And it’s the temporary Lock zoom mode that I use, because it’s more convenient for me. In the same way, it may be more convenient for someone to use the temporary High zoom quality mode.

I'm not against temp/permanent state of this feature. It just shall be done differently, eg once there is only one set of filters:
- add checkbox in Settings (in front of feature name) to control persistent state,
- existing checkbox in View menu inherits persistent state on tab open, but only valid until tab is closed.

Approach shall be like this - if same setting exists in both places (Settings and tabs) and has state - Settings shall be persistent, tab - session only.

And I don't think that a significant number of users will need quick access from the Viewer menu to change this permanent setting. Permanent settings are not something that changes frequently.

I never said there shall be any "quick access from the Viewer menu to change this permanent setting".
Viewer menu stays visually unchanged, same single checkbox 'High zoom quality'.

[xnview]

ok, i understand the problem now. So you would like that 'View>High zoom quality' change 'Settings>View>High quality'??

[user0]

So you would like that 'View>High zoom quality' change 'Settings>View>High quality'??

checkbox in Viewer only switches ON/OFF this feature, not change zoom in/out settings in Settings

2 mockups:

high_zoom_quality.png (8.8 KiB) Viewed 2181 times

• General, in both mockups:
  • single set of zoom in/out settings
  • zoom in/out settings changes only manually

• Mockup C - simple
  • no visual changes
  • ON/OFF state - exists only in Viewer
    - persistent
    - changes only manually

• Mockup D - with temp state
  • only checkbox added in Settings
  • ON/OFF state - 2 states
    - checkbox in Settings - persistent, changes only manually
    - checkbox in Viewer - temporary, inherits from Settings, exists until tab is closed

Case

• both zoom in/out set to None in Settings
  • current behaviour
    Viewer checkbox unchecks automatically
    if user switch it ON - hidden set of zoom in/out settings will be applied
  • expected behaviour
    Viewer checkbox should not be affected by zoom in/out settings. State manages as per Mockup C/D.
    If user switch it ON - no smoothing shall be applied (as zoom in/out set to None in Settings)

[xnview]

why adding another setting??

[user0]

C - is optimal for me
D - just to show what can be achieved theoretically

[xnview]

sorry but i don't understand. When opened a tab, 'Settings>View>High quality' will always used, so no need to add a new setting...

[user0]

let's stick to mockup C, where no additional setting is required

C
sequence is like following:
1. tab is opened
2. if 'High zoom quality' (in Viewer>View) is:

• ☑
  smoothing applied as per 'Settings>View>High zoom quality'
  if any zoom (in AND/OR out) is set to None, corresponding smoothing should not be applied <--- this is my desired behavior from issue A

• ☐
  no smoothing

ps. also state of 'Viewer>View>High quality' checkbox should be memorized when closing the application