rc2: multiple view options conflict.

[Xyzzy]

EDIT: This post has been heavily edited because of errors. Fortunately still it remains valid.

3. 'General>Open one view per selected image' checked and View>Only one view opened' checked.

Open from File>Open opens single View (multiple files selected)- conflict with 1st option.
Open from RMB>Open in Browser opens multiple Views (multiple files selected)- conflict 2nd option.

4. 'General>Open one view per selected image' unchecked and View>Only one view opened' unchecked.

Open from File>Open opens single View (multiple files selected)- conflict with 2nd option.
Open from RMB>Open in Browser opens single View (multiple files selected)- conflict with 2nd option.

If I got it right, it's quite a mess IMO.

Expected actions- remove one of these options. The remaining should control number of Views in every Open context.
If and only if there is a reason to define separate behaviours for Open in different contexts, fix existing behaviour.

X.

XnView 1.82 <x>

[xnview]

'General>Open one view per selected image'

Not sure that this option must be kept... We have 'open' and 'open all'

[Xyzzy]

You mean 'Open all' superseding limit forced by some option (let's say it's 'Only one view opened')?

So what happens if 'Only one view opened' is set, you use Open all to open 4 images, and then you Open another image? Active View is replaced? Or images handled by Open all are handled separately from images opened by Open, so that there is one "Open" window and as many "Open all" windows as user wants, even if 'Only one view opened' is set?

I thought that Open should simply enable opening single image when there are many selected, without unselecting them.

X.

[Olivier_G]

I understood 'Open one view per selected image' as 'Open every image of the selection' (in opposition to 'open first image of selection', apparently... which is not a good choice: should be last/current focused). But the name is confusing...

Therefore I see only 1 bug:

3. 'General>Open one view per selected image' checked and View>Only one view opened' checked.
Open from RMB>Open in Browser opens multiple Views (multiple files selected)- conflict with both options.

- - - - - - - - - - - - - - - - - - - -

Not sure that this option must be kept... We have 'open' and 'open all'

I agree.
Suggestion:
- With 'Only one view opened' checked, the 'Open all' should not appear at all.
- With 'Only one view opened' unchecked, 'Open all' should open all files of the selection (+depends on 'Open action')
- And on a selection, 'Open' should open the last/current file in focus (ie: lastly selected, or currently selected with the RMB)

Olivier

[Xyzzy]

I understood 'Open one view per selected image' as 'Open every image of the selection' (in opposition to 'open first image of selection', apparently... which is not a good choice: should be last/current focused). But the name is confusing...

I understand it the same ways and still find my bugs valid, fe.:
1. 'General>Open one view per selected image' checked and View>Only one view opened' unchecked.

Open from File>Open opens multiple Views (multiple files selected)- conflict with 1st option.
'Open one view' is checked but still Open>File opens multiple Views. Bad.

Suggestion:
- With 'Only one view opened' checked, the 'Open all' should not appear at all.
- With 'Only one view opened' unchecked, 'Open all' should open all files of the selection (+depends on 'Open action')
- And on a selection, 'Open' should open the last/current file in focus (ie: lastly selected, or currently selected with the RMB)

Almost so:

- Trash one option
- If 'Only one view opened' is checked, 'Open all' is disabled in RMB menu and File>Open opens last selected file (as currently).
- Otherwise, RMB menu Open on multiple selection opens the file that actually was clicked with RMB and in File>Open opens all selected files.

X.

[Olivier_G]

I agree with you for the rest.

Just about that:

1. 'General>Open one view per selected image' checked and View>Only one view opened' unchecked.
'Open one view' is checked but still Open>File opens multiple Views. Bad.

Why 'bad'? I decided To 'Open one view per selected image', and when I use 'Open', I actually get one View per selected image, ie: multiple Views...

Anyway... not big deal as it seems that this option will disappear...

Olivier

[Xyzzy]

I agree with you for the rest.

Just about that:

1. 'General>Open one view per selected image' checked and View>Only one view opened' unchecked.
'Open one view' is checked but still Open>File opens multiple Views. Bad.

Why 'bad'? I decided To 'Open one view per selected image', and when I use 'Open', I actually get one View per selected image, ie: multiple Views...

Anyway... not big deal as it seems that this option will disappear...

Yes, I messed up with errors (I'll edit the post), thanks for noting this.

X.

[xnview]

Suggestion:
- With 'Only one view opened' checked, the 'Open all' should not appear at all.
- With 'Only one view opened' unchecked, 'Open all' should open all files of the selection (+depends on 'Open action')
- And on a selection, 'Open' should open the last/current file in focus (ie: lastly selected, or currently selected with the RMB)

Yes, right, but currently it's better to be postponed...

[Xyzzy]

I guess so, because any solution will make conflict when the options indicate different settings (single vs multiple Views).

Anyway, one to be removed in the future.

X.