[NOTABUG] Batch Convert: cannot add file by typing its name

[zencd]

Hello! found a bug:

1. Choose "Batch Convert" dialog
2. Press "Add..."
3. Type full path to an existing file into appropriate field of a dialog raised
4. Press "Ok"
5. No file added after the dialog closed
__________

xnview 1.82.4
windows xp (no s.packs)
__________

Additionally: button "Ok" is under "Cancel" - that's an unusual ordering for the windows platform

[Clo]

Hello !

• The field where the added files appear within quotes like ["file1.xyz" "file2.xys" … ] and so on is not designed to type files and paths to add…
- When you have pressed the [Add] button the first time and you forgot some file(s),
you must press [Add] again and choose the missing item(s)…

Additionally: button "Ok" is under "Cancel" - that's an unusual ordering for the windows platform

- I have groused against that annoying layout for ages ! I mistook a lot of times
- But there is a reason : These two buttons do not belong to the same window !
• Below, a quick test I did in French {because there is a test-language-DLL… }, the captions of the buttons are translated :

——————

The part under the thick red line belongs to XnView,
while the part above is a standard “Browse¦Choose…” dialogue of Windows (just notice the icons at top).

• Like shown here, it's possible to invert the locations of the “Add” and “OK” buttons - this is not a fake, it works -
- Usually, this “OK” button is set too above the “Cancel” one (removed here) but in the French Windows, it's not translated…
- Maybe the “Cancel” button could be set on the part of XnView too,
this should allow an optimal different layout for all buttons…

Kind regards,
Claude
Clo

[zencd]

Okay, I understood now the idea of dialog, but note such a scenario:
1. select one file
2. its name appears in field "File name"
3. press "OK" (not "Add")
4. voila! the file is added to the list

but entering an absoulte file name into "File name" I have no file added, although there is no serious difference btw abs. and relative paths...
_________

about dialog - I have an idea about its layout redesign. it will require some work to rewrite the dialog from scratch, because there is a standard windows part you cannot change (seems)

let's imagine...

Code: Select all

|----------------------------|
|----------------------------|
||                          ||
||                          ||
||                          ||
|----------------------------|
|File name:                  |
|File of type:               |
|----------------------------|
|----------------            |
||              | Add        |
||              | Remove     |
||              | Rem all    |
|----------------            |
|----------------------------|
|                OK  CANCEL  |
|----------------------------|

Also it could be divided into left (all files) and right parts (selected files) - I found it more intoitive now.
Oooff .. me finished

[zencd]

Wow! It seems like you even need no to rewrite the dialog. Just add a (visually separating) divider under windows std dialog and move buttons "Ok" and "Cancel" to the most bottom.

Surely you need no nothing of this really :)

[Clo]

I guess that XnView considers only the path given by the Win box, and not the one you type…

• Yes, the best layout for the buttons is something like you show, I thought so too…
- The only snag is to know whether the "Cancel" button set on the part of XnView should be able to cancel the whole operation, like it does currently when located on the part of Windows…

KR
Claude
Clo