Crash when using batch rename and inserting placeholders

Bugs found in XnView Classic. Please report only one bug per topic!

Moderators: helmut, XnTriq, xnview

Lupin III.

Crash when using batch rename and inserting placeholders

Post by Lupin III. »

XnView 1.90.3 (as did version 1.82.4) crashes when using the batch rename function on the following occasion:
Browse a folder and select some files, use tools -> batch rename. The "name template" must not be selected. If it already is, uncheck it, click cancel, open the window again. It should be unchecked and the textfield and insert button should be disabled. Select the "name template" checkbox and immediatly afterwards click "insert" (especially don't click into the textfield) and select any tag. The program should crash now.

It's easy to avoid, if you know how, and not really a big issue, but it took me some tries to get it working the first time I used the function (where the checkbox was unchecked).
User avatar
helmut
Posts: 8704
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Post by helmut »

I've tried to reproduce the problem, but it did not crash.

On which OS (Windows XP, ...) do you work?
What type of files do you use for batch renaming?
Does it crash with any placeholder?

(XnView 1.90.3 on Windows XP SP2)
Guest

Post by Guest »

I'm using xnview 1.90.3 on WinXP SP1. It doesn't matter which filetypes are selected. It crashes on JPGs, PNGs, GIFs, PDFs. And it crashes for any placeholder.
User avatar
xnview
Author of XnView
Posts: 46236
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Post by xnview »

Anonymous wrote:I'm using xnview 1.90.3 on WinXP SP1. It doesn't matter which filetypes are selected. It crashes on JPGs, PNGs, GIFs, PDFs. And it crashes for any placeholder.
Very strange, when you click on Rename? Even if you select 2 files?
Pierre.
Lupin III.

Post by Lupin III. »

xnview wrote: Very strange, when you click on Rename? Even if you select 2 files?
No, it already crashes as soon as I select any placeholder (e. g. "Filename", "Size", "Exif-Image -> Date taken") from the popup list after clicking on insert. It doesn't matter how many files are selected, how they are named, where they are in the list, (although at least one has to selected of course to enable the menu entry). I can reproduce the bug every time.
User avatar
xnview
Author of XnView
Posts: 46236
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Post by xnview »

Lupin III. wrote:
xnview wrote: Very strange, when you click on Rename? Even if you select 2 files?
No, it already crashes as soon as I select any placeholder (e. g. "Filename", "Size", "Exif-Image -> Date taken") from the popup list after clicking on insert. It doesn't matter how many files are selected, how they are named, where they are in the list, (although at least one has to selected of course to enable the menu entry). I can reproduce the bug every time.
Could you post a screenshot of the dialog before the crash?
Pierre.
Lupin III.

Post by Lupin III. »

I have rarely done UI pro-gramm-ing outside of HTML pages, but if there is a bug, I would expect it where the new template token is concatenated to the existing one.
Guest

Post by Guest »

Maybe it's something like "oldstring.concat(newstring)", which seems to be undefined. But it's still a mystery to me, why it only happens to me.
The windows (german) message is: "Die Anweisung in 0x004c370b verweist auf Speicher 0x00131000. Der Vorgang read konnte nicht auf dem Speicher durchgeführt werden"


Sorry, I had to make several posts (and didn't think you answer that fast). I couldn't find the "spam" word otherwise. In the end I don't know what the offending word was (and I wouldnt be able to write it here anyway, because it's spam ;-), but isn't that a little bit too strict, especially if it doesn't tell you which of the hundreds of words is "bad"?
Lupin III.
Posts: 12
Joined: Sun May 06, 2007 1:05 pm

Post by Lupin III. »

xnview wrote: Could you post a screenshot of the dialog before the crash?
How can I post screenshots? I created an account for this forum now, but there's no possibility to add an image.

btw. the spam word was "pro-gram-ming" in the previous post. That's why there are dashes in it now, even as registered user it wouldn't let me post it. Why is this on a spam list?
User avatar
Clo
XnThusiast
Posts: 4441
Joined: Sun Oct 17, 2004 4:57 am
Location: Bordeaux, France
Contact:

Upload and …

Post by Clo »

—> Lupin III.

:) Hello !
How can I post screenshots? I created an account for this forum now, but there's no possibility to add an image. …
• The server of the forum itself doesn't store the images you need to show in the messages.

• Upload you image to an image host or to your own Web space if you have any (a folder in your Web site, for instance).
- Then, use the …ULR of the image[/i m g] marker in your message.

:mrgreen: Kind regards,
Claude
Clo
Last edited by Clo on Sun May 06, 2007 4:39 pm, edited 1 time in total.
Old user ON SELECTIVE STRIKE till further notice
Lupin III.
Posts: 12
Joined: Sun May 06, 2007 1:05 pm

Post by Lupin III. »

xnview wrote: Could you post a screenshot of the dialog before the crash?
Before the click (on the highlighted item):

Image

One click after:

Image
User avatar
helmut
Posts: 8704
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Post by helmut »

I could not reproduce this problem. (Windows XP SP2, XnView 1.90.3).

Could you please rename your xnview.ini file so that XnView starts with default settings? (I guess this is a problem of installation and/or .ini settings).
Lupin III.
Posts: 12
Joined: Sun May 06, 2007 1:05 pm

Post by Lupin III. »

Yes, this did it. In my old config all Template# entries in the "Rename" section were empty. Now it at least starts with "name-#".
After clearing all the template entries in the ini-file xnview crashes like described. I don't know why all entries were empty, didn't do this by hand.
marsh
XnThusiast
Posts: 2443
Joined: Sun May 15, 2005 6:31 am

Post by marsh »

Lupin III. wrote:Yes, this did it. In my old config all Template# entries in the "Rename" section were empty. Now it at least starts with "name-#".
After clearing all the template entries in the ini-file xnview crashes like described. I don't know why all entries were empty, didn't do this by hand.
Confirmed. :bug: I can recreate problem only by clearing all the template entries in ini file and setting the 'use template' entry to 0 there also!
User avatar
helmut
Posts: 8704
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Post by helmut »

Lupin III. wrote:Yes, this did it. In my old config all Template# entries in the "Rename" section were empty. Now it at least starts with "name-#".
After clearing all the template entries in the ini-file xnview crashes like described. I don't know why all entries were empty, didn't do this by hand.
Good to read that it no longer crashes. :-) Could you please send your old xnview.ini file (which caused the crash) to Image (Pierre)? He might make XnView more robust with handling those .ini values.
Post Reply