Multi-level UnDo: Change number of UnDos

[helmut]

... But before Pierre has to change this "multi-undo" behavior:
The first image (the original one) must always stay in Tmp memory (as soon as we apply a first or more changes¦effects) even if the number of modifications is over the level in the xnview.ini file: Undocount= setting.
By this way, undo all changes always means : return to the first step (the original image).
http://newsgroup.xnview.com/viewtopic.php?t=13970

Don't we have an "Undo all", already? There's the menu item "File > Reopen" (or Ctrl + R) to reload the original image.

[oops66]

... But before Pierre has to change this "multi-undo" behavior:
The first image (the original one) must always stay in Tmp memory (as soon as we apply a first or more changes¦effects) even if the number of modifications is over the level in the xnview.ini file: Undocount= setting.
By this way, undo all changes always means : return to the first step (the original image).
http://newsgroup.xnview.com/viewtopic.php?t=13970

Don't we have an "Undo all", already? There's the menu item "File > Reopen" (or Ctrl + R) to reload the original image.

Yes good idea, why not, but in this case, the last clic onto the undo arrow icon must automaticaly call this Reopen function (= undo-all), and right now it's not the case. This way also loses the posssibility of a new Redo.
(this way also spends more users time than this one : " the original image must always stay in the undo Tmp memory even if the number of modifications is over the Undercount level setting" ).
For exemple :
1) set Undocount=3
2)open an image
3) rotate clockwise 4 times ( = same orientation as original)
4) clic undo 3 (or more) times
And you can not go back to the original image, this is the problem.

[oops66]

...When all changes are undone this indicator should disappear, and upon closing the file XnView shouldn't ask if the user wants “to save changes”.

Thanks Pierre, that's point works now with this new 1.92Beta4 when the numbers of changes is smaller or equal or superior to the Undercount level setting. Great.
(But in the superior case, the behavior is pretty strange,... try the orientation exemple above - Because you can close the tab without warning, in a wrong displayed image orientation).

[marsh]

...When all changes are undone this indicator should disappear, and upon closing the file XnView shouldn't ask if the user wants “to save changes”.

Thanks Pierre, that's point works now with this new 1.92Beta4 when the numbers of changes is smaller or equal or superior to the Undercount level setting. Great.
(But in the superior case, the behavior is pretty strange,... try the orientation exemple above - Because you can close the tab without warning, in a wrong displayed image orientation).

I don't understand. For me there is a new (b4) fix with "do not show again" dialog. It properly closes (without unwanted warning) for me.

[oops66]

I don't understand. For me there is a new (b4) fix with "do not show again" dialog. It properly closes (without unwanted warning) for me.

Hello Marsh,
Try the exemple above and you will see by yourself.
But this is not a major problem and it can be posponed.

For exemple with a Undocount=4 , we should have (Undo Tmp memory, displayed screen):

Code: Select all

  <-  Undo 4   <-    Undo 3   <-   Undo 2   <-   Undo1
original - change n°1 - change n°2 - change n°3 - change n°4 
original - change n°2 - change n°3 - change n°4 - change n°5 
...
original - change n°5 - change n°6 - change n°7 - change n°8 
original - change n°6 - change n°7 - change n°8 - change n°9 
original - change n°7 - change n°8 - change n°9 - change n°10 

....
But for the moment it's like this:

Code: Select all

    <-    Undo 4 <-     Undo 3   <-  Undo 2    <-  Undo1
original  -  change n°1 - change n°2 - change n°3 - change n°4 
change n°1 - change n°2 - change n°3 - change n°4 - change n°5
...
change n°5 - change n°6 - change n°7 - change n°8 - change n°9
change n°6 - change n°7 - change n°8 - change n°9 - change n°10
change n°7 - change n°8 - change n°9 - change n°10 - change n°11

Then for the moment, you can close tab without warning for change n°0 original (normal) but also n°1,...,5, 6, 7 ... nd it is pretty strange!

[Kristian Kjaer]

Thanks for a great program.
"lossless jpeg crop" should be in the (rightclick) context menu of the viewer.
Currently there is only "crop".
The help file
("produced on 21 September 2007", file date 19-12-2007 16:38)
says that the shortcuts are
(Lossless JPEG) crop : (Ctrl+)Shift+Y
but in fact they are : (Ctrl+)Shift+X

[Kristian Kjaer]

Also, since lossless jpeg crop is irreversible, along with the warning "this will modify the original file" there should be an option to save the cropped file under a different name and leave the original file unchanged.