B1: 'Add Folder' to thumbnail Cache stops...

Bugs and Suggestions in XnView Classic which have been resolved

Moderators: XnTriq, xnview

User avatar
Olivier_G
XnThusiast
Posts: 1423
Joined: Thu Dec 23, 2004 7:17 pm
Location: Paris, France

B1: 'Add Folder' to thumbnail Cache stops...

Post by Olivier_G »

Go to Options>Thumbnail:Cache and 'Add Folder':
1. Progress bar is not related to the real progression
2. It just stops near the end without closing dialog (it seems to actually work if you use 'Cancel' at the end)
Olivier
marsh
XnThusiast
Posts: 2443
Joined: Sun May 15, 2005 6:31 am

Post by marsh »

comfirmed.
User avatar
robc
Posts: 164
Joined: Mon Nov 14, 2005 12:53 pm

Post by robc »

Me too. Sorry for double posting...
User avatar
xnview
Author of XnView
Posts: 37620
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Re: B1: 'Add Folder' to thumbnail Cache stops...

Post by xnview »

Olivier_G wrote:Go to Options>Thumbnail:Cache and 'Add Folder':
1. Progress bar is not related to the real progression
Yes, it's not really a progress bar, because i don't know how many files to process...
2. It just stops near the end without closing dialog (it seems to actually work if you use 'Cancel' at the end)
Right
Pierre.
User avatar
Olivier_G
XnThusiast
Posts: 1423
Joined: Thu Dec 23, 2004 7:17 pm
Location: Paris, France

Re: B1: 'Add Folder' to thumbnail Cache stops...

Post by Olivier_G »

Olivier_G wrote:2. It just stops near the end without closing dialog
Fixed in Beta 2. Thanks Pierre.
xnview wrote:
Olivier_G wrote:1. Progress bar is not related to the real progression
Yes, it's not really a progress bar, because i don't know how many files to process...
Can't you make a first quick pass just to evaluate files to thumbnail (ie: not already thumbnailed +corresponds to 'Items displayed:Show as thumbnail' +according to extension checking)?

I move it back to 'Confirmed' because I consider the progress bar issue important enough to be considered as a bug.
Olivier
marsh
XnThusiast
Posts: 2443
Joined: Sun May 15, 2005 6:31 am

Re: B1: 'Add Folder' to thumbnail Cache stops...

Post by marsh »

Olivier_G wrote:
Olivier_G wrote:2. It just stops near the end without closing dialog
Fixed in Beta 2. Thanks Pierre.
xnview wrote:
Olivier_G wrote:1. Progress bar is not related to the real progression
Yes, it's not really a progress bar, because i don't know how many files to process...
Can't you make a first quick pass just to evaluate files to thumbnail (ie: not already thumbnailed +corresponds to 'Items displayed:Show as thumbnail' +according to extension checking)?

I move it back to 'Confirmed' because I consider the progress bar issue important enough to be considered as a bug.
I don't think it is necessary to compute the total number of thumbnails before adding them. Would this not slow things down when using large directories? Progress indicators always seem inaccurate to me anyway (cf. batch convert).
User avatar
xnview
Author of XnView
Posts: 37620
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Re: B1: 'Add Folder' to thumbnail Cache stops...

Post by xnview »

Olivier_G wrote:
xnview wrote:
Olivier_G wrote:1. Progress bar is not related to the real progression
Yes, it's not really a progress bar, because i don't know how many files to process...
Can't you make a first quick pass just to evaluate files to thumbnail (ie: not already thumbnailed +corresponds to 'Items displayed:Show as thumbnail' +according to extension checking)?

I move it back to 'Confirmed' because I consider the progress bar issue important enough to be considered as a bug.
Ok, i'll make 2 pass :-)
Pierre.
User avatar
Olivier_G
XnThusiast
Posts: 1423
Joined: Thu Dec 23, 2004 7:17 pm
Location: Paris, France

Re: B1: 'Add Folder' to thumbnail Cache stops...

Post by Olivier_G »

xnview wrote:Ok, i'll make 2 pass :-)
Thank you, Pierre.
marsh wrote:I don't think it is necessary to compute the total number of thumbnails before adding them. Would this not slow things down when using large directories?
I remember robc saying that he launched this 'Add folder' for a whole night and didn't know where it was in the morning (maybe buggy, though... :? ) while several people mentionned having a database file of several GBs => having an accurate progress bar is then more important than a 5% difference in speed, especially for a maintenance operation (ie: it's not your average everyday use).

It probably makes even more sense than the 'Thumbnails creation progress bar' when you enter a large folder... and nobody would want to remove this one... :wink:
Olivier
nightflyer
Posts: 98
Joined: Tue Sep 26, 2006 7:41 am

Post by nightflyer »

I think that reporting absolute progress is enough (so that for example number of files processed is displayed).

Performing a counting first only adds time to process, while detailed information on completion time is not important- or only for curiosity- because you have to wait until the end, this way or another.

I am against doing a count first. Displaying number of files processed (or directories) should be enough.
-=nightflyer=-
User avatar
GeorgD
Posts: 284
Joined: Thu Oct 12, 2006 2:45 pm

Post by GeorgD »

nightflyer wrote:I am against doing a count first. Displaying number of files processed (or directories) should be enough.
Mh, I agree for slow devices, but for HDD the number of files is computed within some seconds while the process needs many minutes - and I'd like to know whether I shall turn on the other computer / go to eat/sleep/sports/... or wait or interrupt. Maybe another option?? Hm. Not sure.
User avatar
Olivier_G
XnThusiast
Posts: 1423
Joined: Thu Dec 23, 2004 7:17 pm
Location: Paris, France

Post by Olivier_G »

GeorgD wrote:the number of files is computed within some seconds while the process needs many minutes
For 3500 images from my digital camera (6MP JPEG; 1.5MB) on HD:
- count (properties from XP, including size!) = 5s
- generate thumbnails (estimated) = 12mn

=> 0.5% slower (you get accurate progress bar and estimated remaining time in compensation... :mrgreen: )
Olivier
User avatar
robc
Posts: 164
Joined: Mon Nov 14, 2005 12:53 pm

Post by robc »

I like the current progress bar behavior and consider this as fixed in B3. ;-)
User avatar
Olivier_G
XnThusiast
Posts: 1423
Joined: Thu Dec 23, 2004 7:17 pm
Location: Paris, France

Post by Olivier_G »

Right! It's great!
Olivier