1.92.1: 'Show all files (recursive)' doesn't work on root

Bugs found in XnView Classic. Please report only one bug per topic!

Moderators: XnTriq, helmut, xnview

User avatar
helmut
Posts: 8705
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

1.92.1: 'Show all files (recursive)' doesn't work on root

Post by helmut »

Perhaps a feature, but I think it's more a bug:

When applying the function "Show all files (recursive)" to a root folder, nothing happens. The function works only on the first level of folders or subsequent subfolders.
User avatar
Clo
XnThusiast
Posts: 4441
Joined: Sun Oct 17, 2004 4:57 am
Location: Bordeaux, France

Ages & hung

Post by Clo »

:arrow: helmut

• Hi !

• IMHO, it's preferable that the whole files in the root be not displayed, because that could take ages
and even hang the programme¦PC by eating all the free memory…

• It's possible in Total Commander, but strongly not recommended !
- Aside, like I said HERE, the command is not bistable in XView, getting back the normal display needs a trick…
Still not fixed in 1.93-ß2 :|

:mrgreen: G.
Claude
Clo
Old user ON SELECTIVE STRIKE till further notice
User avatar
helmut
Posts: 8705
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Re: Ages & hung

Post by helmut »

Clo wrote::• IMHO, it's preferable that the whole files in the root be not displayed, because that could take ages
and even hang the programme¦PC by eating all the free memory…
Thank you, Clo, for listing various aspects. I think it should be in the users hand, if he/she wants to see all file starting from the root he/she should see them (e.g. I've tried on a small memory stick, but it didn't work).
Clo wrote:... - Aside, like I said HERE, the command is not bistable in XnView, getting back the normal display needs a trick…
Still not fixed in 1.93-ß2 :|
From what I can see, the command is not designed to be bistable. So currently it works as designed. But switching back to normal view is simple: In folder tree click on any folder. Or did I miss something? (Perhaps to be discussed in the other topic)
User avatar
ouistiti
Posts: 353
Joined: Mon Oct 25, 2004 7:28 pm
Location: Belgique

Post by ouistiti »

:arrow: helmut

- I guess that the branch view on the root is often risky…
However, we could have an INI entry option to choose the behaviour of that command, i.e. :
BranchViewOnRoot=1 / 0 - ("0" being disabled by default).

I agree with Clo, that command might be bistable.

Friendly

Paul
L'important n'est pas de convaincre, mais de donner à réfléchir.
The important thing is not to convince, but to incite to think.

1,77245385090552...
User avatar
Clo
XnThusiast
Posts: 4441
Joined: Sun Oct 17, 2004 4:57 am
Location: Bordeaux, France

F5 YES, Ctrl+R NO !

Post by Clo »

—> helmut

• Again…
From what I can see, the command is not designed to be bistable. So currently it works as designed. …
• It might be, for instance whether we would have the command to set a button in the tool-bar
(very handy and not possible yet).
- Indeed, opening another folder closes the branch¦flat view, but it's tricky.
One can also make a refresh by F5, same result. But here, the similar command Ctrl+R leads to
an empty panel of thumb nails, like said in the other thread (and unanswered from Pierre…).
- Moreover, an indication to reverse the command is nowhere to be found.
- Of course, we'ld add some info in the Manual, but it should be better to get the bistable behaviour…
- I guess that it's as so well to continue here, if possible.
- Just to remind : In TC, the command is indeed bistable, and works such as when set on a custom button :D

:mrgreen: G.
Claude
Clo
Old user ON SELECTIVE STRIKE till further notice
User avatar
Clo
XnThusiast
Posts: 4441
Joined: Sun Oct 17, 2004 4:57 am
Location: Bordeaux, France

In favour---

Post by Clo »

:) Hello Paul !

• Naturally, an INI entry'ld be welcome, I support as :
BranchViewOnRoot=flag
Image0 : Disabled, displays a branch view with a first level of selected folder only, ignores the root (default).
Image1 : Displays all files contained in the drive as “flat”.
Attention ! That could hang the computer because it's very memory consuming ! At your own risk !
:mrgreen: Friendly,
Claude
Clo
Old user ON SELECTIVE STRIKE till further notice
User avatar
helmut
Posts: 8705
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Post by helmut »

Clicking on any different folder or pressing Esc key will stop the creation of the flat view. So I really don't see a need for an option, here.
User avatar
Clo
XnThusiast
Posts: 4441
Joined: Sun Oct 17, 2004 4:57 am
Location: Bordeaux, France

When frozen…

Post by Clo »

:arrow: helmut

• Again…

• When you have the programme beginning to hang by lack of memory, it gets frozen,
and you are no longer able to press or click anything whether it's too late :(

• That occured for me a few times, i.e. when trying to display huge image files (> 300 Mio).
- Hence, it seems that an option to keep the (wise) current behaviour by default should avoid such unpleasant events,
while the brave¦foolhardy users will be able to display the flat view of a full drive (good luck…).

:mrgreen: G.
Claude
Clo
Old user ON SELECTIVE STRIKE till further notice
User avatar
helmut
Posts: 8705
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Post by helmut »

If there are really problems (memory, performance, ...) with displaying the flat view these problems should be fixed. An option might help in some very few cases to avoid existing problems, but in general it won't (I don't have all my image files on the root directory and I guess and hope that 99.99% of the users also have them in subfolders). Why bother the user with a limitation that doesn't help much?
User avatar
Clo
XnThusiast
Posts: 4441
Joined: Sun Oct 17, 2004 4:57 am
Location: Bordeaux, France

ALL FILES !

Post by Clo »

:arrow: helmut

• Hi !
…(I don't have all my image files on the root directory and I guess and hope that 99.99% of the users also have them in subfolders)…
• But when you ask for branch view, you get ALL files of a drive “flat” ! And a majority can be displayed in XnView !
- Imagine what occurs for 50,000 and more (displayable) files…
… my larger drive is only 48.8 Gio (39.8 Gio free), it has that amount of files.
Many users have huge drives now, and they fill them happily with MP3, movies etc.

:mrgreen: G.
Claude
Clo
Old user ON SELECTIVE STRIKE till further notice
User avatar
helmut
Posts: 8705
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Post by helmut »

Again: An option will not help much or even not help at all. But it limits users.

A simple example:
A user might have all his/her 50.000 photos located in folder C:\Images and subfolders (actually not too unusual). The option would not prevent him/her from activating a flat view on C:\Images. But the option will prevent him/her from checking his/her whole memory stick N:\ for image files.

Let's improve XnView and make it handle difficult situations like huge files or dirs with lots of files properly. Limiting the user is not the right way to go.
Danny
Posts: 578
Joined: Sat Sep 04, 2004 5:09 pm

Post by Danny »

I agree that it's no wise idea to allow sub-dir listing from the root directory. When Joe Blow tries that on his shiny 500GB HDD filled with billions of stupid images of his feet kittens die right there. So leave it as is i say.
Get the bugs fixed, THEN start adding features. It sucks, but someone has to do it.
User avatar
JohnFredC
XnThusiast
Posts: 2010
Joined: Wed Mar 17, 2004 8:33 pm
Location: Sarasota Florida

Post by JohnFredC »

A simple alert/verification dialog solves all of this.

Such as:

Code: Select all

Preparing a Flat View of this folder/drive may take an indefinitely long period of time and consume all computer resources.  Proceed?

If you select Proceed, you may cancel the process at any time by pressing Esc.

[x] Don't show this dialog next time.

[Proceed]   [Cancel]
John