Favorites tree text color issue in recent versions

Bugs found in XnView Classic. Please report only one bug per topic!

Moderators: XnTriq, xnview

Post Reply
User avatar
JohnFredC
XnThusiast
Posts: 2010
Joined: Wed Mar 17, 2004 8:33 pm
Location: Sarasota Florida

Favorites tree text color issue in recent versions

Post by JohnFredC » Tue Oct 28, 2008 4:43 pm

Can anyone help me correct the issue illustrated in the screenshot? Is the favorites tree picking up the folder tree text color? Thanks in advance!

Image
John

User avatar
oops66
XnThusiast
Posts: 1999
Joined: Tue Jul 17, 2007 1:17 am
Location: France

"Edit Favorites" background Bug

Post by oops66 » Tue Oct 28, 2008 5:13 pm

Hello JohnFredC,
Bug confirmed !
Yes, and in your case, this is a white text with a white background too ! LOL
The background for the "Edit Favorites" window should be the same as the tree panel (dark gray too). :bugconfirmed:
XnViewMP 0.82 Linux X64 - Ubuntu 16.04 LTS - X64

User avatar
Troken
Posts: 698
Joined: Thu Feb 09, 2006 10:18 am
Location: Sweden

Post by Troken » Tue Oct 28, 2008 9:54 pm

Off topic:
JohnFredC, what are your color-settings? It sure looks nice, I'd like a tree-structure with grey background too...

User avatar
Clo
XnThusiast
Posts: 4441
Joined: Sun Oct 17, 2004 4:57 am
Location: Bordeaux, France
Contact:

Good here

Post by Clo » Tue Oct 28, 2008 10:11 pm

:arrow: JohnFredC

:) Hello John !

• There's no problem here, I get my custom colours from the INI entries alright for the tree,
Folders, Favourites and Categories :
TreeBackColor=255 255 222
TreeFontColor=60 0 0
TreeFontHiColor=180
TreeFontHiColor2=0 180 0
- Maybe are you using hexa code ? We had some issues with this in previous versions,
I didn't check yet… Decimal RGB is OK…

:mrgreen: KR
Claude
Clo
Old user ON SELECTIVE STRIKE till further notice

User avatar
oops66
XnThusiast
Posts: 1999
Joined: Tue Jul 17, 2007 1:17 am
Location: France

Post by oops66 » Tue Oct 28, 2008 10:24 pm

--> Clo,
Hello,
It is not about the Favorites panel but about the "Edit Favorites" window.
XnViewMP 0.82 Linux X64 - Ubuntu 16.04 LTS - X64

User avatar
JohnFredC
XnThusiast
Posts: 2010
Joined: Wed Mar 17, 2004 8:33 pm
Location: Sarasota Florida

Post by JohnFredC » Wed Oct 29, 2008 12:48 am

2Troken

Here my tree colors:

TreeBackColor=71 71 71
TreeFontColor=244 244 244
TreeFontHiColor=0 0 0
TreeFontHiColor2=0 0 0

2Clo

As oop66 said, apparently the TreeFontColor is used for the font color of the tree in the Edit Favorites dialog, but the TreeBackColor value is not used for the background color.
John

User avatar
Clo
XnThusiast
Posts: 4441
Joined: Sun Oct 17, 2004 4:57 am
Location: Bordeaux, France
Contact:

2 close colours

Post by Clo » Wed Oct 29, 2008 1:19 am

:arrow: JohnFredC

:) Again…
…As oop66 said, apparently the TreeFontColor is used for the font color of the tree in the Edit Favorites dialog, but the TreeBackColor value is not used for the background color.
• Yes, it's right, here I've my Win default BG colour, but it's very close to the tree one (255 - 255 - 214 vs. 255 255 222),
hence hard to spot at first glance…

• I don't know whether that can be fixed since it's a dialogue-box,
it seems that the Win BG takes precedence in such a case…

:mrgreen: KR
Claude
Clo
Old user ON SELECTIVE STRIKE till further notice

User avatar
xnview
Author of XnView
Posts: 31607
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: Favorites tree text color issue in recent versions

Post by xnview » Fri Jan 09, 2009 11:02 am

Please try XnView 1.96 beta
Pierre.

User avatar
JohnFredC
XnThusiast
Posts: 2010
Joined: Wed Mar 17, 2004 8:33 pm
Location: Sarasota Florida

Post by JohnFredC » Sat Jan 10, 2009 4:27 pm

Thank you Pierre. That fixed the text visability problem.

A folder icon background transparency issue still remains. It's purely a cosmetic problem, but the you can inspect the linked image in my original post to see it.

I'm running in 32bit color mode and the black backgrounds are visible in the Favorites dialog as well as in the MoveTo and CopyTo dialogs.
John

User avatar
xnview
Author of XnView
Posts: 31607
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Post by xnview » Mon Jan 12, 2009 9:55 am

JohnFredC wrote:Thank you Pierre. That fixed the text visability problem.

A folder icon background transparency issue still remains. It's purely a cosmetic problem, but the you can inspect the linked image in my original post to see it.

I'm running in 32bit color mode and the black backgrounds are visible in the Favorites dialog as well as in the MoveTo and CopyTo dialogs.
Yes, i have it, but it seems that it's a problem of windows API
Pierre.

User avatar
JohnFredC
XnThusiast
Posts: 2010
Joined: Wed Mar 17, 2004 8:33 pm
Location: Sarasota Florida

Post by JohnFredC » Mon Jan 12, 2009 1:34 pm

As I recall.. the black icon backgrounds haven't always been there.

I could maybe scrap up an old version (1.84?) to verify that.
John

User avatar
xnview
Author of XnView
Posts: 31607
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Post by xnview » Mon Jan 12, 2009 1:40 pm

JohnFredC wrote:As I recall.. the black icon backgrounds haven't always been there.

I could maybe scrap up an old version (1.84?) to verify that.
If you don't use background color, there is no problem...
Pierre.

User avatar
JohnFredC
XnThusiast
Posts: 2010
Joined: Wed Mar 17, 2004 8:33 pm
Location: Sarasota Florida

Post by JohnFredC » Mon Jan 12, 2009 3:49 pm

Ahhh... I see.

But the background for those icons comes from... the TreeBackColor? Even though the tree background (in the dialogs) ignores TreeBackColor?

Or have I missed an INI setting that specifically addresses the colors of the dialog (only) trees...???

It seems to me that the proper implementation for the folder trees in those dialogs is either:

1. Completely implement the INI tree color settings for all components

or

2. Completely ignore the INI tree color settings for all components.
John

User avatar
xnview
Author of XnView
Posts: 31607
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Post by xnview » Mon Jan 12, 2009 11:37 pm

JohnFredC wrote: But the background for those icons comes from... the TreeBackColor? Even though the tree background (in the dialogs) ignores TreeBackColor?
If you remove TreeBackColor from .ini, all must be correct.
Pierre.

User avatar
JohnFredC
XnThusiast
Posts: 2010
Joined: Wed Mar 17, 2004 8:33 pm
Location: Sarasota Florida

Post by JohnFredC » Tue Jan 13, 2009 1:10 am

Hmmm... well, I won't be doing that. I like my TreeBackColor.
John

Post Reply