MP 0.38.3 Win: "Enhance colors" & animated GIF --> CRASH

[budz45]

Hi,

1.) Open a animated GIF file in MP 0.38.3
2.) Then go to "Enhance colors" (a bit silly, I know)
3.) Right, don't configure anything in the "Enhance colors" window
4.) Right, now click on the tickbox of 'preview' for on/off a couple of times
5.) Animated GIF turns different colors (understandable) but then program crashes

I used the same 'smiley' animated GIF as the one in this post; http://newsgroup.xnview.com/viewtopic.p ... t=0#p95389

tested on Win 7 sp1

[marsh]

Confirmed. Same happens when using adjust> levels...

[budz45]

MP 0.38.4 - Right, there is some more slightly strange behavior.

A.
to reproduce;
1.) download & extract v0.38.4
2.) Create an 'xnview.ini' in the same extracted program folder
3.) Load the same smiley GIF in the viewer
4.) Go to 'Enhance colors'
5.) Click on the 'Preview' tickbox a number of times on/off
6.) Ok, no more instant crash (it seems)
7.) Now close MP and after program exits there is a crash

B.
Secondly, with each new beta I download and test, I always re-use my existing INI settings from previous app beta, so:

1.) download & extract v0.38.4
2.) copy previous ini (with all my settings) to the newly extracted folder
3.) Load smiley GIF (I loaded it from "recent files" as I frequently view same image)
4.) Now notice that 'Enhance colors' as well as other 'adjust' and 'rotate' etc are now all greyed out.
5.) first time I did the above reproduce steps, nothing was greyed out, the second time I did them, they were greyed out.

here is my attached xnview.ini

xnview.zip

(4.79 KiB) Downloaded 143 times

Good luck Pierre!

[xnview]

Strange, when i open an animated gif, all is greyed now

[budz45]

I know it's strange, the 'Enhance colors' is not getting greyed out but sometimes it does..
'

[xnview]

You use Open from browser?

[budz45]

Yes Pierre, i just checked, the greyed out does works when I open from Browser.

So the problem is when I open the animated GIF from either "Recent files" or from drag n drop from Win Explorer.

EDIT:-

So reproduce this:
1.) download & extract v0.38.7
2.) Create an 'xnview.ini' in the same extracted program folder
3.) Open any image file from the Browser, to open it in Viewer tab (not Win Explorer)
4.) Drag n drop the smiley GIF, from Win Explorer, to this same viewer tab
4.) Notice how 'Enhance colors' does not become greyed out in this case

...If I then close this Viewer tab and then open the same GIF from say "recent files" then the 'enahnce colors' it is greyed out as expected - which means the greyed-out instance is responding late in this particular case.

All things work just perfectly:
=If I open the GIF from the Browser
=If I open a animated GIF via .exe method on first ever time

[budz45]

OK, I have edited previous post and now reproduction is much clearer now and pretty evident to any user who reproduces it.

[marsh]

It still causes crash here:
1. Open enhance color on file previous to animated gif.
2. close
3. forward to animated gif
4. open enhance color is possible now.
5. backward to previous file = crash

[budz45]

So reproduce this:
1.) download & extract v0.38.7
2.) Create an 'xnview.ini' in the same extracted program folder
3.) Open any image file from the Browser, to open it in Viewer tab (not Win Explorer)
4.) Drag n drop the smiley GIF, from Win Explorer, to this same viewer tab
4.) Notice how 'Enhance colors' does not become greyed out in this case

Fixed in MP 0.38.8

It still causes crash here:
1. Open enhance color on file previous to animated gif.
2. close
3. forward to animated gif
4. open enhance color is possible now.
5. backward to previous file = crash

Fixed in MP 0.38.8

==================================================

But there is now a new same bug with 'Enhance Colors' not being greyed out with the "Start/Stop Animation" feature. For this a reproduction is simple:

1.) download & extract v0.38.8
2.) Create an 'xnview.ini' in the same extracted program folder
3.) Open smiley GIF in XnView MP, either by drag n drop, 'recent files' or from Browser
4.) Now simply just pause the GIF animation by pressing the "Start/Stop Animation" menu item/command.
5.) Notice that the 'Enhance Colors' is not greyed out now in this case, even when animation then get's resumed
6.) So the bug fix for 'Enhance Colors' & GIF/animated files needs to be applied to work with "Start/Stop Animation" too

[budz45]

But there is now a new same bug with 'Enhance Colors' not being greyed out with the "Start/Stop Animation" feature. For this a reproduction is simple:

1.) download & extract v0.38.8
2.) Create an 'xnview.ini' in the same extracted program folder
3.) Open smiley GIF in XnView MP, either by drag n drop, 'recent files' or from Browser
4.) Now simply just pause the GIF animation by pressing the "Start/Stop Animation" menu item/command.
5.) Notice that the 'Enhance Colors' is not greyed out now in this case, even when animation then get's resumed
6.) So the bug fix for 'Enhance Colors' & GIF/animated files needs to be applied to work with "Start/Stop Animation" too

I think the developer intends to keep non-greyed out 'Enhance Colors' during when an animated GIF is stopped because when an animated GIF is stopped/paused, on whatever particular frame, the XnView viewer would then treat the same displayed image as a regular static image. I also think that users may have the interest of editing individual frames in this manner ('Enhance Colors') and other manners thereby allowing them to 'save as' on the particular frame to a standard static image format e.g. JPG.

Currently in MP 0.38.10, if animated GIF is stopped via Start/Stop command and 'Enhance Colors' is performed by user to configure i.e. brightness or contrast - then as a user then closes 'Enhance Colors' after making those settings and then presses Start/Stop again to play the file the settings are disregarded (good thing!) as it is not meant to save it to an animated frame by frame image.

Which means.....

Fixed in MP 0.38.10