0.87 Beta1: Files steal focus when changing folder in Folder Tree

Reported bugs that have been closed and/or resolved

Moderators: XnTriq, xnview, Dreamer

Post Reply
arspr
Posts: 73
Joined: Sat Mar 25, 2017 12:25 pm

0.87 Beta1: Files steal focus when changing folder in Folder Tree

Post by arspr » Sun Jul 16, 2017 2:31 pm

XnView: MP 0.87beta1 - 64 bit
OS: Windows 10 64bit

Read the detailed step by step info

Effect: Focus is lost, inconsistent behaviour

To reproduce - Firstly the correct behaviour:
1. In Folder Tree change to any folder which ONLY contains subfolders. (I mean it has no files in it. Its children subfolder can contain whatever you want).
2. Now press F2 to change name.
3. Correctly, you start editing that folder name. As you are working in the Folder Tree, the focus remains in the Folder Tree, and therefore you edit your current item name.

Now the incorrect behaviour (bug):
1. In Folder Tree change to any folder which contains files.
2. Now press F2 to change name.
3. Wrongly, you've lost the focus in your Folder Tree, you start editing the first file name...

User avatar
xnview
Author of XnView
Posts: 30684
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: 0.87 Beta1: Files steal focus when changing folder in Folder Tree

Post by xnview » Tue Jul 18, 2017 9:56 am

right will be fixed in beta 3
Pierre.

HanVroon
Posts: 207
Joined: Thu Jan 28, 2010 7:30 am

Re: 0.87 Beta1: Files steal focus when changing folder in Folder Tree

Post by HanVroon » Fri Aug 18, 2017 12:45 pm

Tested with 0.87 beta 3, partly fixed.

Select a folder with no files, just files, pressing F2 starts the dialog to rename the folder. Tha was and is correct.

Select a folder containing files and subfolders, pressing F2 will edit the folder name, not a file in the folder anymore, which is correct.
But without Rename dialog but directly in the folder pane.
It ignores the setting: General, tab File operations, setting "Use dialog to rename file/folder", which is not correct.

User avatar
xnview
Author of XnView
Posts: 30684
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: 0.87 Beta1: Files steal focus when changing folder in Folder Tree

Post by xnview » Fri Aug 18, 2017 2:55 pm

HanVroon wrote: It ignores the setting: General, tab File operations, setting "Use dialog to rename file/folder", which is not correct.
this setting is only used in thumbnails view
Pierre.

HanVroon
Posts: 207
Joined: Thu Jan 28, 2010 7:30 am

Re: 0.87 Beta1: Files steal focus when changing folder in Folder Tree

Post by HanVroon » Sun Aug 20, 2017 8:34 am

Hi Pierre,

When testing, I am in the thumbnail view, so Browser mode.
My standard setting for thumbnail view is:
Settings, Browser, File list, tab Custom filter, Folders and Parent folder all unchecked.
So I always rename folders in the Folders pane.
Selecting a folder without files, just subfolders gives a rename dialog, selecting a folder with files does not give the dialog.
Because I get that dialog when renaming a folder without files, I suggested that this dialog should also appear when renaming a folder with files.

Test procedure:
- Use Browser mode.
- Select folder in the Folders pane that has no files, just subfolders with files. So because of my settings, the thumbnail pane is empty.
- Press F2. The File rename dialog box is shown. (now I notice that the title of the box is "File rename, not Folder rename, detail).
- Press Cancel to close the dialog.
- Select a folder in the Folders pane that contains files.
- Press F2.
- The folder in the Folders pane turns to an edit box, the File rename dialog box is not shown.

So, I think that this is inconsistent. Eighter the File rename dialog should not appear when renaming a folder without files, or the File rename dialog should also appear when renaming a folder with files.
If a Dialog box should appear in both cases in your opinion, it would be good if the program regonizes that a folder will be renamed so that the title of the dialog box is "Folder rename", not "File rename".

User avatar
xnview
Author of XnView
Posts: 30684
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: 0.87 Beta1: Files steal focus when changing folder in Folder Tree

Post by xnview » Sun Aug 20, 2017 3:34 pm

right, i can reproduce now
Pierre.

HanVroon
Posts: 207
Joined: Thu Jan 28, 2010 7:30 am

Re: 0.87 Beta1: Files steal focus when changing folder in Folder Tree

Post by HanVroon » Tue Sep 12, 2017 2:30 pm

Tested with 0.87 final, fixed.

Now, when "Use dialog to rename file/folder" is checked, for both empty folders amd folders with files the dialog box is shown.

Post Reply