b1: Too many menu items for closing tab

Bugs found in XnView Classic. Please report only one bug per topic!

Moderators: helmut, XnTriq, xnview

User avatar
helmut
Posts: 8704
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

b1: Too many menu items for closing tab

Post by helmut »

In 1.82 Beta1 we have three options in the context menu of the (folder) tabs:

- Close
- Close all except this one and browser
- Close all expect this one
- Close all

I think this is a bit too much. The menu item "Close all except this one and browser" should be removed since it is not needed. "Close all" and "Close all except this one" must not close the browser (same behaviour as menu item "File > Close all).

This should be sufficient:
- Close
- Close all expect this one
- Close all

Original topic is add "close all tabs except this one"

XnView 1.82
Last edited by helmut on Sat Feb 18, 2006 2:52 pm, edited 2 times in total.
Dreamer
XnThusiast
Posts: 4608
Joined: Sun Jul 25, 2004 9:08 pm

Post by Dreamer »

I agree, but users could expect that also browser tab will be closed, what about these terms, or similar...

- Close
- Close all image tabs expect this one
- Close all image tabs

Or use "except browser" instead of "all image tabs".
FlorianH
Posts: 121
Joined: Fri Dec 09, 2005 8:28 am
Location: Munich, Germany

Post by FlorianH »

I think the idea of Dreamer is good:
- Close image/browser tab
- Close all tabs except browser and this one
- Close all tabs except browser

Perhaps the entries in file menu should be more precise too:
- Close image/browser tab
- Close all tabs except browser

I'm not sure if it's possible to set the first entry context sensitive. So it would be "Close browser tab" or "Close image tab", depending on the active tab.
User avatar
helmut
Posts: 8704
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Post by helmut »

Dreamer wrote:I agree, but users could expect that also browser tab will be closed, what about these terms, or similar...
We have "File -> Close all" which closes all images except browser tab. I think there's no need to be more specific.
User avatar
helmut
Posts: 8704
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Post by helmut »

FlorianH wrote:I think the idea of Dreamer is good:
- Close image/browser tab
- Close all tabs except browser and this one
- Close all tabs except browser
100% correct and precise but far too long labels, I think. Instead of being more usable the long labels makes it less usable.
FlorianH wrote: Perhaps the entries in file menu should be more precise too:
- Close image/browser tab
- Close all tabs except browser

I'm not sure if it's possible to set the first entry context sensitive. So it would be "Close browser tab" or "Close image tab", depending on the active tab.
Same as above. 100% correct but not good: Too long labels, also it's bad GUI design to change labels of menu items. This will irritate users.
FlorianH
Posts: 121
Joined: Fri Dec 09, 2005 8:28 am
Location: Munich, Germany

Post by FlorianH »

helmut wrote:
FlorianH wrote:I think the idea of Dreamer is good:
- Close image/browser tab
- Close all tabs except browser and this one
- Close all tabs except browser
100% correct and precise but far too long labels, I think. Instead of being more usable the long labels makes it less usable.
FlorianH wrote: Perhaps the entries in file menu should be more precise too:
- Close image/browser tab
- Close all tabs except browser

I'm not sure if it's possible to set the first entry context sensitive. So it would be "Close browser tab" or "Close image tab", depending on the active tab.
Same as above. 100% correct but not good: Too long labels, also it's bad GUI design to change labels of menu items. This will irritate users.
I know/knew that the labels are quite long or too long (perhaps i find something shorter).
But i think it's allowed to have different menu items because we have different menus for viewer and browser. The user knows it (or its obvious to him), i think!?
User avatar
helmut
Posts: 8704
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Post by helmut »

FlorianH wrote:I know/knew that the labels are quite long or too long (perhaps i find something shorter).
O.k.
FlorianH wrote:But i think it's allowed to have different menu items because we have different menus for viewer and browser. The user knows it (or its obvious to him), i think!?
The different menus for viewer and browser are o.k. since these are different modes and the user understands this concept (even if some people ask to make them similar). And changing menu items depending on selecton is o.k. for context menu, but not for the main menu.
FlorianH
Posts: 121
Joined: Fri Dec 09, 2005 8:28 am
Location: Munich, Germany

Post by FlorianH »

helmut wrote:The different menus for viewer and browser are o.k. since these are different modes and the user understands this concept (even if some people ask to make them similar). And changing menu items depending on selecton is o.k. for context menu, but not for the main menu.
My suggestion is:
a) change 'Close' to 'Close browser tab' in File-Menu from browser mode
b) change 'Close' to 'Close viewer tab' in File-Menu from viewer mode

So the menus would be a little bit more different (but more precise and descriptive).
User avatar
helmut
Posts: 8704
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Post by helmut »

FlorianH wrote:
helmut wrote:The different menus for viewer and browser are o.k. since these are different modes and the user understands this concept (even if some people ask to make them similar). And changing menu items depending on selecton is o.k. for context menu, but not for the main menu.
My suggestion is:
a) change 'Close' to 'Close browser tab' in File-Menu from browser mode
b) change 'Close' to 'Close viewer tab' in File-Menu from viewer mode

So the menus would be a little bit more different (but more precise and descriptive).
When using menu items it's important to have a good mixture between length and clearlness. At the moment I don't see a reason why we should change "Close" to "Close browser tab" or "Close viewer tab".
Dreamer
XnThusiast
Posts: 4608
Joined: Sun Jul 25, 2004 9:08 pm

Post by Dreamer »

helmut wrote:
FlorianH wrote:I think the idea of Dreamer is good:
- Close image/browser tab
- Close all tabs except browser and this one
- Close all tabs except browser
100% correct and precise but far too long labels, I think. Instead of being more usable the long labels makes it less usable.
OK, but some users will maybe never use it because they don't want to close the browser. I don't use tabs in xnview, but I use it in my internet browser and there are quite long labels there, but it's all clear.

So another ideas (shorter):
- Close
- Close all image tabs
- Close all image tabs except the current

or:
- Close
- Close all view tabs
- Close all view tabs except the current

or: "viewer" instead of "view"

About the first "close" item - I agree with Helmut.
User avatar
helmut
Posts: 8704
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Post by helmut »

Dreamer & Florian: If things are changed in context menu of tabs, you will have to change it in File menu, too.

I think

- Close
- Close other
- Close all

would be short and clear. Again: The browser plays a special role, "Close all" and "Close other" will never close XnView browser.
Tommy
Posts: 127
Joined: Sat Dec 03, 2005 8:59 am

Post by Tommy »

- Close
- Close other
- Close all

i support this menu labels: simple, clear and short! :D
Dreamer
XnThusiast
Posts: 4608
Joined: Sun Jul 25, 2004 9:08 pm

Post by Dreamer »

helmut wrote:Dreamer & Florian: If things are changed in context menu of tabs, you will have to change it in File menu, too.
Of course.
helmut wrote:- Close
- Close other
- Close all

would be short and clear. Again: The browser plays a special role, "Close all" and "Close other" will never close XnView browser.
I disagree - definitely not clear! It would be confusing for (not only) novice/normal users (it would be confusing also for me).
User avatar
helmut
Posts: 8704
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Post by helmut »

Dreamer wrote:...
I disagree - definitely not clear! It would be confusing for (not only) novice/normal users (it would be confusing also for me).
Why are these menu items not clear?
Dreamer
XnThusiast
Posts: 4608
Joined: Sun Jul 25, 2004 9:08 pm

Post by Dreamer »

helmut wrote:
Dreamer wrote:...
I disagree - definitely not clear! It would be confusing for (not only) novice/normal users (it would be confusing also for me).
Why are these menu items not clear?
Since they are not correct.

E.g. you have these tabs opened:

- view tab 1
- view tab 2
- view tab 3
- browser tab

You right click the view tab 1 and choose "close other", but - browser tab is still opened. Same with the "close all".
Post Reply