Installer - add check for running instance

Ideas for improvements and requests for new features in XnView MP

Moderator: xnview

User avatar
user0
XnThusiast
Posts: 3189
Joined: Sat May 09, 2015 9:37 am

Installer - add check for running instance

Post by user0 »

XnViewMP 1.11.7
Windows11 (25H2), display resolution 3840x2160, dpi scale 150%


Installer
when app instance is running:
- installation (update) fails with 'DeleteFile, code 5' (Access denied) on some files (QtConcurrent.dll, mdk.dll, msvcp140_1.dll, etc)
- uninstallation leaves files undeleted
installer_error5.png

Suggestion
  • add a running-instance check to Inno Setup
    - (optional) add RestartApplications=yes

    Code: Select all

    [Setup]
    AppMutex=XnViewMP_Running
    CloseApplications=yes
    RestartApplications=yes
    
    same behaviour as running current installer with /CLOSEAPPLICATIONS flag
You do not have the required permissions to view the files attached to this post.
User avatar
xnview
Author of XnView
Posts: 48993
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Re: Installer - add check for running instance

Post by xnview »

will be fixed for 1.12.1
User avatar
user0
XnThusiast
Posts: 3189
Joined: Sat May 09, 2015 9:37 am

Re: Installer - add check for running instance

Post by user0 »

1.12.1
installer - fixed

uninstaller - remains
if app is running, uninstaller does not close it.
As a result, it fails to delete app folder and some files, even after the prompted reboot.