JPEG quality slider moves the wrong way on keyboard input

Bugs found in XnView Classic. Please report only one bug per topic!

Moderators: helmut, XnTriq, xnview

TheEvilHammer
Posts: 55
Joined: Mon Sep 12, 2005 8:08 pm

JPEG quality slider moves the wrong way on keyboard input

Post by TheEvilHammer »

To repro:
  1. Open Tools → Options → General → Read/Write.
  2. Select the Write tab and then select JPEG.
  3. Use the mouse to put the current focus on the Quality slider control.
  4. Press the up key and the quality decreases; press the down key and the quality increases.
User avatar
helmut
Posts: 8704
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Re: JPEG quality slider moves the wrong way on keyboard input

Post by helmut »

"Confirmed", but I'm not sure whether this is really a bug:

Sliders' value increases by pressing "Down" this is Windows standard. Now, Pierre has combined two controls: The slider and editext with spinbutton. Pressing down while focus is on the slider increases the value whereas pressing down in the edittext decreases the values.

In order to make this combined control work consistently it might make sense to change the slider behaviour, but this would be no longer Windows standard, then. And it might be quite some effort, because the combined control is used in many dialogs, in "Image > Adjust > Brightness.." for example.

All in all I'd say this is a small nuisance - but also the little things working properly make up a good software...
TheEvilHammer
Posts: 55
Joined: Mon Sep 12, 2005 8:08 pm

Re: JPEG quality slider moves the wrong way on keyboard input

Post by TheEvilHammer »

helmut wrote:Sliders' value increases by pressing "Down" this is Windows standard.
Are you sure this is true? I just tried it out and I'm not seeing that behavior. Open Control Panel → Sounds and Audio Devices and you'll see a horizontal slider. If you press Down while the focus is on the slider, it moves to the left, which is exactly what I would expect. Why do you think that the Windows standard is the other way around?
User avatar
Clo
XnThusiast
Posts: 4441
Joined: Sun Oct 17, 2004 4:57 am
Location: Bordeaux, France
Contact:

Re: JPEG quality slider moves the wrong way on keyboard input

Post by Clo »

:arrow: TheEvilHammer

:) Hello !
…Open Control Panel → Sounds and Audio Devices and you'll see a horizontal slider. If you press Down while the focus is on the slider, it moves to the left, which is exactly what I would expect. …
I confirm this. Keys:

Down (or left) Image Minus
Up (or right) :arrow: Plus
- That work by steps (with an irritating “beep” for each key press).
BUT :
… 4. Press the up key and the quality decreases; press the down key and the quality increases. …
• I cannot confirm that in XnView 1.96.5 ! Here, it works as expected in this dialogue-box (and also i.e. in the Adjust… ones).
- XP-Pro SP1 (Fr)

:mrgreen: KR
Claude
Clo
Old user ON SELECTIVE STRIKE till further notice
TheEvilHammer
Posts: 55
Joined: Mon Sep 12, 2005 8:08 pm

Re: JPEG quality slider moves the wrong way on keyboard input

Post by TheEvilHammer »

Clo wrote: • I cannot confirm that in XnView 1.96.5 !
I am actually running 1.96.2, so maybe the problem has been fixed? I will upgrade and try again...
TheEvilHammer
Posts: 55
Joined: Mon Sep 12, 2005 8:08 pm

Re: JPEG quality slider moves the wrong way on keyboard input

Post by TheEvilHammer »

I just tried 1.96.5 and I'm seeing the same problem.
User avatar
helmut
Posts: 8704
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Re: JPEG quality slider moves the wrong way on keyboard input

Post by helmut »

I've just double-checked with some applications and found that there seems to be no real standard for the Up/Down keys. Some applications (e.g. Logitech Quickcam or old Windows Common Controls slider) use "Down" for a higher value, some applications like the volume control of Windows use "Down" for a lower value.

Using "Up key" for a higher value and "Down key for lower value is more logical, especially in combination with the edittext/spinbutton. So if possible (and not too much effort) this should be changed.
User avatar
xnview
Author of XnView
Posts: 46236
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: JPEG quality slider moves the wrong way on keyboard input

Post by xnview »

I've tried with 1.96.5, and up increase
Pierre.
User avatar
XnTriq
Moderator & Librarian
Posts: 6512
Joined: Sun Sep 25, 2005 3:00 am
Location: Ref Desk

Re: JPEG quality slider moves the wrong way on keyboard input

Post by XnTriq »

How to reproduce:
  1. Place the mouse cursor inside the field with the spin box controls.
    • Up arrow key = increases value
    • Down arrow key = decreases value
    • Left arrow key = no action
    • Right arrow key = no action
  2. Click on the slider control.
    • Up arrow key = decreases value :bug:
    • Down arrow key = increases value :bug:
    • Left arrow key = decreases value
    • Right arrow key = increases value
Same behavior:
  • File » Export... » JPEG » Quality
  • Tools » Options... » General » Read/Write » Write » JPEG » Parameters » Quality
__________________________________
XnView v1.96.5 @ Windows 2000 SP4
User avatar
xnview
Author of XnView
Posts: 46236
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: JPEG quality slider moves the wrong way on keyboard input

Post by xnview »

XnTriq wrote:
  • Up arrow key = decreases value :bug:
  • Down arrow key = increases value :bug:
  • Left arrow key = decreases value
  • Right arrow key = increases value
[/list]
It's not a bug, but the standard behaviour
Pierre.
TheEvilHammer
Posts: 55
Joined: Mon Sep 12, 2005 8:08 pm

Re: JPEG quality slider moves the wrong way on keyboard input

Post by TheEvilHammer »

I think the consensus is that this "standard behavior" is not intuitive and doesn't match up with Windows, which is why we're suggesting the change.
User avatar
xnview
Author of XnView
Posts: 46236
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: JPEG quality slider moves the wrong way on keyboard input

Post by xnview »

TheEvilHammer wrote:I think the consensus is that this "standard behavior" is not intuitive and doesn't match up with Windows, which is why we're suggesting the change.
I can't change it, it's the standard behavior of this windows control :-)
Pierre.
TheEvilHammer
Posts: 55
Joined: Mon Sep 12, 2005 8:08 pm

Re: JPEG quality slider moves the wrong way on keyboard input

Post by TheEvilHammer »

xnview wrote:
TheEvilHammer wrote:I think the consensus is that this "standard behavior" is not intuitive and doesn't match up with Windows, which is why we're suggesting the change.
I can't change it, it's the standard behavior of this windows control :-)
Oh, I see what you're saying now. Really? That's very odd, considering that I've used other slider controls in Windows that didn't work that way...
User avatar
ckv
Posts: 786
Joined: Wed Feb 02, 2005 2:30 pm
Location: Glow
Contact:

Re: JPEG quality slider moves the wrong way on keyboard input

Post by ckv »

TheEvilHammer wrote:Oh, I see what you're saying now. Really? That's very odd, considering that I've used other slider controls in Windows that didn't work that way...
There is no need to be disrespectful.
xnview wrote:I can't change it, it's the standard behavior of this windows control :-)
There's a trackbar control style called TBS_DOWNISLEFT (0x0400) that will reverse the up and down keys.
XnView Tweak UI - Tool to customize your XnView beyond the regular XnView options.
UI-less Settings - Documentation of all the hidden settings in XnView.
XFAM - Tool to create and customize XnView file associations.
TheEvilHammer
Posts: 55
Joined: Mon Sep 12, 2005 8:08 pm

Re: JPEG quality slider moves the wrong way on keyboard input

Post by TheEvilHammer »

ckv wrote:
TheEvilHammer wrote:Oh, I see what you're saying now. Really? That's very odd, considering that I've used other slider controls in Windows that didn't work that way...
There is no need to be disrespectful.
What are you talking about? I was not being disrespectful to anyone. All I was saying was that I've seen the opposite behavior in Windows, which is merely an observation, and it contradicts what Pierre has noticed, making the situation "very odd", as I said.
Post Reply